* [PATCH] fpga: zynq-fpga: Remove redundant dev_err()
@ 2026-07-13 13:22 Pan Chuang
2026-07-13 13:48 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-13 13:22 UTC (permalink / raw)
To: Moritz Fischer, Xu Yilun, Tom Rix, Michal Simek,
open list:FPGA MANAGER FRAMEWORK,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/fpga/zynq-fpga.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index 9d1d599ef718..2f8ba32e4002 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -598,7 +598,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
err = devm_request_irq(dev, priv->irq, zynq_fpga_isr, 0, dev_name(dev),
priv);
if (err) {
- dev_err(dev, "unable to request IRQ\n");
clk_disable_unprepare(priv->clk);
return err;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fpga: zynq-fpga: Remove redundant dev_err()
2026-07-13 13:22 [PATCH] fpga: zynq-fpga: Remove redundant dev_err() Pan Chuang
@ 2026-07-13 13:48 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2026-07-13 13:48 UTC (permalink / raw)
To: Pan Chuang, Moritz Fischer, Xu Yilun, Tom Rix,
open list:FPGA MANAGER FRAMEWORK,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
On 7/13/26 15:22, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/fpga/zynq-fpga.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 9d1d599ef718..2f8ba32e4002 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -598,7 +598,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> err = devm_request_irq(dev, priv->irq, zynq_fpga_isr, 0, dev_name(dev),
> priv);
> if (err) {
> - dev_err(dev, "unable to request IRQ\n");
> clk_disable_unprepare(priv->clk);
> return err;
> }
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-13 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 13:22 [PATCH] fpga: zynq-fpga: Remove redundant dev_err() Pan Chuang
2026-07-13 13:48 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox