* [PATCH v2 1/7] clk: mvebu: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 [PATCH v2 0/7] clk: clean-up simple provider misuse of the consumer API Jerome Brunet
@ 2026-07-24 9:03 ` Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 2/7] clk: qcom: " Jerome Brunet
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2026-07-24 9:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Michael Turquette, Stephen Boyd, Brian Masney, Bjorn Andersson,
Geert Uytterhoeven, Heiko Stuebner, Prashant Gaikwad,
Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap,
Jerome Brunet
Clock provider should not be using the consumer interface.
In other words, a provider should not be dealing with struct clk.
This change targets occurrences for which the provider uses the
consumer interface and corresponding clk_hw interface exist.
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/mvebu/clk-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
index 26d52ecaac50..24196e288fe2 100644
--- a/drivers/clk/mvebu/clk-cpu.c
+++ b/drivers/clk/mvebu/clk-cpu.c
@@ -153,7 +153,7 @@ static int clk_cpu_on_set_rate(struct clk_hw *hwclk, unsigned long rate,
static int clk_cpu_set_rate(struct clk_hw *hwclk, unsigned long rate,
unsigned long parent_rate)
{
- if (__clk_is_enabled(hwclk->clk))
+ if (clk_hw_is_enabled(hwclk))
return clk_cpu_on_set_rate(hwclk, rate, parent_rate);
else
return clk_cpu_off_set_rate(hwclk, rate, parent_rate);
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 2/7] clk: qcom: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 [PATCH v2 0/7] clk: clean-up simple provider misuse of the consumer API Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 1/7] clk: mvebu: " Jerome Brunet
@ 2026-07-24 9:03 ` Jerome Brunet
2026-07-24 12:22 ` Konrad Dybcio
2026-07-24 9:03 ` [PATCH v2 3/7] clk: renesas: " Jerome Brunet
` (4 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Jerome Brunet @ 2026-07-24 9:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Michael Turquette, Stephen Boyd, Brian Masney, Bjorn Andersson,
Geert Uytterhoeven, Heiko Stuebner, Prashant Gaikwad,
Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap,
Jerome Brunet
Clock provider should not be using the consumer interface.
In other words, a provider should not be dealing with struct clk.
This change targets occurrences for which the provider uses the
consumer interface and corresponding clk_hw interface exist.
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/qcom/clk-hfpll.c | 4 ++--
drivers/clk/qcom/clk-krait.c | 2 +-
drivers/clk/qcom/clk-rcg.c | 4 ++--
drivers/clk/qcom/clk-rcg2.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/qcom/clk-hfpll.c b/drivers/clk/qcom/clk-hfpll.c
index 705352aff067..9e9118d24df7 100644
--- a/drivers/clk/qcom/clk-hfpll.c
+++ b/drivers/clk/qcom/clk-hfpll.c
@@ -166,7 +166,7 @@ static int clk_hfpll_set_rate(struct clk_hw *hw, unsigned long rate,
spin_lock_irqsave(&h->lock, flags);
- enabled = __clk_is_enabled(hw->clk);
+ enabled = clk_hw_is_enabled(hw);
if (enabled)
__clk_hfpll_disable(h);
@@ -220,7 +220,7 @@ static int clk_hfpll_init(struct clk_hw *hw)
regmap_read(regmap, hd->status_reg, &status);
if (!(status & BIT(hd->lock_bit))) {
WARN(1, "HFPLL %s is ON, but not locked!\n",
- __clk_get_name(hw->clk));
+ clk_hw_get_name(hw));
clk_hfpll_disable(hw);
__clk_hfpll_init_once(hw);
}
diff --git a/drivers/clk/qcom/clk-krait.c b/drivers/clk/qcom/clk-krait.c
index f5ce403e1e27..5e4408b7445d 100644
--- a/drivers/clk/qcom/clk-krait.c
+++ b/drivers/clk/qcom/clk-krait.c
@@ -68,7 +68,7 @@ static int krait_mux_set_parent(struct clk_hw *hw, u8 index)
sel = clk_mux_index_to_val(mux->parent_map, 0, index);
mux->en_mask = sel;
/* Don't touch mux if CPU is off as it won't work */
- if (__clk_is_enabled(hw->clk))
+ if (clk_hw_is_enabled(hw))
__krait_mux_set_sel(mux, sel);
mux->reparent = true;
diff --git a/drivers/clk/qcom/clk-rcg.c b/drivers/clk/qcom/clk-rcg.c
index 31f0650b48ba..1664101e8f78 100644
--- a/drivers/clk/qcom/clk-rcg.c
+++ b/drivers/clk/qcom/clk-rcg.c
@@ -208,7 +208,7 @@ static int configure_bank(struct clk_dyn_rcg *rcg, const struct freq_tbl *f)
bool banked_p = !!rcg->p[1].pre_div_width;
struct clk_hw *hw = &rcg->clkr.hw;
- enabled = __clk_is_enabled(hw->clk);
+ enabled = clk_hw_is_enabled(hw);
ret = regmap_read(rcg->clkr.regmap, rcg->bank_reg, ®);
if (ret)
@@ -771,7 +771,7 @@ static int clk_rcg_lcc_set_rate(struct clk_hw *hw, unsigned long rate,
regmap_update_bits(rcg->clkr.regmap, rcg->ns_reg, gfm, 0);
ret = __clk_rcg_set_rate(rcg, f);
/* Switch back to M/N if it's clocking */
- if (__clk_is_enabled(hw->clk))
+ if (clk_hw_is_enabled(hw))
regmap_update_bits(rcg->clkr.regmap, rcg->ns_reg, gfm, gfm);
return ret;
diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
index 6064a0e17d51..d7914e59129f 100644
--- a/drivers/clk/qcom/clk-rcg2.c
+++ b/drivers/clk/qcom/clk-rcg2.c
@@ -489,7 +489,7 @@ static int clk_rcg2_determine_gp_rate(struct clk_hw *hw,
u64 parent_rate;
parent = clk_hw_get_parent(hw);
- parent_rate = clk_get_rate(parent->clk);
+ parent_rate = clk_hw_get_rate(parent);
if (!parent_rate)
return -EINVAL;
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/7] clk: qcom: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 ` [PATCH v2 2/7] clk: qcom: " Jerome Brunet
@ 2026-07-24 12:22 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2026-07-24 12:22 UTC (permalink / raw)
To: Jerome Brunet, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Michael Turquette, Stephen Boyd,
Brian Masney, Bjorn Andersson, Geert Uytterhoeven, Heiko Stuebner,
Prashant Gaikwad, Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap
On 7/24/26 11:03 AM, Jerome Brunet wrote:
> Clock provider should not be using the consumer interface.
> In other words, a provider should not be dealing with struct clk.
>
> This change targets occurrences for which the provider uses the
> consumer interface and corresponding clk_hw interface exist.
>
> Reviewed-by: Brian Masney <bmasney@redhat.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/7] clk: renesas: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 [PATCH v2 0/7] clk: clean-up simple provider misuse of the consumer API Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 1/7] clk: mvebu: " Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 2/7] clk: qcom: " Jerome Brunet
@ 2026-07-24 9:03 ` Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 4/7] clk: rockchip: " Jerome Brunet
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2026-07-24 9:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Michael Turquette, Stephen Boyd, Brian Masney, Bjorn Andersson,
Geert Uytterhoeven, Heiko Stuebner, Prashant Gaikwad,
Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap,
Jerome Brunet
Clock provider should not be using the consumer interface.
In other words, a provider should not be dealing with struct clk.
This change targets occurrences for which the provider uses the
consumer interface and corresponding clk_hw interface exist.
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/renesas/r9a06g032-clocks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c
index 076f587dfd39..1da25e4fb4d7 100644
--- a/drivers/clk/renesas/r9a06g032-clocks.c
+++ b/drivers/clk/renesas/r9a06g032-clocks.c
@@ -1014,7 +1014,7 @@ r9a06g032_div_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
if (clk->index == R9A06G032_DIV_UART ||
clk->index == R9A06G032_DIV_P2_PG) {
pr_devel("%s div uart hack!\n", __func__);
- req->rate = clk_get_rate(hw->clk);
+ req->rate = clk_hw_get_rate(hw);
return 0;
}
req->rate = DIV_ROUND_UP(req->best_parent_rate, div);
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 4/7] clk: rockchip: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 [PATCH v2 0/7] clk: clean-up simple provider misuse of the consumer API Jerome Brunet
` (2 preceding siblings ...)
2026-07-24 9:03 ` [PATCH v2 3/7] clk: renesas: " Jerome Brunet
@ 2026-07-24 9:03 ` Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 5/7] clk: st: " Jerome Brunet
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2026-07-24 9:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Michael Turquette, Stephen Boyd, Brian Masney, Bjorn Andersson,
Geert Uytterhoeven, Heiko Stuebner, Prashant Gaikwad,
Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap,
Jerome Brunet
Clock provider should not be using the consumer interface.
In other words, a provider should not be dealing with struct clk.
This change targets occurrences for which the provider uses the
consumer interface and corresponding clk_hw interface exist.
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/rockchip/clk-pll.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c
index 6b853800cb6b..89a783204f0e 100644
--- a/drivers/clk/rockchip/clk-pll.c
+++ b/drivers/clk/rockchip/clk-pll.c
@@ -259,13 +259,13 @@ static int rockchip_rk3036_pll_set_rate(struct clk_hw *hw, unsigned long drate,
const struct rockchip_pll_rate_table *rate;
pr_debug("%s: changing %s to %lu with a parent rate of %lu\n",
- __func__, __clk_get_name(hw->clk), drate, prate);
+ __func__, clk_hw_get_name(hw), drate, prate);
/* Get required rate settings from table */
rate = rockchip_get_pll_settings(pll, drate);
if (!rate) {
pr_err("%s: Invalid rate : %lu for pll clk %s\n", __func__,
- drate, __clk_get_name(hw->clk));
+ drate, clk_hw_get_name(hw));
return -EINVAL;
}
@@ -319,7 +319,7 @@ static int rockchip_rk3036_pll_init(struct clk_hw *hw)
rockchip_rk3036_pll_get_params(pll, &cur);
- pr_debug("%s: pll %s@%lu: Hz\n", __func__, __clk_get_name(hw->clk),
+ pr_debug("%s: pll %s@%lu: Hz\n", __func__, clk_hw_get_name(hw),
drate);
pr_debug("old - fbdiv: %d, postdiv1: %d, refdiv: %d, postdiv2: %d, dsmpd: %d, frac: %d\n",
cur.fbdiv, cur.postdiv1, cur.refdiv, cur.postdiv2,
@@ -336,12 +336,12 @@ static int rockchip_rk3036_pll_init(struct clk_hw *hw)
if (!parent) {
pr_warn("%s: parent of %s not available\n",
- __func__, __clk_get_name(hw->clk));
+ __func__, clk_hw_get_name(hw));
return 0;
}
pr_debug("%s: pll %s: rate params do not match rate table, adjusting\n",
- __func__, __clk_get_name(hw->clk));
+ __func__, clk_hw_get_name(hw));
rockchip_rk3036_pll_set_params(pll, rate);
}
@@ -743,13 +743,13 @@ static int rockchip_rk3399_pll_set_rate(struct clk_hw *hw, unsigned long drate,
const struct rockchip_pll_rate_table *rate;
pr_debug("%s: changing %s to %lu with a parent rate of %lu\n",
- __func__, __clk_get_name(hw->clk), drate, prate);
+ __func__, clk_hw_get_name(hw), drate, prate);
/* Get required rate settings from table */
rate = rockchip_get_pll_settings(pll, drate);
if (!rate) {
pr_err("%s: Invalid rate : %lu for pll clk %s\n", __func__,
- drate, __clk_get_name(hw->clk));
+ drate, clk_hw_get_name(hw));
return -EINVAL;
}
@@ -803,7 +803,7 @@ static int rockchip_rk3399_pll_init(struct clk_hw *hw)
rockchip_rk3399_pll_get_params(pll, &cur);
- pr_debug("%s: pll %s@%lu: Hz\n", __func__, __clk_get_name(hw->clk),
+ pr_debug("%s: pll %s@%lu: Hz\n", __func__, clk_hw_get_name(hw),
drate);
pr_debug("old - fbdiv: %d, postdiv1: %d, refdiv: %d, postdiv2: %d, dsmpd: %d, frac: %d\n",
cur.fbdiv, cur.postdiv1, cur.refdiv, cur.postdiv2,
@@ -820,12 +820,12 @@ static int rockchip_rk3399_pll_init(struct clk_hw *hw)
if (!parent) {
pr_warn("%s: parent of %s not available\n",
- __func__, __clk_get_name(hw->clk));
+ __func__, clk_hw_get_name(hw));
return 0;
}
pr_debug("%s: pll %s: rate params do not match rate table, adjusting\n",
- __func__, __clk_get_name(hw->clk));
+ __func__, clk_hw_get_name(hw));
rockchip_rk3399_pll_set_params(pll, rate);
}
@@ -992,13 +992,13 @@ static int rockchip_rk3588_pll_set_rate(struct clk_hw *hw, unsigned long drate,
const struct rockchip_pll_rate_table *rate;
pr_debug("%s: changing %s to %lu with a parent rate of %lu\n",
- __func__, __clk_get_name(hw->clk), drate, prate);
+ __func__, clk_hw_get_name(hw), drate, prate);
/* Get required rate settings from table */
rate = rockchip_get_pll_settings(pll, drate);
if (!rate) {
pr_err("%s: Invalid rate : %lu for pll clk %s\n", __func__,
- drate, __clk_get_name(hw->clk));
+ drate, clk_hw_get_name(hw));
return -EINVAL;
}
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 5/7] clk: st: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 [PATCH v2 0/7] clk: clean-up simple provider misuse of the consumer API Jerome Brunet
` (3 preceding siblings ...)
2026-07-24 9:03 ` [PATCH v2 4/7] clk: rockchip: " Jerome Brunet
@ 2026-07-24 9:03 ` Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 6/7] clk: tegra: " Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 7/7] clk: ti: " Jerome Brunet
6 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2026-07-24 9:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Michael Turquette, Stephen Boyd, Brian Masney, Bjorn Andersson,
Geert Uytterhoeven, Heiko Stuebner, Prashant Gaikwad,
Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap,
Jerome Brunet
Clock provider should not be using the consumer interface.
In other words, a provider should not be dealing with struct clk.
This change targets occurrences for which the provider uses the
consumer interface and corresponding clk_hw interface exist.
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/st/clkgen-pll.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index 9eb2cb83fa69..17551c6a879a 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -260,7 +260,7 @@ static int __clkgen_pll_enable(struct clk_hw *hw)
if (pll->data->switch2pll_en)
CLKGEN_WRITE(pll, switch2pll, 0);
- pr_debug("%s:%s enabled\n", __clk_get_name(hw->clk), __func__);
+ pr_debug("%s:%s enabled\n", clk_hw_get_name(hw), __func__);
}
return ret;
@@ -295,7 +295,7 @@ static void __clkgen_pll_disable(struct clk_hw *hw)
CLKGEN_WRITE(pll, pdn_ctrl, 1);
- pr_debug("%s:%s disabled\n", __clk_get_name(hw->clk), __func__);
+ pr_debug("%s:%s disabled\n", clk_hw_get_name(hw), __func__);
}
static void clkgen_pll_disable(struct clk_hw *hw)
@@ -405,14 +405,14 @@ static int stm_pll3200c32_determine_rate(struct clk_hw *hw,
&req->rate);
else {
pr_debug("%s: %s rate %ld Invalid\n", __func__,
- __clk_get_name(hw->clk), req->rate);
+ clk_hw_get_name(hw), req->rate);
req->rate = 0;
return 0;
}
pr_debug("%s: %s new rate %ld [ndiv=%u] [idf=%u]\n",
- __func__, __clk_get_name(hw->clk),
+ __func__, clk_hw_get_name(hw),
req->rate, (unsigned int)params.ndiv,
(unsigned int)params.idf);
@@ -434,7 +434,7 @@ static int set_rate_stm_pll3200c32(struct clk_hw *hw, unsigned long rate,
clk_pll3200c32_get_rate(parent_rate, ¶ms, &hwrate);
pr_debug("%s: %s new rate %ld [ndiv=0x%x] [idf=0x%x]\n",
- __func__, __clk_get_name(hw->clk),
+ __func__, clk_hw_get_name(hw),
hwrate, (unsigned int)params.ndiv,
(unsigned int)params.idf);
@@ -547,7 +547,7 @@ static unsigned long recalc_stm_pll4600c28(struct clk_hw *hw,
clk_pll4600c28_get_rate(parent_rate, ¶ms, &rate);
- pr_debug("%s:%s rate %lu\n", __clk_get_name(hw->clk), __func__, rate);
+ pr_debug("%s:%s rate %lu\n", clk_hw_get_name(hw), __func__, rate);
return rate;
}
@@ -562,14 +562,14 @@ static int stm_pll4600c28_determine_rate(struct clk_hw *hw,
&req->rate);
} else {
pr_debug("%s: %s rate %ld Invalid\n", __func__,
- __clk_get_name(hw->clk), req->rate);
+ clk_hw_get_name(hw), req->rate);
req->rate = 0;
return 0;
}
pr_debug("%s: %s new rate %ld [ndiv=%u] [idf=%u]\n",
- __func__, __clk_get_name(hw->clk),
+ __func__, clk_hw_get_name(hw),
req->rate, (unsigned int)params.ndiv,
(unsigned int)params.idf);
@@ -591,12 +591,12 @@ static int set_rate_stm_pll4600c28(struct clk_hw *hw, unsigned long rate,
clk_pll4600c28_get_rate(parent_rate, ¶ms, &hwrate);
} else {
pr_debug("%s: %s rate %ld Invalid\n", __func__,
- __clk_get_name(hw->clk), rate);
+ clk_hw_get_name(hw), rate);
return -EINVAL;
}
pr_debug("%s: %s new rate %ld [ndiv=0x%x] [idf=0x%x]\n",
- __func__, __clk_get_name(hw->clk),
+ __func__, clk_hw_get_name(hw),
hwrate, (unsigned int)params.ndiv,
(unsigned int)params.idf);
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 6/7] clk: tegra: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 [PATCH v2 0/7] clk: clean-up simple provider misuse of the consumer API Jerome Brunet
` (4 preceding siblings ...)
2026-07-24 9:03 ` [PATCH v2 5/7] clk: st: " Jerome Brunet
@ 2026-07-24 9:03 ` Jerome Brunet
2026-07-24 9:03 ` [PATCH v2 7/7] clk: ti: " Jerome Brunet
6 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2026-07-24 9:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Michael Turquette, Stephen Boyd, Brian Masney, Bjorn Andersson,
Geert Uytterhoeven, Heiko Stuebner, Prashant Gaikwad,
Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap,
Jerome Brunet
Clock provider should not be using the consumer interface.
In other words, a provider should not be dealing with struct clk.
This change targets occurrences for which the provider uses the
consumer interface and corresponding clk_hw interface exist.
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/tegra/clk-tegra210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c
index 0c86cff719e3..df1d7b471745 100644
--- a/drivers/clk/tegra/clk-tegra210.c
+++ b/drivers/clk/tegra/clk-tegra210.c
@@ -1460,7 +1460,7 @@ static int tegra210_pllx_dyn_ramp(struct tegra_clk_pll *pllx,
udelay(1);
pr_debug("%s: dynamic ramp to m = %u n = %u p = %u, Fout = %lu kHz\n",
- __clk_get_name(pllx->hw.clk), cfg->m, cfg->n, cfg->p,
+ clk_hw_get_name(&pllx->hw), cfg->m, cfg->n, cfg->p,
cfg->input_rate / cfg->m * cfg->n /
pllx->params->pdiv_tohw[cfg->p].pdiv / 1000);
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 7/7] clk: ti: clean-up simple provider misuse of the consumer API
2026-07-24 9:03 [PATCH v2 0/7] clk: clean-up simple provider misuse of the consumer API Jerome Brunet
` (5 preceding siblings ...)
2026-07-24 9:03 ` [PATCH v2 6/7] clk: tegra: " Jerome Brunet
@ 2026-07-24 9:03 ` Jerome Brunet
6 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2026-07-24 9:03 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Michael Turquette, Stephen Boyd, Brian Masney, Bjorn Andersson,
Geert Uytterhoeven, Heiko Stuebner, Prashant Gaikwad,
Thierry Reding, Jonathan Hunter, Tero Kristo
Cc: linux-arm-kernel, linux-clk, linux-kernel, linux-arm-msm,
linux-renesas-soc, linux-rockchip, linux-tegra, linux-omap,
Jerome Brunet
Clock provider should not be using the consumer interface.
In other words, a provider should not be dealing with struct clk.
This change targets occurrences for which the provider uses the
consumer interface and corresponding clk_hw interface exist.
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/ti/clockdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
index c897ad7e681e..aedbe78bf1e4 100644
--- a/drivers/clk/ti/clockdomain.c
+++ b/drivers/clk/ti/clockdomain.c
@@ -104,7 +104,7 @@ int omap2_init_clk_clkdm(struct clk_hw *hw)
if (!clk->clkdm_name)
return 0;
- clk_name = __clk_get_name(hw->clk);
+ clk_name = clk_hw_get_name(hw);
clkdm = ti_clk_ll_ops->clkdm_lookup(clk->clkdm_name);
if (clkdm) {
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread