From: Romain Gantois <romain.gantois@bootlin.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Romain Gantois <romain.gantois@bootlin.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Sylvain Girard <sylvain.girard@se.com>,
Vladimir Oltean <olteanv@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Pascal EBERHARD <pascal.eberhard@se.com>,
Richard Tresidder <rtresidd@electromag.com.au>,
Linus Walleij <linus.walleij@linaro.org>,
netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH net v2 1/1] net: stmmac: Prevent DSA tags from breaking COE on stmmac
Date: Wed, 3 Jan 2024 09:40:40 +0100 (CET) [thread overview]
Message-ID: <753d4eab-5699-91e3-05a4-d0e03f7052e6@bootlin.com> (raw)
In-Reply-To: <e2250240-db19-4cb6-93ca-2384a382cdd5@gmail.com>
Hi Florian,
On Tue, 2 Jan 2024, Florian Fainelli wrote:
...
> > Fixes: 6b2c6e4a938f ("net: stmmac: propagate feature flags to vlan")
> > Cc: stable@vger.kernel.org
> > Reported-by: Richard Tresidder <rtresidd@electromag.com.au>
> > Closes:
> > https://lore.kernel.org/netdev/e5c6c75f-2dfa-4e50-a1fb-6bf4cdb617c2@electromag.com.au/
> > Reported-by: Romain Gantois <romain.gantois@bootlin.com>
> > Closes:
> > https://lore.kernel.org/netdev/c57283ed-6b9b-b0e6-ee12-5655c1c54495@bootlin.com/
>
> Fairly sure those should be Link: and Closes: should be used for bug tracker
> entries.
ACK
> > + return (proto == htons(ETH_P_IP)) || (proto == htons(ETH_P_IPV6)) ||
> > + (proto == htons(ETH_P_8021Q));
>
> Do you need to include ETH_P_8021AD in that list as well or is not stmmac
> capable of checksuming beyond a single VLAN tag?
The datasheet for my Ethernet controller doesn't mention 802.1ad tag
handling and I ran some loopback tests that showed that this controller doesn't
recognize 802.1ad frames as vlan frames. I also haven't seen anything in the
stmmac driver that suggests that 802.1ad offloading is supported. Maybe the
stmmac maintainers could weigh in on this?
Best Regards,
--
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-03 8:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 16:27 [PATCH net v2 0/1] Prevent DSA tags from breaking COE Romain Gantois
2024-01-02 16:27 ` [PATCH net v2 1/1] net: stmmac: Prevent DSA tags from breaking COE on stmmac Romain Gantois
2024-01-02 20:26 ` Florian Fainelli
2024-01-03 8:40 ` Romain Gantois [this message]
2024-01-02 20:27 ` Linus Walleij
2024-01-03 9:11 ` Romain Gantois
2024-01-03 16:42 ` Linus Walleij
2024-01-03 20:10 ` Vladimir Oltean
2024-01-03 22:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=753d4eab-5699-91e3-05a4-d0e03f7052e6@bootlin.com \
--to=romain.gantois@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=rtresidd@electromag.com.au \
--cc=stable@vger.kernel.org \
--cc=sylvain.girard@se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox