From: Zhentao Guo <zhentao.guo@amlogic.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder
Date: Mon, 27 Jul 2026 14:32:38 +0800 [thread overview]
Message-ID: <787775ec-bcf8-4474-a772-88780c49262d@amlogic.com> (raw)
In-Reply-To: <20260727-brawny-silent-kangaroo-a02c9c@quoll>
Hi Krzysztof
> On Fri, Jul 24, 2026 at 03:04:53PM +0800, Zhentao Guo wrote:
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/clock/amlogic,s4-pll-clkc.h>
>> + #include <dt-bindings/clock/amlogic,s4-peripherals-clkc.h>
>> + #include <dt-bindings/power/meson-s4-power.h>
>> + #include <dt-bindings/reset/amlogic,meson-s4-reset.h>
>> + video-codec@fe320000 {
>> + compatible = "amlogic,s4-vdec";
>> + reg = <0xfe320000 0x10000>,
>> + <0xfe036000 0x20>;
>> + amlogic,canvas = <&canvas>;
>> + reg-names = "dos",
>> + "dmc";
> Please read carefully DTS coding style.
>
> You also need to address all comments from Sashiko.
Thanks for pointing out, I'm checking all the comments from Sashiko and
will give out my improvement.
>
> Best regards,
> Krzysztof
BRs
Zhentao
next prev parent reply other threads:[~2026-07-27 6:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 7:04 [PATCH v6 0/6] Add Amlogic stateless H.264 video decoder for S4 Zhentao Guo via B4 Relay
2026-07-24 7:04 ` [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call Zhentao Guo via B4 Relay
2026-07-25 7:13 ` Piotr Oniszczuk
2026-07-27 2:57 ` Zhentao Guo
2026-07-24 7:04 ` [PATCH v6 2/6] firmware: meson: sm: video firmware loading via secure monitor Zhentao Guo via B4 Relay
2026-07-24 10:22 ` Ferass El Hafidi
2026-07-24 7:04 ` [PATCH v6 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Zhentao Guo via B4 Relay
2026-07-27 6:23 ` Krzysztof Kozlowski
2026-07-27 6:32 ` Zhentao Guo [this message]
2026-07-24 7:04 ` [PATCH v6 5/6] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs Zhentao Guo via B4 Relay
2026-07-24 7:04 ` [PATCH v6 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC Zhentao Guo via B4 Relay
2026-07-27 6:24 ` Krzysztof Kozlowski
2026-07-27 6:26 ` Krzysztof Kozlowski
2026-07-27 6:36 ` Zhentao Guo
2026-07-27 7:02 ` Krzysztof Kozlowski
2026-07-27 7:19 ` Zhentao Guo
2026-07-24 10:13 ` [PATCH v6 0/6] Add Amlogic stateless H.264 video decoder for S4 Ferass El Hafidi
2026-07-27 2:43 ` Zhentao Guo
[not found] ` <20260724-b4-s4-vdec-upstream-v6-4-6072a7ee7428@amlogic.com>
2026-07-27 6:31 ` [PATCH v6 4/6] decoder: Add V4L2 stateless H.264 decoder driver Krzysztof Kozlowski
2026-07-27 7:12 ` Zhentao Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787775ec-bcf8-4474-a772-88780c49262d@amlogic.com \
--to=zhentao.guo@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox