From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Stephen Boyd" <sboyd@kernel.org>
Cc: kernel@collabora.com, Chen-Yu Tsai <wenst@chromium.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Ikjoon Jang <ikjn@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Miles Chen <miles.chen@mediatek.com>,
Ran Jianping <ran.jianping@zte.com.cn>,
Weiyi Lu <weiyi.lu@mediatek.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] clk: mediatek: Don't check HW status for mt8192/5's imp_iic_wrap clocks
Date: Tue, 12 Jul 2022 12:41:26 +0200 [thread overview]
Message-ID: <79a79313-00e0-632f-f238-95686362675e@collabora.com> (raw)
In-Reply-To: <20220711205733.203963-1-nfraprado@collabora.com>
Il 11/07/22 22:57, Nícolas F. R. A. Prado ha scritto:
> The imp_iic_wrap clocks on mt8192/mt8195 require that the i2c_sel parent
> clock be enabled before their hardware status can be checked. Since this
> wasn't taken into account, reading from the clk_summary debugfs file
> would cause the system to completely freeze.
>
> Assuming that this clock is managed only by the kernel, and not by any
> firmware, simply drop the is_enabled() optional callback and instead
> rely on the enable count for the imp_iic_wrap clocks.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
For both MT8192 and MT8195:
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>
> drivers/clk/mediatek/clk-gate.c | 6 ++++++
> drivers/clk/mediatek/clk-gate.h | 1 +
> drivers/clk/mediatek/clk-mt8192-imp_iic_wrap.c | 2 +-
> drivers/clk/mediatek/clk-mt8195-imp_iic_wrap.c | 2 +-
> 4 files changed, 9 insertions(+), 2 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-12 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 20:57 [PATCH] clk: mediatek: Don't check HW status for mt8192/5's imp_iic_wrap clocks Nícolas F. R. A. Prado
2022-07-12 10:41 ` AngeloGioacchino Del Regno [this message]
2022-07-12 10:44 ` Chen-Yu Tsai
2022-07-12 10:55 ` AngeloGioacchino Del Regno
2022-07-12 10:56 ` Chen-Yu Tsai
2022-07-12 10:57 ` AngeloGioacchino Del Regno
2022-07-12 14:00 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a79313-00e0-632f-f238-95686362675e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=ikjn@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=ran.jianping@zte.com.cn \
--cc=sboyd@kernel.org \
--cc=weiyi.lu@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox