From: Qi Liu <liuqi115@huawei.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Al.Grant@arm.com, suzuki.poulose@arm.com, linuxarm@huawei.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org
Subject: Re: [PATCH] coresight: funnel: Remove unnecessary .owner of static funnel driver
Date: Tue, 3 Nov 2020 09:18:15 +0800 [thread overview]
Message-ID: <813ceaa8-9bad-6e10-45f8-a56656519f63@huawei.com> (raw)
In-Reply-To: <20201102172330.GB2749502@xps15>
Hi Mathieu,
On 2020/11/3 1:23, Mathieu Poirier wrote:
> Hi Liu,
>
> On Sat, Oct 31, 2020 at 06:12:30PM +0800, Qi Liu wrote:
>> As driver.owner has been set in platform_driver_register(), it is
>> unnecessary to set it in static funnel driver, so remove it from
>> struct static_funnel_driver.
>>
>> Signed-off-by: Qi Liu <liuqi115@huawei.com>
>> ---
>> drivers/hwtracing/coresight/coresight-funnel.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
>> index af40814..07bc203 100644
>> --- a/drivers/hwtracing/coresight/coresight-funnel.c
>> +++ b/drivers/hwtracing/coresight/coresight-funnel.c
>> @@ -356,7 +356,6 @@ static struct platform_driver static_funnel_driver = {
>> .remove = static_funnel_remove,
>> .driver = {
>> .name = "coresight-static-funnel",
>> - .owner = THIS_MODULE,
> I received two identical patches (with a different title) from you. Since there
> was no explanation I will discard the first one and work with this one.
>
> You are correct, platform_driver_register() does take care of THIS_MODULE.
> Please send another revision where you will do three things:
>
> 1) CC the coresight mailing list, as instructed by get_maintainer.pl
> 1) Also fix the replicator driver.
> 2) Add a comment that clearly mentions THIS_MODULE doesn't need to be set:
>
> .name = "coresight-static-funnel",
> /* THIS_MODULE is taken care of by platform_driver_register() */
> .of_match_table = static_funnel_match,
> .acpi_match_table = ACPI_PTR(static_funnel_ids),
> .pm = &funnel_dev_pm_ops,
>
> Thanks,
> Mathieu
Thanks for your review , I'll send a new patch latter.
Liu
>> --
>> 2.8.1
>>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-03 1:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 10:12 [PATCH] coresight: funnel: Remove unnecessary .owner of static funnel driver Qi Liu
2020-11-02 17:23 ` Mathieu Poirier
2020-11-03 1:18 ` Qi Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=813ceaa8-9bad-6e10-45f8-a56656519f63@huawei.com \
--to=liuqi115@huawei.com \
--cc=Al.Grant@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox