From: Stefan Wahren <wahrenst@gmx.net>
To: Fabio Estevam <festevam@gmail.com>, shawnguo@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH 1/2] ARM: mxs: Do not search for "fsl,clkctrl"
Date: Tue, 5 Dec 2023 19:49:09 +0100 [thread overview]
Message-ID: <82b93cc9-556f-434f-a48e-2c2353fbcd09@gmx.net> (raw)
In-Reply-To: <20231205144713.2053916-1-festevam@gmail.com>
Hi Fabio,
Am 05.12.23 um 15:47 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> The "fsl,clkctrl" compatible string is not documented.
>
> It is used only to find the base address of the clock controller.
>
> Instead of searching for an undocumented compatible string, search
> for "fsl,imx23-clkctrl" and "fsl,imx28-clkctrl".
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm/mach-mxs/mach-mxs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
> index 3faf9a1e3e36..6e017fa306c8 100644
> --- a/arch/arm/mach-mxs/mach-mxs.c
> +++ b/arch/arm/mach-mxs/mach-mxs.c
> @@ -356,7 +356,9 @@ static int __init mxs_restart_init(void)
> {
> struct device_node *np;
>
> - np = of_find_compatible_node(NULL, NULL, "fsl,clkctrl");
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx23-clkctrl");
> + if (!np)
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx28-clkctrl");
i'm fine with getting the rid off "fsl,clkctrl", but some lines below we
search for "fsl,imx23-clkctrl" again to adjust reset_addr.
Can we avoid this unnecessary search?
> reset_addr = of_iomap(np, 0);
> if (!reset_addr)
> return -ENODEV;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-05 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 14:47 [PATCH 1/2] ARM: mxs: Do not search for "fsl,clkctrl" Fabio Estevam
2023-12-05 14:47 ` [PATCH 2/2] ARM: dts: imx23/28: Remove undocumented "fsl,clkctrl" Fabio Estevam
2023-12-05 18:54 ` Stefan Wahren
2023-12-05 18:49 ` Stefan Wahren [this message]
2023-12-06 3:22 ` [PATCH 1/2] ARM: mxs: Do not search for "fsl,clkctrl" Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b93cc9-556f-434f-a48e-2c2353fbcd09@gmx.net \
--to=wahrenst@gmx.net \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox