* [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings
@ 2024-01-21 5:18 Randy Dunlap
2024-01-22 10:45 ` Andre Przywara
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2024-01-21 5:18 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Emilio López, Michael Turquette, Stephen Boyd,
linux-clk, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi
Move the function description kernel-doc comment to immediately above
the function implementation, correct the function name in the comment,
then add a function parameter description to prevent these kernel-doc
warnings:
drivers/clk/sunxi/clk-sun9i-cpus.c:25: warning: expecting prototype for sun9i_a80_cpus_clk_setup(). Prototype was for SUN9I_CPUS_MAX_PARENTS() instead
clk-sun9i-cpus.c:184: warning: Function parameter or struct member 'node' not described in 'sun9i_a80_cpus_setup'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Emilio López <emilio@elopez.com.ar>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@lists.linux.dev
---
drivers/clk/sunxi/clk-sun9i-cpus.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff -- a/drivers/clk/sunxi/clk-sun9i-cpus.c b/drivers/clk/sunxi/clk-sun9i-cpus.c
--- a/drivers/clk/sunxi/clk-sun9i-cpus.c
+++ b/drivers/clk/sunxi/clk-sun9i-cpus.c
@@ -18,9 +18,6 @@
static DEFINE_SPINLOCK(sun9i_a80_cpus_lock);
-/**
- * sun9i_a80_cpus_clk_setup() - Setup function for a80 cpus composite clk
- */
#define SUN9I_CPUS_MAX_PARENTS 4
#define SUN9I_CPUS_MUX_PARENT_PLL4 3
@@ -180,6 +177,10 @@ static const struct clk_ops sun9i_a80_cp
.set_rate = sun9i_a80_cpus_clk_set_rate,
};
+/**
+ * sun9i_a80_cpus_setup() - Setup function for a80 cpus composite clk
+ * @node: &struct device_node for the clock
+ */
static void sun9i_a80_cpus_setup(struct device_node *node)
{
const char *clk_name = node->name;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings
2024-01-21 5:18 [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings Randy Dunlap
@ 2024-01-22 10:45 ` Andre Przywara
2024-01-23 17:42 ` Jernej Škrabec
2024-01-23 20:57 ` Jernej Škrabec
2 siblings, 0 replies; 4+ messages in thread
From: Andre Przywara @ 2024-01-22 10:45 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Emilio López, Michael Turquette, Stephen Boyd,
linux-clk, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi
On Sat, 20 Jan 2024 21:18:44 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> Move the function description kernel-doc comment to immediately above
> the function implementation, correct the function name in the comment,
> then add a function parameter description to prevent these kernel-doc
> warnings:
>
> drivers/clk/sunxi/clk-sun9i-cpus.c:25: warning: expecting prototype for sun9i_a80_cpus_clk_setup(). Prototype was for SUN9I_CPUS_MAX_PARENTS() instead
> clk-sun9i-cpus.c:184: warning: Function parameter or struct member 'node' not described in 'sun9i_a80_cpus_setup'
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Emilio López <emilio@elopez.com.ar>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-clk@vger.kernel.org
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-sunxi@lists.linux.dev
> ---
> drivers/clk/sunxi/clk-sun9i-cpus.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff -- a/drivers/clk/sunxi/clk-sun9i-cpus.c b/drivers/clk/sunxi/clk-sun9i-cpus.c
> --- a/drivers/clk/sunxi/clk-sun9i-cpus.c
> +++ b/drivers/clk/sunxi/clk-sun9i-cpus.c
> @@ -18,9 +18,6 @@
>
> static DEFINE_SPINLOCK(sun9i_a80_cpus_lock);
>
> -/**
> - * sun9i_a80_cpus_clk_setup() - Setup function for a80 cpus composite clk
> - */
>
> #define SUN9I_CPUS_MAX_PARENTS 4
> #define SUN9I_CPUS_MUX_PARENT_PLL4 3
> @@ -180,6 +177,10 @@ static const struct clk_ops sun9i_a80_cp
> .set_rate = sun9i_a80_cpus_clk_set_rate,
> };
>
> +/**
> + * sun9i_a80_cpus_setup() - Setup function for a80 cpus composite clk
> + * @node: &struct device_node for the clock
> + */
> static void sun9i_a80_cpus_setup(struct device_node *node)
> {
> const char *clk_name = node->name;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings
2024-01-21 5:18 [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings Randy Dunlap
2024-01-22 10:45 ` Andre Przywara
@ 2024-01-23 17:42 ` Jernej Škrabec
2024-01-23 20:57 ` Jernej Škrabec
2 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2024-01-23 17:42 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Randy Dunlap, Emilio López, Michael Turquette, Stephen Boyd,
linux-clk, Chen-Yu Tsai, Samuel Holland, linux-arm-kernel,
linux-sunxi
Dne nedelja, 21. januar 2024 ob 06:18:44 CET je Randy Dunlap napisal(a):
> Move the function description kernel-doc comment to immediately above
> the function implementation, correct the function name in the comment,
> then add a function parameter description to prevent these kernel-doc
> warnings:
>
> drivers/clk/sunxi/clk-sun9i-cpus.c:25: warning: expecting prototype for sun9i_a80_cpus_clk_setup(). Prototype was for SUN9I_CPUS_MAX_PARENTS() instead
> clk-sun9i-cpus.c:184: warning: Function parameter or struct member 'node' not described in 'sun9i_a80_cpus_setup'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Emilio López <emilio@elopez.com.ar>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-clk@vger.kernel.org
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-sunxi@lists.linux.dev
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings
2024-01-21 5:18 [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings Randy Dunlap
2024-01-22 10:45 ` Andre Przywara
2024-01-23 17:42 ` Jernej Škrabec
@ 2024-01-23 20:57 ` Jernej Škrabec
2 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2024-01-23 20:57 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Randy Dunlap, Emilio López, Michael Turquette, Stephen Boyd,
linux-clk, Chen-Yu Tsai, Samuel Holland, linux-arm-kernel,
linux-sunxi
Dne nedelja, 21. januar 2024 ob 06:18:44 CET je Randy Dunlap napisal(a):
> Move the function description kernel-doc comment to immediately above
> the function implementation, correct the function name in the comment,
> then add a function parameter description to prevent these kernel-doc
> warnings:
>
> drivers/clk/sunxi/clk-sun9i-cpus.c:25: warning: expecting prototype for sun9i_a80_cpus_clk_setup(). Prototype was for SUN9I_CPUS_MAX_PARENTS() instead
> clk-sun9i-cpus.c:184: warning: Function parameter or struct member 'node' not described in 'sun9i_a80_cpus_setup'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Emilio López <emilio@elopez.com.ar>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-clk@vger.kernel.org
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-sunxi@lists.linux.dev
Merged, thanks!
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-23 20:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-21 5:18 [PATCH] clk: sunxi: sun9i-cpus: fix kernel-doc warnings Randy Dunlap
2024-01-22 10:45 ` Andre Przywara
2024-01-23 17:42 ` Jernej Škrabec
2024-01-23 20:57 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox