From: uajain <uajain@igalia.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Stefan Wahren" <wahrenst@gmx.net>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Rohit Chavan" <roheetchavan@gmail.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: vchiq_arm: delete unnecessary check
Date: Wed, 29 Oct 2025 13:18:57 +0000 [thread overview]
Message-ID: <86db61cb04863e9799eb20962a47ecdc@igalia.com> (raw)
In-Reply-To: <aQIS6Q73Ss8xyJTD@stanley.mountain>
On 2025-10-29 13:13, Dan Carpenter wrote:
> Both sides of this if else statement print exactly the same thing.
> Delete the unnecessary if statement.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
LGTM,
Reviewed-by: Umang Jain <uajain@igalia.com>
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index e2cac0898b8f..130be2f58342 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -4001,10 +4001,7 @@ void vchiq_log_dump_mem(struct device *dev, const char *label, u32 addr,
> }
> *s++ = '\0';
>
> - if (label && (*label != '\0'))
> - dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
> - else
> - dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
> + dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
>
> addr += 16;
> mem += 16;
prev parent reply other threads:[~2025-10-29 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:13 [PATCH] staging: vchiq_arm: delete unnecessary check Dan Carpenter
2025-10-29 13:18 ` uajain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86db61cb04863e9799eb20962a47ecdc@igalia.com \
--to=uajain@igalia.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=roheetchavan@gmail.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox