* [PATCH] staging: vchiq_arm: delete unnecessary check
@ 2025-10-29 13:13 Dan Carpenter
2025-10-29 13:18 ` uajain
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-10-29 13:13 UTC (permalink / raw)
To: Florian Fainelli
Cc: Broadcom internal kernel review list, Greg Kroah-Hartman,
Umang Jain, Stefan Wahren, Thomas Weißschuh, Rohit Chavan,
linux-rpi-kernel, linux-arm-kernel, linux-staging, linux-kernel,
kernel-janitors
Both sides of this if else statement print exactly the same thing.
Delete the unnecessary if statement.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index e2cac0898b8f..130be2f58342 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -4001,10 +4001,7 @@ void vchiq_log_dump_mem(struct device *dev, const char *label, u32 addr,
}
*s++ = '\0';
- if (label && (*label != '\0'))
- dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
- else
- dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
+ dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
addr += 16;
mem += 16;
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vchiq_arm: delete unnecessary check
2025-10-29 13:13 [PATCH] staging: vchiq_arm: delete unnecessary check Dan Carpenter
@ 2025-10-29 13:18 ` uajain
0 siblings, 0 replies; 2+ messages in thread
From: uajain @ 2025-10-29 13:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Florian Fainelli, Broadcom internal kernel review list,
Greg Kroah-Hartman, Stefan Wahren, Thomas Weißschuh,
Rohit Chavan, linux-rpi-kernel, linux-arm-kernel, linux-staging,
linux-kernel, kernel-janitors
On 2025-10-29 13:13, Dan Carpenter wrote:
> Both sides of this if else statement print exactly the same thing.
> Delete the unnecessary if statement.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
LGTM,
Reviewed-by: Umang Jain <uajain@igalia.com>
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index e2cac0898b8f..130be2f58342 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -4001,10 +4001,7 @@ void vchiq_log_dump_mem(struct device *dev, const char *label, u32 addr,
> }
> *s++ = '\0';
>
> - if (label && (*label != '\0'))
> - dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
> - else
> - dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
> + dev_dbg(dev, "core: %s: %08x: %s\n", label, addr, line_buf);
>
> addr += 16;
> mem += 16;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-29 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-29 13:13 [PATCH] staging: vchiq_arm: delete unnecessary check Dan Carpenter
2025-10-29 13:18 ` uajain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox