Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Jinqian Yang <yangjinqian1@huawei.com>,
	lpieralisi@kernel.org, maz@kernel.org, alex@shazbot.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, liuyonglong@huawei.com,
	wangzhou1@hisilicon.com, linuxarm@huawei.com,
	Jinqian Yang <yangjinqian1@huawei.com>
Subject: Re: [RFC PATCH v2] irqchip/gic-v3-its: enable dynamic MSI-X allocation
Date: Sat, 11 Jul 2026 22:37:30 +0200	[thread overview]
Message-ID: <877bn1qn3p.ffs@fw13> (raw)
In-Reply-To: <20260711022015.3049867-1-yangjinqian1@huawei.com>

On Sat, Jul 11 2026 at 10:20, Jinqian Yang wrote:
> On ARM64 platforms with GICv3 ITS, VFIO PCI passthrough currently
> cannot dynamically allocate MSI-X vectors after MSI-X has been
> enabled. When QEMU needs to extend the vector range, it must
> disable MSI-X, free all interrupts, then re-enable with a larger
> allocation. This creates an interrupt loss window for already-active
> vectors.
>
> Consider HNS3 with RoCE: NIC and RDMA share one PCI device and
> ITS DeviceID, with MSI-X vectors partitioned as NIC (lower range)
> then RoCE (starting at base_vector = num_nic_msi). In VFIO
> passthrough, loading hns_roce after hns3 forces QEMU to tear down
> all interrupts before re-allocating the larger range. During this
> process, NIC interrupts may be lost. Testing confirmed that this
> occasionally occurs, causing the network port reset to fail. This
> appears to be unavoidable, as it's a standard approach adopted by
> all network card vendors.
>
> On Hisilicon HIP09 (ARM64, GICv3/GICv4.1) with latest upstream kernel
> and QEMU 8.2. VFIO passthrough of HNS3 NIC to VM: load both hns3 and
> hns_roce_hw_v2 drivers and trigger FLR, this bug will occur occasionally.
> After enabling dynamic MSIX allocation, this bug no longer occurs.
>
> Signed-off-by: Jinqian Yang <yangjinqian1@huawei.com>
> ---
> Changes in v2:
>   - Updated the commit message to add test information.

Well, it contains test information, but it does not tell me _WHY_ this
is safe to do, i.e. what makes gic-v3-its eligible to set this flag? 


      parent reply	other threads:[~2026-07-11 20:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-11  2:20 [RFC PATCH v2] irqchip/gic-v3-its: enable dynamic MSI-X allocation Jinqian Yang
2026-07-11  7:04 ` Marc Zyngier
2026-07-11 20:37 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bn1qn3p.ffs@fw13 \
    --to=tglx@kernel.org \
    --cc=alex@shazbot.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=lpieralisi@kernel.org \
    --cc=maz@kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=yangjinqian1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox