* [PATCH] soc: fsl: dpio: Remove redundant dev_err()
@ 2026-07-23 2:47 Pan Chuang
2026-07-27 9:47 ` Christophe Leroy (CS GROUP)
2026-07-27 10:18 ` Christophe Leroy (CS GROUP)
0 siblings, 2 replies; 4+ messages in thread
From: Pan Chuang @ 2026-07-23 2:47 UTC (permalink / raw)
To: Roy Pledge, Christophe Leroy (CS GROUP),
open list:DPAA2 DATAPATH I/O (DPIO) DRIVER,
open list:FREESCALE SOC DRIVERS,
moderated list:FREESCALE SOC DRIVERS
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/fsl/dpio/dpio-driver.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c
index 9e3fddd8f5a9..d5198ffc4455 100644
--- a/drivers/soc/fsl/dpio/dpio-driver.c
+++ b/drivers/soc/fsl/dpio/dpio-driver.c
@@ -102,12 +102,8 @@ static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
0,
dev_name(&dpio_dev->dev),
&dpio_dev->dev);
- if (error < 0) {
- dev_err(&dpio_dev->dev,
- "devm_request_irq() failed: %d\n",
- error);
+ if (error < 0)
return error;
- }
/* set the affinity hint */
if (irq_set_affinity_hint(irq->virq, cpumask_of(cpu)))
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: fsl: dpio: Remove redundant dev_err()
2026-07-23 2:47 [PATCH] soc: fsl: dpio: Remove redundant dev_err() Pan Chuang
@ 2026-07-27 9:47 ` Christophe Leroy (CS GROUP)
2026-07-27 9:55 ` Ioana Ciornei
2026-07-27 10:18 ` Christophe Leroy (CS GROUP)
1 sibling, 1 reply; 4+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-07-27 9:47 UTC (permalink / raw)
To: Pan Chuang, Ioana Ciornei
Cc: Roy Pledge, open list:FREESCALE SOC DRIVERS,
open list:DPAA2 DATAPATH I/O (DPIO) DRIVER,
moderated list:FREESCALE SOC DRIVERS
Hi Ioana,
Le 23/07/2026 à 04:47, Pan Chuang a écrit :
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
I plan to take this patch for v7.3, do you agree with this change ?
Thanks
Christophe
> ---
> drivers/soc/fsl/dpio/dpio-driver.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c
> index 9e3fddd8f5a9..d5198ffc4455 100644
> --- a/drivers/soc/fsl/dpio/dpio-driver.c
> +++ b/drivers/soc/fsl/dpio/dpio-driver.c
> @@ -102,12 +102,8 @@ static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
> 0,
> dev_name(&dpio_dev->dev),
> &dpio_dev->dev);
> - if (error < 0) {
> - dev_err(&dpio_dev->dev,
> - "devm_request_irq() failed: %d\n",
> - error);
> + if (error < 0)
> return error;
> - }
>
> /* set the affinity hint */
> if (irq_set_affinity_hint(irq->virq, cpumask_of(cpu)))
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: fsl: dpio: Remove redundant dev_err()
2026-07-27 9:47 ` Christophe Leroy (CS GROUP)
@ 2026-07-27 9:55 ` Ioana Ciornei
0 siblings, 0 replies; 4+ messages in thread
From: Ioana Ciornei @ 2026-07-27 9:55 UTC (permalink / raw)
To: Christophe Leroy (CS GROUP)
Cc: Pan Chuang, Roy Pledge, open list:FREESCALE SOC DRIVERS,
open list:DPAA2 DATAPATH I/O (DPIO) DRIVER,
moderated list:FREESCALE SOC DRIVERS
On Mon, Jul 27, 2026 at 11:47:02AM +0200, Christophe Leroy (CS GROUP) wrote:
> Hi Ioana,
>
> Le 23/07/2026 à 04:47, Pan Chuang a écrit :
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> >
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
>
> I plan to take this patch for v7.3, do you agree with this change ?
Yes, you can take it.
Acked-by: Ioana Ciornei <ioana.ciornei@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: fsl: dpio: Remove redundant dev_err()
2026-07-23 2:47 [PATCH] soc: fsl: dpio: Remove redundant dev_err() Pan Chuang
2026-07-27 9:47 ` Christophe Leroy (CS GROUP)
@ 2026-07-27 10:18 ` Christophe Leroy (CS GROUP)
1 sibling, 0 replies; 4+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-07-27 10:18 UTC (permalink / raw)
To: Roy Pledge, linux-kernel, linuxppc-dev, linux-arm-kernel,
Pan Chuang
Cc: Christophe Leroy
On Thu, 23 Jul 2026 10:47:48 +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
>
Applied, thanks!
[1/1] soc: fsl: dpio: Remove redundant dev_err()
commit: 863a06885322bb1c0f43fe93faf13ad3e34b3f90
Best regards,
--
Christophe Leroy (CS GROUP) <chleroy@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-27 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 2:47 [PATCH] soc: fsl: dpio: Remove redundant dev_err() Pan Chuang
2026-07-27 9:47 ` Christophe Leroy (CS GROUP)
2026-07-27 9:55 ` Ioana Ciornei
2026-07-27 10:18 ` Christophe Leroy (CS GROUP)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox