public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree
@ 2016-01-31 21:05 Robert Jarzmik
  2016-02-06 21:46 ` Robert Jarzmik
  0 siblings, 1 reply; 2+ messages in thread
From: Robert Jarzmik @ 2016-01-31 21:05 UTC (permalink / raw)
  To: linux-arm-kernel

The initialization of interrupt controller for devicetree platform was
done for pxa2xx platforms, but not for pxa3xx ones.

Fix this my adding the missing initialization call.

Fixes: 089d03629b04 ("ARM: pxa: add devicetree code for irq handling")
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 arch/arm/mach-pxa/pxa-dt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-pxa/pxa-dt.c b/arch/arm/mach-pxa/pxa-dt.c
index bed3fa741f54..f128133a8f30 100644
--- a/arch/arm/mach-pxa/pxa-dt.c
+++ b/arch/arm/mach-pxa/pxa-dt.c
@@ -28,6 +28,7 @@ static const char *const pxa3xx_dt_board_compat[] __initconst = {
 
 DT_MACHINE_START(PXA_DT, "Marvell PXA3xx (Device Tree Support)")
 	.map_io		= pxa3xx_map_io,
+	.init_irq	= pxa3xx_dt_init_irq,
 	.handle_irq	= pxa3xx_handle_irq,
 	.restart	= pxa_restart,
 	.dt_compat	= pxa3xx_dt_board_compat,
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree
  2016-01-31 21:05 [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree Robert Jarzmik
@ 2016-02-06 21:46 ` Robert Jarzmik
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2016-02-06 21:46 UTC (permalink / raw)
  To: linux-arm-kernel

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> The initialization of interrupt controller for devicetree platform was
> done for pxa2xx platforms, but not for pxa3xx ones.
>
> Fix this my adding the missing initialization call.
>
> Fixes: 089d03629b04 ("ARM: pxa: add devicetree code for irq handling")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
No, this is incorrect.

The reason behind is that it relies on a patch not yet upstreamed, which was
breaking exactly this init_irq.

Let's drop this and replace it with the good patch.

Cheers.

--
Robert

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-06 21:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-31 21:05 [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree Robert Jarzmik
2016-02-06 21:46 ` Robert Jarzmik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox