Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: arm64: Fix order of arguments to ktime_get_snapshot_id()
@ 2026-06-04  9:27 Uwe Kleine-König
  2026-06-04  9:49 ` Thomas Gleixner
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2026-06-04  9:27 UTC (permalink / raw)
  To: Marc Zyngier, Oliver Upton, Thomas Gleixner
  Cc: Joey Gouly, Steffen Eiden, Suzuki K Poulose, Zenghui Yu,
	Catalin Marinas, Will Deacon, Jacob Keller, David Woodhouse,
	Vincent Donnefort, linux-arm-kernel, kvmarm, linux-kernel

The first argument to ktime_get_snapshot_id() is the clock ID and the
second output parameter. Fix the caller that reversed the order and thus
fix a compiler error.

Fixes: d09439210441 ("KVM: arm64: Use ktime_get_snapshot_id() to retrieve CLOCK_BOOTTIME")
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
---
 arch/arm64/kvm/hyp_trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c
index 8574db7491bc..2411b4c32932 100644
--- a/arch/arm64/kvm/hyp_trace.c
+++ b/arch/arm64/kvm/hyp_trace.c
@@ -118,7 +118,7 @@ static void hyp_trace_clock_enable(struct hyp_trace_clock *hyp_clock, bool enabl
 		hyp_clock->running = false;
 	}
 
-	ktime_get_snapshot_id(&snap, CLOCK_BOOTTIME);
+	ktime_get_snapshot_id(CLOCK_BOOTTIME, &snap);
 
 	hyp_clock->boot = ktime_to_ns(snap.systime);
 	hyp_clock->cycles = snap.cycles;

base-commit: d09439210441efbadd8b0aa32c1ddb1eab2f3abd
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] KVM: arm64: Fix order of arguments to ktime_get_snapshot_id()
  2026-06-04  9:27 [PATCH] KVM: arm64: Fix order of arguments to ktime_get_snapshot_id() Uwe Kleine-König
@ 2026-06-04  9:49 ` Thomas Gleixner
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2026-06-04  9:49 UTC (permalink / raw)
  To: Uwe Kleine-König, Marc Zyngier, Oliver Upton
  Cc: Joey Gouly, Steffen Eiden, Suzuki K Poulose, Zenghui Yu,
	Catalin Marinas, Will Deacon, Jacob Keller, David Woodhouse,
	Vincent Donnefort, linux-arm-kernel, kvmarm, linux-kernel

On Thu, Jun 04 2026 at 11:27, Uwe Kleine-König wrote:
> The first argument to ktime_get_snapshot_id() is the clock ID and the
> second output parameter. Fix the caller that reversed the order and thus
> fix a compiler error.

I've already squashed a fix earlier today


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-04  9:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-04  9:27 [PATCH] KVM: arm64: Fix order of arguments to ktime_get_snapshot_id() Uwe Kleine-König
2026-06-04  9:49 ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox