* [PATCH] arm64: dts: marvell: Disable AP I2C on Armada-8040-DB
@ 2019-05-21 14:37 Miquel Raynal
2019-06-03 14:43 ` Gregory CLEMENT
0 siblings, 1 reply; 2+ messages in thread
From: Miquel Raynal @ 2019-05-21 14:37 UTC (permalink / raw)
To: Gregory Clement, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
Rob Herring, Mark Rutland, devicetree
Cc: Antoine Tenart, Maxime Chevallier, Nadav Haklai, Thomas Petazzoni,
Miquel Raynal, Konstantin Porotchkin, linux-arm-kernel
From: Konstantin Porotchkin <kostap@marvell.com>
While AP I2C bus was available to users in early revisions of the SoC,
this is not the case anymore since eMMC was connected to the AP. Most
users do not have access to this I2C bus so do not enable it in the
board device tree.
As there are three I2C buses enabled on this board, add an alias to be
sure the two other buses keep their initial numbering.
Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
[<miquel.raynal@bootlin.com>: Reword commit message, add alias]
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
arch/arm64/boot/dts/marvell/armada-8040-db.dts | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
index 9f4f939ab65f..d6e9c014c2f9 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
@@ -27,6 +27,8 @@
ethernet1 = &cp0_eth2;
ethernet2 = &cp1_eth0;
ethernet3 = &cp1_eth1;
+ i2c1 = &cp0_i2c0;
+ i2c2 = &cp1_i2c0;
};
cp0_reg_usb3_0_vbus: cp0-usb3-0-vbus {
@@ -72,11 +74,6 @@
};
};
-&i2c0 {
- status = "okay";
- clock-frequency = <100000>;
-};
-
&spi0 {
status = "okay";
--
2.19.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: marvell: Disable AP I2C on Armada-8040-DB
2019-05-21 14:37 [PATCH] arm64: dts: marvell: Disable AP I2C on Armada-8040-DB Miquel Raynal
@ 2019-06-03 14:43 ` Gregory CLEMENT
0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2019-06-03 14:43 UTC (permalink / raw)
To: Miquel Raynal, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
Rob Herring, Mark Rutland, devicetree
Cc: Antoine Tenart, Maxime Chevallier, Nadav Haklai, Thomas Petazzoni,
Miquel Raynal, Konstantin Porotchkin, linux-arm-kernel
Hi Miquel,
> From: Konstantin Porotchkin <kostap@marvell.com>
>
> While AP I2C bus was available to users in early revisions of the SoC,
> this is not the case anymore since eMMC was connected to the AP. Most
> users do not have access to this I2C bus so do not enable it in the
> board device tree.
>
> As there are three I2C buses enabled on this board, add an alias to be
> sure the two other buses keep their initial numbering.
>
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
> [<miquel.raynal@bootlin.com>: Reword commit message, add alias]
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-8040-db.dts | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> index 9f4f939ab65f..d6e9c014c2f9 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> @@ -27,6 +27,8 @@
> ethernet1 = &cp0_eth2;
> ethernet2 = &cp1_eth0;
> ethernet3 = &cp1_eth1;
> + i2c1 = &cp0_i2c0;
> + i2c2 = &cp1_i2c0;
> };
>
> cp0_reg_usb3_0_vbus: cp0-usb3-0-vbus {
> @@ -72,11 +74,6 @@
> };
> };
>
> -&i2c0 {
> - status = "okay";
> - clock-frequency = <100000>;
> -};
> -
> &spi0 {
> status = "okay";
>
> --
> 2.19.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-03 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-21 14:37 [PATCH] arm64: dts: marvell: Disable AP I2C on Armada-8040-DB Miquel Raynal
2019-06-03 14:43 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox