From: Thomas Gleixner <tglx@linutronix.de>
To: Marek Vasut <marex@denx.de>, linux-arm-kernel@lists.infradead.org
Cc: Marek Vasut <marex@denx.de>, Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH] [RFC] genirq: Check irq_data_get_irq_chip() return value before use
Date: Thu, 07 May 2020 19:30:05 +0200 [thread overview]
Message-ID: <87r1vvejqa.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200507150729.244468-1-marex@denx.de>
Marek Vasut <marex@denx.de> writes:
> The irq_data_get_irq_chip() can return NULL. If the kernel accesses
> chip->irq_get_irqchip_state without checking whether chip is valid,
> we get a crash. Fix this by checking whether chip is not NULL before
> using it.
>
> Fixes: 1b7047edfcfb ("genirq: Allow the irqchip state of an IRQ to be save/restored")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> NOTE: I don't know whether this is a correct fix. Maybe the
> irq_data_get_irq_chip() should never return NULL, and
> I have some other issue?
What's the callchain?
Thanks,
tglx
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-07 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 15:07 [PATCH] [RFC] genirq: Check irq_data_get_irq_chip() return value before use Marek Vasut
2020-05-07 17:30 ` Thomas Gleixner [this message]
2020-05-07 18:29 ` Marek Vasut
2020-05-07 21:51 ` Thomas Gleixner
2020-05-10 14:49 ` Marek Vasut
2020-05-13 20:49 ` Thomas Gleixner
2020-05-14 0:26 ` Marek Vasut
2020-05-14 12:16 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1vvejqa.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=marex@denx.de \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox