From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH 3/3] ARM: dts: stm32: add STM32MP1-based Phytec board
Date: Fri, 29 Apr 2022 07:45:02 +0200 [thread overview]
Message-ID: <87sfpwwi8y.fsf@pengutronix.de> (raw)
In-Reply-To: <625d4510-e390-49d0-e6b8-2456d22b4c00@foss.st.com>
Alexandre TORGUE <alexandre.torgue@foss.st.com> writes:
> [1. text/plain]
> On 4/14/22 12:07, Steffen Trumtrar wrote:
>> The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB eMMC,
>> up to 16 MB QSPI and up to 128 GB NAND flash.
>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> ---
>> arch/arm/boot/dts/Makefile | 3 +-
>> .../dts/stm32mp157-phyboard-stm32mp1.dtsi | 283 +++++++++++++
>> .../dts/stm32mp157c-phycore-stm32mp1-3.dts | 57 +++
>> ...stm32mp157c-phycore-stm32mp15-pinctrl.dtsi | 318 +++++++++++++++
>> .../stm32mp157c-phycore-stm32mp15-som.dtsi | 373 ++++++++++++++++++
>> 5 files changed, 1033 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/boot/dts/stm32mp157-phyboard-stm32mp1.dtsi
>> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
>> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
>> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi
>
> Can you split a bit those patches please ?
>
I can split it into the SOM and the board part.
(...)
>> diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
>
>
> Why create a new file pinctrl file for your board ? All groups are differents
> than existing ones ?
>
Exactly. Those groups overwrite the existing ones.
I could put them directly into
arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi, if you think
it aids readability.
Best regards,
Steffen
--
Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-29 5:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 10:06 [PATCH 1/3] ARM: dts: stm32: add SRAM binding Steffen Trumtrar
2022-04-14 10:06 ` [PATCH 2/3] ARM: dts: stm32: add stm32mp1 pwr voltage regulator Steffen Trumtrar
2022-04-19 16:25 ` Alexandre TORGUE
2022-04-29 5:32 ` Steffen Trumtrar
2022-04-14 10:07 ` [PATCH 3/3] ARM: dts: stm32: add STM32MP1-based Phytec board Steffen Trumtrar
2022-04-19 16:29 ` Alexandre TORGUE
2022-04-29 5:45 ` Steffen Trumtrar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfpwwi8y.fsf@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox