* [PATCH v2 1/2] usb: gadget: pxa27x: Remove duplicate function prototype
[not found] <cover.1487901100.git.petr.cvek@tul.cz>
@ 2017-02-24 1:54 ` Petr Cvek
2017-02-25 12:21 ` Robert Jarzmik
2017-02-24 1:54 ` [PATCH v2 2/2] usb: gadget: pxa27x: Test for a valid argument pointer Petr Cvek
1 sibling, 1 reply; 4+ messages in thread
From: Petr Cvek @ 2017-02-24 1:54 UTC (permalink / raw)
To: linux-arm-kernel
Functions udc_enable() and udc_disable() have a duplicated prototype.
Remove it.
Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
---
drivers/usb/gadget/udc/pxa27x_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index e1335ad5bce9..821bd8f4cae6 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -1608,9 +1608,6 @@ static int pxa_udc_pullup(struct usb_gadget *_gadget, int is_active)
return 0;
}
-static void udc_enable(struct pxa_udc *udc);
-static void udc_disable(struct pxa_udc *udc);
-
/**
* pxa_udc_vbus_session - Called by external transceiver to enable/disable udc
* @_gadget: usb gadget
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2 2/2] usb: gadget: pxa27x: Test for a valid argument pointer
[not found] <cover.1487901100.git.petr.cvek@tul.cz>
2017-02-24 1:54 ` [PATCH v2 1/2] usb: gadget: pxa27x: Remove duplicate function prototype Petr Cvek
@ 2017-02-24 1:54 ` Petr Cvek
2017-02-25 12:24 ` Robert Jarzmik
1 sibling, 1 reply; 4+ messages in thread
From: Petr Cvek @ 2017-02-24 1:54 UTC (permalink / raw)
To: linux-arm-kernel
A call usb_put_phy(udc->transceiver) must be tested for a valid pointer.
Use an already existing test for usb_unregister_notifier call.
Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
---
drivers/usb/gadget/udc/pxa27x_udc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index 821bd8f4cae6..d48e239660c3 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -2531,9 +2531,10 @@ static int pxa_udc_remove(struct platform_device *_dev)
usb_del_gadget_udc(&udc->gadget);
pxa_cleanup_debugfs(udc);
- if (!IS_ERR_OR_NULL(udc->transceiver))
+ if (!IS_ERR_OR_NULL(udc->transceiver)) {
usb_unregister_notifier(udc->transceiver, &pxa27x_udc_phy);
- usb_put_phy(udc->transceiver);
+ usb_put_phy(udc->transceiver);
+ }
udc->transceiver = NULL;
the_controller = NULL;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-25 12:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1487901100.git.petr.cvek@tul.cz>
2017-02-24 1:54 ` [PATCH v2 1/2] usb: gadget: pxa27x: Remove duplicate function prototype Petr Cvek
2017-02-25 12:21 ` Robert Jarzmik
2017-02-24 1:54 ` [PATCH v2 2/2] usb: gadget: pxa27x: Test for a valid argument pointer Petr Cvek
2017-02-25 12:24 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox