[PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig

[PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig

[Arnd Bergmann]

The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
and conflicts with all the new-style AC97 drivers after the conversion,
so the drivers we want all get turned off.

Not disabling the symbol however does the right thing, and we get
the drivers that are selectively enabled here.

Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/pxa_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig
index 6bb506edb1f5..7f0f1fda2584 100644
--- a/arch/arm/configs/pxa_defconfig
+++ b/arch/arm/configs/pxa_defconfig
@@ -482,7 +482,6 @@ CONFIG_SND_PCM_OSS=m
 CONFIG_SND_DYNAMIC_MINORS=y
 CONFIG_SND_VERBOSE_PRINTK=y
 CONFIG_SND_DEBUG=y
-CONFIG_SND_PXA2XX_AC97=m
 CONFIG_SND_USB_AUDIO=m
 CONFIG_SND_SOC=m
 CONFIG_SND_ATMEL_SOC=m
-- 
2.20.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig

[Robert Jarzmik]

Arnd Bergmann <arnd@arndb.de> writes:

> The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
> and conflicts with all the new-style AC97 drivers after the conversion,
> so the drivers we want all get turned off.
>
> Not disabling the symbol however does the right thing, and we get
> the drivers that are selectively enabled here.
>
> Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Yes, most certainly.

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig

[Arnd Bergmann]

On Wed, Feb 27, 2019 at 11:01 PM Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
> > and conflicts with all the new-style AC97 drivers after the conversion,
> > so the drivers we want all get turned off.
> >
> > Not disabling the symbol however does the right thing, and we get
> > the drivers that are selectively enabled here.
> >
> > Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Yes, most certainly.
>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Applied to arm/defconfig for 5.1 now, thanks for taking a look

    Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel