From: yalin.wang2010@gmail.com (yalin wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] arm64:change jump_label to use branch instruction, not use NOP instr
Date: Fri, 31 Jul 2015 17:25:02 +0800 [thread overview]
Message-ID: <8F6A71B0-C7DB-4505-BEE2-79967FC91A8F@gmail.com> (raw)
In-Reply-To: <20150731075259.GR25159@twins.programming.kicks-ass.net>
> On Jul 31, 2015, at 15:52, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, Jul 31, 2015 at 03:41:37PM +0800, yalin wang wrote:
>> This change a little arch_static_branch(), use b . + 4 for false
>> return, why? According to aarch64 TRM, if both source and dest
>> instr are branch instr, can patch the instr directly, don't need
>> all cpu to do ISB for sync, this means we can call
>> aarch64_insn_patch_text_nosync() during patch_text(),
>> will improve the performance when change a static_key.
>
> This doesn't parse.. What?
>
> Also, this conflicts with the jump label patches I've got.
this is arch depend , you can see aarch64_insn_patch_text( ) for more info,
if aarch64_insn_hotpatch_safe() is true, will patch the text directly.
what is your git branch base? i make the patch based on linux-next branch,
maybe a little delay than yours , could you share your branch git address?
i can make a new based on yours .
Thanks
next prev parent reply other threads:[~2015-07-31 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 7:41 [RFC] arm64:change jump_label to use branch instruction, not use NOP instr yalin wang
2015-07-31 7:52 ` Peter Zijlstra
2015-07-31 9:25 ` yalin wang [this message]
2015-07-31 9:33 ` Peter Zijlstra
2015-07-31 10:14 ` Will Deacon
2015-08-01 10:00 ` yalin wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F6A71B0-C7DB-4505-BEE2-79967FC91A8F@gmail.com \
--to=yalin.wang2010@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox