[PATCH 0/2] Update MT8188 OVL compatible from MT8183 to MT8195

[PATCH 0/2] Update MT8188 OVL compatible from MT8183 to MT8195

[Jason-JH.Lin]

This patch series updates the compatible strings for the MediaTek OVL
in the MT8188 dts and the corresponding dt-binding.
The changes ensure that the MT8188 OVL device is correctly identified
and managed by the appropriate drivers.

The first patch is resending the reviewed and acked patch from:
- https://lore.kernel.org/all/5d9e6f6c-604d-4e2d-a448-fc5b8bd24a75@collabora.com/
and rebase it to the latest linux-next-20241212.

The second patch is updating the mt8188.dtsi according to the first patch.

Hsiao Chien Sung (1):
  dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

Jason-JH.Lin (1):
  dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to
    MT8195

 .../bindings/display/mediatek/mediatek,ovl.yaml           | 8 +++-----
 arch/arm64/boot/dts/mediatek/mt8188.dtsi                  | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

-- 
2.43.0

[PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

[Jason-JH.Lin]

From: Hsiao Chien Sung <shawn.sung@mediatek.com>

Modify rules for both MT8195 and MT8188.
Hardware capabilities include color formats and AFBC are
changed since MT8195, stop using the settings of MT8183.

Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 .../bindings/display/mediatek/mediatek,ovl.yaml           | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
index 9ea796a033b2..0ace12bbb623 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
@@ -36,16 +36,14 @@ properties:
           - enum:
               - mediatek,mt6795-disp-ovl
           - const: mediatek,mt8173-disp-ovl
-      - items:
-          - enum:
-              - mediatek,mt8188-disp-ovl
-              - mediatek,mt8195-disp-ovl
-          - const: mediatek,mt8183-disp-ovl
       - items:
           - enum:
               - mediatek,mt8186-disp-ovl
               - mediatek,mt8365-disp-ovl
           - const: mediatek,mt8192-disp-ovl
+      - items:
+          - const: mediatek,mt8188-disp-ovl
+          - const: mediatek,mt8195-disp-ovl
 
   reg:
     maxItems: 1
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

[CK Hu (胡俊光)]

Hi, Jason:

On Thu, 2024-12-12 at 23:33 +0800, Jason-JH.Lin wrote:
> From: Hsiao Chien Sung <shawn.sung@mediatek.com>
> 
> Modify rules for both MT8195 and MT8188.
> Hardware capabilities include color formats and AFBC are
> changed since MT8195, stop using the settings of MT8183.

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> 
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
>  .../bindings/display/mediatek/mediatek,ovl.yaml           | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index 9ea796a033b2..0ace12bbb623 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -36,16 +36,14 @@ properties:
>            - enum:
>                - mediatek,mt6795-disp-ovl
>            - const: mediatek,mt8173-disp-ovl
> -      - items:
> -          - enum:
> -              - mediatek,mt8188-disp-ovl
> -              - mediatek,mt8195-disp-ovl
> -          - const: mediatek,mt8183-disp-ovl
>        - items:
>            - enum:
>                - mediatek,mt8186-disp-ovl
>                - mediatek,mt8365-disp-ovl
>            - const: mediatek,mt8192-disp-ovl
> +      - items:
> +          - const: mediatek,mt8188-disp-ovl
> +          - const: mediatek,mt8195-disp-ovl
>  
>    reg:
>      maxItems: 1

Re: [PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

[Pin-yen Lin]

Hi Jason,

On Thu, Dec 12, 2024 at 11:33 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>
> From: Hsiao Chien Sung <shawn.sung@mediatek.com>
>
> Modify rules for both MT8195 and MT8188.
> Hardware capabilities include color formats and AFBC are
> changed since MT8195, stop using the settings of MT8183.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> ---
>  .../bindings/display/mediatek/mediatek,ovl.yaml           | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index 9ea796a033b2..0ace12bbb623 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -36,16 +36,14 @@ properties:
>            - enum:
>                - mediatek,mt6795-disp-ovl
>            - const: mediatek,mt8173-disp-ovl
> -      - items:
> -          - enum:
> -              - mediatek,mt8188-disp-ovl
> -              - mediatek,mt8195-disp-ovl
> -          - const: mediatek,mt8183-disp-ovl

This breaks the schema check for mt8195.dtsi, which is currently using
`compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl";`

IIUC this is supposed to be a RESEND of [1], which actually added a
binding for "mediatek,mt8195-disp-ovl". However [1] still breaks
mt8195.dtsi because it only allows `compatible =
"mediatek,mt8195-disp-ovl"` But not `compatible =
"mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl"`.

If "mediatek,mt8183-disp-ovl" is a reasonable fallback for
"mediatek,mt8195-disp-ovl", please keep a binding like:

      - items:
          - const: mediatek,mt8195-disp-ovl
          - const: mediatek,mt8183-disp-ovl

Or, fix mt8195.dtsi instead in the same series.

[1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20231212121957.19231-4-shawn.sung@mediatek.com/
>        - items:
>            - enum:
>                - mediatek,mt8186-disp-ovl
>                - mediatek,mt8365-disp-ovl
>            - const: mediatek,mt8192-disp-ovl
> +      - items:
> +          - const: mediatek,mt8188-disp-ovl
> +          - const: mediatek,mt8195-disp-ovl
>
>    reg:
>      maxItems: 1

Regards,
Pin-yen

Re: [PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

[Jason-JH Lin (林睿祥)]

Hi Pin-yen,

Thanks for the reviews.

On Fri, 2024-12-13 at 11:41 +0800, Pin-yen Lin wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Hi Jason,
> 
> On Thu, Dec 12, 2024 at 11:33 PM Jason-JH.Lin <
> jason-jh.lin@mediatek.com> wrote:
> > 
> > From: Hsiao Chien Sung <shawn.sung@mediatek.com>
> > 
> > Modify rules for both MT8195 and MT8188.
> > Hardware capabilities include color formats and AFBC are
> > changed since MT8195, stop using the settings of MT8183.
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
> > ---
> >  .../bindings/display/mediatek/mediatek,ovl.yaml           | 8 +++-
> > ----
> >  1 file changed, 3 insertions(+), 5 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > index 9ea796a033b2..0ace12bbb623 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > @@ -36,16 +36,14 @@ properties:
> >            - enum:
> >                - mediatek,mt6795-disp-ovl
> >            - const: mediatek,mt8173-disp-ovl
> > -      - items:
> > -          - enum:
> > -              - mediatek,mt8188-disp-ovl
> > -              - mediatek,mt8195-disp-ovl
> > -          - const: mediatek,mt8183-disp-ovl
> 
> This breaks the schema check for mt8195.dtsi, which is currently
> using
> `compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-
> ovl";`
> 
> IIUC this is supposed to be a RESEND of [1], which actually added a
> binding for "mediatek,mt8195-disp-ovl". However [1] still breaks
> mt8195.dtsi because it only allows `compatible =
> "mediatek,mt8195-disp-ovl"` But not `compatible =
> "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl"`.
> 

Yes, I lost the "mediatek,mt8195-disp-ovl" in [1] at the beginning of
compatible property.
I'll add it to the next version.

> If "mediatek,mt8183-disp-ovl" is a reasonable fallback for
> "mediatek,mt8195-disp-ovl", please keep a binding like:
> 
>       - items:
>           - const: mediatek,mt8195-disp-ovl
>           - const: mediatek,mt8183-disp-ovl
> 
> Or, fix mt8195.dtsi instead in the same series.

Yes, I think the OVL in mt8195.dtsi should remove the "mediatek,mt8183-
disp-ovl" because it's not compatible anymore.

I'll add that path in the same series.

Regards,
Jason-JH.Lin

[PATCH 2/2] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

[Jason-JH.Lin]

The OVL hardware capabilities have changed starting from MT8195,
making the MT8183 compatible no longer applicable.
Therefore, it is necessary to update the OVL compatible from MT8183 to
MT8195.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
index faccc7f16259..23ec3ff6cad9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
@@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@1a040000 {
 		};
 
 		ovl0: ovl@1c000000 {
-			compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8183-disp-ovl";
+			compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8195-disp-ovl";
 			reg = <0 0x1c000000 0 0x1000>;
 			clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
 			interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
-- 
2.43.0

Re: [PATCH 2/2] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

[AngeloGioacchino Del Regno]

Il 12/12/24 16:33, Jason-JH.Lin ha scritto:
> The OVL hardware capabilities have changed starting from MT8195,
> making the MT8183 compatible no longer applicable.
> Therefore, it is necessary to update the OVL compatible from MT8183 to
> MT8195.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>

Jason, just so you know - I have patches here adding DSC and merge components of
VDO0, other than all MDP3 components.

Those are almost ready to send, I only need to finish some testing before ;-)

For this one, anyway:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


> ---
>   arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index faccc7f16259..23ec3ff6cad9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@1a040000 {
>   		};
>   
>   		ovl0: ovl@1c000000 {
> -			compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8183-disp-ovl";
> +			compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8195-disp-ovl";
>   			reg = <0 0x1c000000 0 0x1000>;
>   			clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
>   			interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;

Re: [PATCH 2/2] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

[Jason-JH Lin (林睿祥)]

On Thu, 2024-12-12 at 17:05 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 12/12/24 16:33, Jason-JH.Lin ha scritto:
> > The OVL hardware capabilities have changed starting from MT8195,
> > making the MT8183 compatible no longer applicable.
> > Therefore, it is necessary to update the OVL compatible from MT8183
> > to
> > MT8195.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> 
> Jason, just so you know - I have patches here adding DSC and merge
> components of
> VDO0, other than all MDP3 components.
> 
> Those are almost ready to send, I only need to finish some testing
> before ;-)
> 
> For this one, anyway:
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> 
> 

Hi Angelo,

Thanks for the notification and review.
It's okay for me to rebase on your patches.

Just let me know if I need to adjust this patch after you sending it.

Regards,
Jason-JH.Lin

> > ---
> >   arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > index faccc7f16259..23ec3ff6cad9 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > @@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@1a040000 {
> >               };
> > 
> >               ovl0: ovl@1c000000 {
> > -                     compatible = "mediatek,mt8188-disp-ovl",
> > "mediatek,mt8183-disp-ovl";
> > +                     compatible = "mediatek,mt8188-disp-ovl",
> > "mediatek,mt8195-disp-ovl";
> >                       reg = <0 0x1c000000 0 0x1000>;
> >                       clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
> >                       interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> 
> 

Re: [PATCH 2/2] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

[Jason-JH Lin (林睿祥)]

On Thu, 2024-12-12 at 17:05 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 12/12/24 16:33, Jason-JH.Lin ha scritto:
> > The OVL hardware capabilities have changed starting from MT8195,
> > making the MT8183 compatible no longer applicable.
> > Therefore, it is necessary to update the OVL compatible from MT8183
> > to
> > MT8195.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> 
> Jason, just so you know - I have patches here adding DSC and merge
> components of
> VDO0, other than all MDP3 components.
> 
> Those are almost ready to send, I only need to finish some testing
> before ;-)
> 
> For this one, anyway:
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> 
> 
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > index faccc7f16259..23ec3ff6cad9 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> > @@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@1a040000 {
> >               };
> > 
> >               ovl0: ovl@1c000000 {
> > -                     compatible = "mediatek,mt8188-disp-ovl",
> > "mediatek,mt8183-disp-ovl";
> > +                     compatible = "mediatek,mt8188-disp-ovl",
> > "mediatek,mt8195-disp-ovl";
> >                       reg = <0 0x1c000000 0 0x1000>;
> >                       clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
> >                       interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> 
>