Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: Ben Horgan <ben.horgan@arm.com>
Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com,
	baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com,
	dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com,
	fenghuay@nvidia.com, james.morse@arm.com, jic23@kernel.org,
	kobak@nvidia.com, lcherian@marvell.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, peternewman@google.com,
	punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com,
	reinette.chatre@intel.com, rohit.mathew@arm.com,
	scott@os.amperecomputing.com, sdonthineni@nvidia.com,
	tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com,
	zengheng4@huawei.com, x86@kernel.org, leitao@kernel.org,
	kas@kernel.org, puranjay@kernel.org, usama.arif@linux.dev,
	kernel-team@meta.com
Subject: Re: [PATCH v5 0/5] arm_mpam: resctrl: Counter Assignment (ABMC)
Date: Wed, 15 Jul 2026 15:44:20 +1000	[thread overview]
Message-ID: <8e36f71d-598b-45bf-a3ea-6d44ff728877@redhat.com> (raw)
In-Reply-To: <20260707162440.12132-1-ben.horgan@arm.com>

On 7/8/26 2:24 AM, Ben Horgan wrote:
> Version 5 of this series addresses a few review comments but is pretty
> similar to v4. The precursors in x86/cache have been merged so there is no
> longer a need for this to go through there. It's likely easiest if this
> goes through arm64.
> 
> This series adds support for memory bandwidth monitoring. Counter assignment
> will be used for all platforms with memory bandwidth monitors rather than just
> those with insufficient counters as originally proposed.
> 
> rfc v1: https://lore.kernel.org/lkml/20260225205436.3571756-1-ben.horgan@arm.com/
> rfc v2: https://lore.kernel.org/lkml/20260319165540.381410-1-ben.horgan@arm.com/
> v3: https://lore.kernel.org/linux-arm-kernel/20260511154147.557481-1-ben.horgan@arm.com/
> v4: https://lore.kernel.org/lkml/20260520212458.1797221-1-ben.horgan@arm.com/
> 
> The code can be found at:
> https://gitlab.arm.com/linux-arm/linux-bh.git mpam_abmc_v5
> 
> Ben Horgan (2):
>    arm_mpam: resctrl: Pre-allocate assignable monitors
>    arm64: mpam: Add memory bandwidth usage (MBWU) documentation
> 
> James Morse (3):
>    arm_mpam: resctrl: Pick classes for use as MBM counters
>    arm_mpam: resctrl: Add resctrl_arch_config_cntr() for ABMC use
>    arm_mpam: resctrl: Add resctrl_arch_cntr_read() &
>      resctrl_arch_reset_cntr()
> 
>   Documentation/arch/arm64/mpam.rst |  22 +++
>   drivers/resctrl/mpam_internal.h   |   6 +-
>   drivers/resctrl/mpam_resctrl.c    | 318 +++++++++++++++++++++++++++---
>   3 files changed, 323 insertions(+), 23 deletions(-)
> 

The tests on NVidia's grace-hopper machine looks good: (a) no error or warning is seen
from the kunit-tests; (b) L3 cache partitioning and MBW (soft) limiting aren't broken,
still working to me; (c) The counter 'mbm_total_bytes' can be assigned to newly created
group and it gets increased when workload runs in the group.

Tested-by: Gavin Shan <gshan@redhat.com>

Thanks,
Gavin



      parent reply	other threads:[~2026-07-15  5:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 16:24 [PATCH v5 0/5] arm_mpam: resctrl: Counter Assignment (ABMC) Ben Horgan
2026-07-07 16:24 ` [PATCH v5 1/5] arm_mpam: resctrl: Pick classes for use as MBM counters Ben Horgan
2026-07-15 10:12   ` Gavin Shan
2026-07-07 16:24 ` [PATCH v5 2/5] arm_mpam: resctrl: Pre-allocate assignable monitors Ben Horgan
2026-07-15 10:22   ` Gavin Shan
2026-07-07 16:24 ` [PATCH v5 3/5] arm_mpam: resctrl: Add resctrl_arch_config_cntr() for ABMC use Ben Horgan
2026-07-15 10:22   ` Gavin Shan
2026-07-07 16:24 ` [PATCH v5 4/5] arm_mpam: resctrl: Add resctrl_arch_cntr_read() & resctrl_arch_reset_cntr() Ben Horgan
2026-07-15 10:23   ` Gavin Shan
2026-07-07 16:24 ` [PATCH v5 5/5] arm64: mpam: Add memory bandwidth usage (MBWU) documentation Ben Horgan
2026-07-09 16:43   ` Fenghua Yu
2026-07-15 10:23   ` Gavin Shan
2026-07-15  5:44 ` Gavin Shan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e36f71d-598b-45bf-a3ea-6d44ff728877@redhat.com \
    --to=gshan@redhat.com \
    --cc=amitsinght@marvell.com \
    --cc=baisheng.gao@unisoc.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=ben.horgan@arm.com \
    --cc=carl@os.amperecomputing.com \
    --cc=dave.martin@arm.com \
    --cc=david@kernel.org \
    --cc=dfustini@baylibre.com \
    --cc=fenghuay@nvidia.com \
    --cc=james.morse@arm.com \
    --cc=jic23@kernel.org \
    --cc=kas@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=kobak@nvidia.com \
    --cc=lcherian@marvell.com \
    --cc=leitao@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peternewman@google.com \
    --cc=punit.agrawal@oss.qualcomm.com \
    --cc=puranjay@kernel.org \
    --cc=quic_jiles@quicinc.com \
    --cc=reinette.chatre@intel.com \
    --cc=rohit.mathew@arm.com \
    --cc=scott@os.amperecomputing.com \
    --cc=sdonthineni@nvidia.com \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=usama.arif@linux.dev \
    --cc=x86@kernel.org \
    --cc=xhao@linux.alibaba.com \
    --cc=zengheng4@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox