[PATCH 1/4] arm64: dts: rockchip: Add Rockchip RK3588M

[PATCH 1/4] arm64: dts: rockchip: Add Rockchip RK3588M

[Jagan Teki]

Rockchip RK3588M is the automotive-grade version of RK3588 SoC and
is operated with -40 °C to +85 °C temparature.

Add rk3588m specific dtsi for adding rk3588m specific operating points
and other changes to be add in future.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi

diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
new file mode 100644
index 000000000000..0bbeee399a63
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2022 Rockchip Electronics Co., Ltd.
+ *
+ */
+
+#include "rk3588-extra.dtsi"
-- 
2.34.1

[PATCH 2/4] dt-bindings: arm: rockchip: Add Edgeble 6TOPS Automotive Edge AI CM

[Jagan Teki]

Edgeble Edge AI CM6C is an Edge AI Accelerator module based on Rockchip
RK3588M.

Edgeble Edge AI CM6 Industrial IO board is an evaluation board that
would compatible with Edge AI CM6.

Add bindings for it.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 753199a12923..709a13835c9b 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -132,6 +132,7 @@ properties:
           - enum:
               - edgeble,neural-compute-module-6a        # Edgeble Neural Compute Module 6A SoM
               - edgeble,neural-compute-module-6b        # Edgeble Neural Compute Module 6B SoM
+              - edgeble,neural-compute-module-6c        # Edgeble Neural Compute Module 6C SoM
           - const: rockchip,rk3588
 
       - description: Elgin RV1108 R1
-- 
2.34.1

Re: [PATCH 2/4] dt-bindings: arm: rockchip: Add Edgeble 6TOPS Automotive Edge AI CM

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

On Fri, Dec 27, 2024 at 07:04:18PM +0530, Jagan Teki wrote:
> Edgeble Edge AI CM6C is an Edge AI Accelerator module based on Rockchip
> RK3588M.
> 
> Edgeble Edge AI CM6 Industrial IO board is an evaluation board that
> would compatible with Edge AI CM6.
> 
> Add bindings for it.
> 
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 3/4] arm64: dts: rockchip: Add Edgeble 6TOPS Automotive Edge AI Compute Module

[Jagan Teki]

Edgeble Edge AI CM6C is an Automotive Edge AI Accelerator module based
on Rockchip RK3588M, operating with -40 °C to +85 °C temparature.

Add DTSI for it.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c.dtsi

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c.dtsi
new file mode 100644
index 000000000000..92049540c20a
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c.dtsi
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2022 Edgeble AI Technologies Pvt. Ltd.
+ */
+
+#include "rk3588-edgeble-neu6a-common.dtsi"
+
+/ {
+	compatible = "edgeble,neural-compute-module-6c", "rockchip,rk3588";
+};
-- 
2.34.1

[PATCH 4/4] arm64: dts: rockchip: Add Edgeble EAI CM6 Industrial IO for Automotive

[Jagan Teki]

Edgeble Edge AI CM6C is an Automotive Edge AI Accelerator module based
on Rockchip RK3588M, operating with -40 °C to +85 °C temparature.

Edgeble Edge AI CM6 Industrial IO board is an evaluation board that
would compatible with Edge AI CM6.

Add DTS for Edge AI CM6C with CM6 Industrial IO board for Automotive.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm64/boot/dts/rockchip/Makefile             |  1 +
 .../boot/dts/rockchip/rk3588-edgeble-neu6c-io.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c-io.dts

diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 86cc418a2255..6701b296f3e0 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -136,6 +136,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-coolpi-cm5-genbook.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtbo
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6b-io.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6c-io.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-friendlyelec-cm3588-nas.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-jaguar.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c-io.dts b/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c-io.dts
new file mode 100644
index 000000000000..1e484991d1a4
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6c-io.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2023 Edgeble AI Technologies Pvt. Ltd.
+ */
+
+/dts-v1/;
+#include "rk3588m.dtsi"
+#include "rk3588-edgeble-neu6c.dtsi"
+#include "rk3588-edgeble-neu6a-io.dtsi"
+
+/ {
+	model = "Edgeble Neu6C IO Board";
+	compatible = "edgeble,neural-compute-module-6a-io",
+		     "edgeble,neural-compute-module-6c", "rockchip,rk3588";
+};
-- 
2.34.1

Re: [PATCH 1/4] arm64: dts: rockchip: Add Rockchip RK3588M

[Dragan Simic]

Hello Jagan,

Please see a comment below.

On 2024-12-27 14:34, Jagan Teki wrote:
> Rockchip RK3588M is the automotive-grade version of RK3588 SoC and
> is operated with -40 °C to +85 °C temparature.
> 
> Add rk3588m specific dtsi for adding rk3588m specific operating points
> and other changes to be add in future.
> 
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> new file mode 100644
> index 000000000000..0bbeee399a63
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd.
> + *
> + */
> +
> +#include "rk3588-extra.dtsi"

I don't think we need or want a separate rk3588m.dtsi file for this
purpose, unless the RK3588M variant actually differs from the regular
RK3588 variant from the software standpoint.  The latter is already
described in rk3588.dtsi, so it should just be included in the new
board dts(i) file.

Re: [PATCH 1/4] arm64: dts: rockchip: Add Rockchip RK3588M

[Dragan Simic]

On 2024-12-27 14:48, Dragan Simic wrote:
> Hello Jagan,
> 
> Please see a comment below.
> 
> On 2024-12-27 14:34, Jagan Teki wrote:
>> Rockchip RK3588M is the automotive-grade version of RK3588 SoC and
>> is operated with -40 °C to +85 °C temparature.
>> 
>> Add rk3588m specific dtsi for adding rk3588m specific operating points
>> and other changes to be add in future.
>> 
>> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> new file mode 100644
>> index 000000000000..0bbeee399a63
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> @@ -0,0 +1,7 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd.
>> + *
>> + */
>> +
>> +#include "rk3588-extra.dtsi"
> 
> I don't think we need or want a separate rk3588m.dtsi file for this
> purpose, unless the RK3588M variant actually differs from the regular
> RK3588 variant from the software standpoint.  The latter is already
> described in rk3588.dtsi, so it should just be included in the new
> board dts(i) file.

Actually, after having a look at the downstream code, it seems that
the RK3588J and RK3588M variants share the same OPPs, so actually
rk3588j.dtsi should be used for the RK3588M variant.  Could you,
please, confirm this?

Alas, it seems we've got some serious issues in the OPPs currently
defined in rk3588j.dtsi, which I'll double check to make sure I'm not
going crazy, :) and submit a patch that fixes those OPPs.

If you could confirm the RK3588M == RK3588J assumption above, I can
add some additional clarification to the rk3588j.dtsi file in the
above-mentioned fixes.

Re: [PATCH 1/4] arm64: dts: rockchip: Add Rockchip RK3588M

[Jagan Teki]

On Fri, 27 Dec 2024 at 19:37, Dragan Simic <dsimic@manjaro.org> wrote:
>
> On 2024-12-27 14:48, Dragan Simic wrote:
> > Hello Jagan,
> >
> > Please see a comment below.
> >
> > On 2024-12-27 14:34, Jagan Teki wrote:
> >> Rockchip RK3588M is the automotive-grade version of RK3588 SoC and
> >> is operated with -40 °C to +85 °C temparature.
> >>
> >> Add rk3588m specific dtsi for adding rk3588m specific operating points
> >> and other changes to be add in future.
> >>
> >> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> >> ---
> >>  arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> >> b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> >> new file mode 100644
> >> index 000000000000..0bbeee399a63
> >> --- /dev/null
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
> >> @@ -0,0 +1,7 @@
> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> >> +/*
> >> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd.
> >> + *
> >> + */
> >> +
> >> +#include "rk3588-extra.dtsi"
> >
> > I don't think we need or want a separate rk3588m.dtsi file for this
> > purpose, unless the RK3588M variant actually differs from the regular
> > RK3588 variant from the software standpoint.  The latter is already
> > described in rk3588.dtsi, so it should just be included in the new
> > board dts(i) file.
>
> Actually, after having a look at the downstream code, it seems that
> the RK3588J and RK3588M variants share the same OPPs, so actually
> rk3588j.dtsi should be used for the RK3588M variant.  Could you,
> please, confirm this?
>
> Alas, it seems we've got some serious issues in the OPPs currently
> defined in rk3588j.dtsi, which I'll double check to make sure I'm not
> going crazy, :) and submit a patch that fixes those OPPs.
>
> If you could confirm the RK3588M == RK3588J assumption above, I can
> add some additional clarification to the rk3588j.dtsi file in the
> above-mentioned fixes.

As-far-as-i-know both OPPs were different due to computation grades J
for Industrial and M for Automotive. What I saw from downstream
linux-6.1-stan-rkr1 was a simple dtsi for M variant and might have
changes to add OPPs which I cannot be sure at this point of time. I
keep that dtsi as separate even though it is nothing as i was
expecting some future changes on OPPs or so.

Kever or Heiko can help here.

Thanks,
Jagan.

Re: [PATCH 1/4] arm64: dts: rockchip: Add Rockchip RK3588M

[Dragan Simic]

On 2024-12-27 15:13, Jagan Teki wrote:
> On Fri, 27 Dec 2024 at 19:37, Dragan Simic <dsimic@manjaro.org> wrote:
>> On 2024-12-27 14:48, Dragan Simic wrote:
>> > Please see a comment below.
>> >
>> > On 2024-12-27 14:34, Jagan Teki wrote:
>> >> Rockchip RK3588M is the automotive-grade version of RK3588 SoC and
>> >> is operated with -40 °C to +85 °C temparature.
>> >>
>> >> Add rk3588m specific dtsi for adding rk3588m specific operating points
>> >> and other changes to be add in future.
>> >>
>> >> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
>> >> ---
>> >>  arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++
>> >>  1 file changed, 7 insertions(+)
>> >>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> >>
>> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> >> b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> >> new file mode 100644
>> >> index 000000000000..0bbeee399a63
>> >> --- /dev/null
>> >> +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi
>> >> @@ -0,0 +1,7 @@
>> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> >> +/*
>> >> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd.
>> >> + *
>> >> + */
>> >> +
>> >> +#include "rk3588-extra.dtsi"
>> >
>> > I don't think we need or want a separate rk3588m.dtsi file for this
>> > purpose, unless the RK3588M variant actually differs from the regular
>> > RK3588 variant from the software standpoint.  The latter is already
>> > described in rk3588.dtsi, so it should just be included in the new
>> > board dts(i) file.
>> 
>> Actually, after having a look at the downstream code, it seems that
>> the RK3588J and RK3588M variants share the same OPPs, so actually
>> rk3588j.dtsi should be used for the RK3588M variant.  Could you,
>> please, confirm this?
>> 
>> Alas, it seems we've got some serious issues in the OPPs currently
>> defined in rk3588j.dtsi, which I'll double check to make sure I'm not
>> going crazy, :) and submit a patch that fixes those OPPs.
>> 
>> If you could confirm the RK3588M == RK3588J assumption above, I can
>> add some additional clarification to the rk3588j.dtsi file in the
>> above-mentioned fixes.
> 
> As-far-as-i-know both OPPs were different due to computation grades J
> for Industrial and M for Automotive. What I saw from downstream
> linux-6.1-stan-rkr1 was a simple dtsi for M variant and might have
> changes to add OPPs which I cannot be sure at this point of time. I
> keep that dtsi as separate even though it is nothing as i was
> expecting some future changes on OPPs or so.

After checking the downstream code again, [*] it seems to me that
the RK3588J and RK3588M variants share the same OPPs.  Furthermore,
if the OPPs for the RK3588M variant cannot be defined accurately
at the moment, I'd suggest that the placeholder .dtsi is avoided
and that a complete per-variant .dtsi is added later, when the OPPs
are actually determined and defined.

Regarding the assumed issues with the current OPPs in rk3588j.dtsi,
it's all about the IPA complaining about the same-voltage, lower-
frequency OPPs being inefficient, which I already argued against.
I remain committed to proving that to be inaccurate, but until that
materializes, the current OPPs are there to stay.

[*] 
https://raw.githubusercontent.com/rockchip-linux/kernel/604cec4004abe5a96c734f2fab7b74809d2d742f/arch/arm64/boot/dts/rockchip/rk3588s.dtsi