* [RFC] arm64: ioremap: add ioremap_cache macro
@ 2015-10-12 2:28 yalin wang
2015-10-13 14:10 ` Catalin Marinas
0 siblings, 1 reply; 8+ messages in thread
From: yalin wang @ 2015-10-12 2:28 UTC (permalink / raw)
To: linux-arm-kernel
Add ioremap_cache macro, because some code will test if this macro
is defined or not, and will generate a generric version if not defined,
for example, memremap.c do like this.
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
arch/arm64/include/asm/io.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
index 44be1e0..d6b620c 100644
--- a/arch/arm64/include/asm/io.h
+++ b/arch/arm64/include/asm/io.h
@@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
#define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
#define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
#define iounmap __iounmap
+#define ioremap_cache ioremap_cache
/*
* io{read,write}{16,32}be() macros
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [RFC] arm64: ioremap: add ioremap_cache macro
2015-10-12 2:28 [RFC] arm64: ioremap: add ioremap_cache macro yalin wang
@ 2015-10-13 14:10 ` Catalin Marinas
2015-10-13 14:23 ` Will Deacon
2015-10-13 14:24 ` Arnd Bergmann
0 siblings, 2 replies; 8+ messages in thread
From: Catalin Marinas @ 2015-10-13 14:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> Add ioremap_cache macro, because some code will test if this macro
> is defined or not, and will generate a generric version if not defined,
> for example, memremap.c do like this.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> arch/arm64/include/asm/io.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> index 44be1e0..d6b620c 100644
> --- a/arch/arm64/include/asm/io.h
> +++ b/arch/arm64/include/asm/io.h
> @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
> #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
> #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
> #define iounmap __iounmap
> +#define ioremap_cache ioremap_cache
Applied. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC] arm64: ioremap: add ioremap_cache macro
2015-10-13 14:10 ` Catalin Marinas
@ 2015-10-13 14:23 ` Will Deacon
2015-10-13 15:20 ` Catalin Marinas
2015-10-13 14:24 ` Arnd Bergmann
1 sibling, 1 reply; 8+ messages in thread
From: Will Deacon @ 2015-10-13 14:23 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote:
> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> > Add ioremap_cache macro, because some code will test if this macro
> > is defined or not, and will generate a generric version if not defined,
> > for example, memremap.c do like this.
> >
> > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> > ---
> > arch/arm64/include/asm/io.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> > index 44be1e0..d6b620c 100644
> > --- a/arch/arm64/include/asm/io.h
> > +++ b/arch/arm64/include/asm/io.h
> > @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
> > #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
> > #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
> > #define iounmap __iounmap
> > +#define ioremap_cache ioremap_cache
>
> Applied. Thanks.
I'm not sure we want this. See:
https://lkml.org/lkml/2015/10/9/699
Will
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC] arm64: ioremap: add ioremap_cache macro
2015-10-13 14:23 ` Will Deacon
@ 2015-10-13 15:20 ` Catalin Marinas
2015-10-14 2:41 ` yalin wang
0 siblings, 1 reply; 8+ messages in thread
From: Catalin Marinas @ 2015-10-13 15:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 03:23:27PM +0100, Will Deacon wrote:
> On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote:
> > On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> > > Add ioremap_cache macro, because some code will test if this macro
> > > is defined or not, and will generate a generric version if not defined,
> > > for example, memremap.c do like this.
> > >
> > > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> > > ---
> > > arch/arm64/include/asm/io.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> > > index 44be1e0..d6b620c 100644
> > > --- a/arch/arm64/include/asm/io.h
> > > +++ b/arch/arm64/include/asm/io.h
> > > @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
> > > #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
> > > #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
> > > #define iounmap __iounmap
> > > +#define ioremap_cache ioremap_cache
> >
> > Applied. Thanks.
>
> I'm not sure we want this. See:
>
> https://lkml.org/lkml/2015/10/9/699
Thanks Will and Arnd, I missed this. Patch reverted.
--
Catalin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC] arm64: ioremap: add ioremap_cache macro
2015-10-13 15:20 ` Catalin Marinas
@ 2015-10-14 2:41 ` yalin wang
2015-10-14 8:23 ` Arnd Bergmann
0 siblings, 1 reply; 8+ messages in thread
From: yalin wang @ 2015-10-14 2:41 UTC (permalink / raw)
To: linux-arm-kernel
> On Oct 13, 2015, at 23:20, Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Tue, Oct 13, 2015 at 03:23:27PM +0100, Will Deacon wrote:
>> On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote:
>>> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
>>>> Add ioremap_cache macro, because some code will test if this macro
>>>> is defined or not, and will generate a generric version if not defined,
>>>> for example, memremap.c do like this.
>>>>
>>>> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
>>>> ---
>>>> arch/arm64/include/asm/io.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
>>>> index 44be1e0..d6b620c 100644
>>>> --- a/arch/arm64/include/asm/io.h
>>>> +++ b/arch/arm64/include/asm/io.h
>>>> @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
>>>> #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
>>>> #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
>>>> #define iounmap __iounmap
>>>> +#define ioremap_cache ioremap_cache
>>>
>>> Applied. Thanks.
>>
>> I'm not sure we want this. See:
>>
>> https://lkml.org/lkml/2015/10/9/699
>
> Thanks Will and Arnd, I missed this. Patch reverted.
>
i don?t understand why conflict with Dan Williams? patch.
Dan Williams ?s patch also define ioremap_cache for arch ia64 & arch sh & arch xtensa ,
i see this :
# git show 92281dee825f
am i miss something?
Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC] arm64: ioremap: add ioremap_cache macro
2015-10-14 2:41 ` yalin wang
@ 2015-10-14 8:23 ` Arnd Bergmann
2015-10-14 12:01 ` yalin wang
0 siblings, 1 reply; 8+ messages in thread
From: Arnd Bergmann @ 2015-10-14 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 14 October 2015 10:41:26 yalin wang wrote:
> > On Oct 13, 2015, at 23:20, Catalin Marinas <catalin.marinas@arm.com> wrote:
> >> I'm not sure we want this. See:
> >>
> >> https://lkml.org/lkml/2015/10/9/699
> >
> > Thanks Will and Arnd, I missed this. Patch reverted.
> >
> i don?t understand why conflict with Dan Williams? patch.
> Dan Williams ?s patch also define ioremap_cache for arch ia64 & arch sh & arch xtensa ,
> i see this :
> # git show 92281dee825f
> am i miss something?
I meant the new series, see https://lkml.org/lkml/2015/10/9/716 for the
patch that removes it again.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC] arm64: ioremap: add ioremap_cache macro
2015-10-14 8:23 ` Arnd Bergmann
@ 2015-10-14 12:01 ` yalin wang
0 siblings, 0 replies; 8+ messages in thread
From: yalin wang @ 2015-10-14 12:01 UTC (permalink / raw)
To: linux-arm-kernel
> On Oct 14, 2015, at 16:23, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Wednesday 14 October 2015 10:41:26 yalin wang wrote:
>
>>> On Oct 13, 2015, at 23:20, Catalin Marinas <catalin.marinas@arm.com> wrote:
>>>> I'm not sure we want this. See:
>>>>
>>>> https://lkml.org/lkml/2015/10/9/699
>>>
>>> Thanks Will and Arnd, I missed this. Patch reverted.
>>>
>> i don?t understand why conflict with Dan Williams? patch.
>> Dan Williams ?s patch also define ioremap_cache for arch ia64 & arch sh & arch xtensa ,
>> i see this :
>> # git show 92281dee825f
>> am i miss something?
>
> I meant the new series, see https://lkml.org/lkml/2015/10/9/716 for the
> patch that removes it again.
>
> Arnd
Got it ,
Thanks :)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC] arm64: ioremap: add ioremap_cache macro
2015-10-13 14:10 ` Catalin Marinas
2015-10-13 14:23 ` Will Deacon
@ 2015-10-13 14:24 ` Arnd Bergmann
1 sibling, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-10-13 14:24 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 13 October 2015 15:10:55 Catalin Marinas wrote:
> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> > Add ioremap_cache macro, because some code will test if this macro
> > is defined or not, and will generate a generric version if not defined,
> > for example, memremap.c do like this.
> >
> > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> > ---
> > arch/arm64/include/asm/io.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> > index 44be1e0..d6b620c 100644
> > --- a/arch/arm64/include/asm/io.h
> > +++ b/arch/arm64/include/asm/io.h
> > @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
> > #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
> > #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
> > #define iounmap __iounmap
> > +#define ioremap_cache ioremap_cache
>
> Applied. Thanks.
>
I think this will conflict with Dan Williams' series that removes
ioremap_cache from the kernel and replaces it with memremap.c
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-10-14 12:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 2:28 [RFC] arm64: ioremap: add ioremap_cache macro yalin wang
2015-10-13 14:10 ` Catalin Marinas
2015-10-13 14:23 ` Will Deacon
2015-10-13 15:20 ` Catalin Marinas
2015-10-14 2:41 ` yalin wang
2015-10-14 8:23 ` Arnd Bergmann
2015-10-14 12:01 ` yalin wang
2015-10-13 14:24 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox