[PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Meng Li]

When verifying watchdog feature on NXP ls1046ardb board,
it doesn't work. Because the big-endian is deleted by accident,
add it back.

Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for mmc nodes")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 4d75bff0d548..e15ec2e1cb04 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -753,6 +753,7 @@ wdog0: watchdog@2ad0000 {
 			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
 					    QORIQ_CLK_PLL_DIV(2)>;
+			big-endian;
 		};
 
 		edma0: dma-controller@2c00000 {
-- 
2.34.1

Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Krzysztof Kozlowski]

On 28/05/2025 13:17, Meng Li wrote:
> When verifying watchdog feature on NXP ls1046ardb board,
> it doesn't work. Because the big-endian is deleted by accident,
> add it back.

It is not removed by accident. It was removed intentionally. Bring
arguments (bindings, hardware, drivers) why this is correct choice.

Best regards,
Krzysztof

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Wednesday, May 28, 2025 8:09 PM
> To: Li, Meng <Meng.Li@windriver.com>; shawnguo@kernel.org;
> robh@kernel.org; conor+dt@kernel.org; Frank.Li@nxp.com
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On 28/05/2025 13:17, Meng Li wrote:
> > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > work. Because the big-endian is deleted by accident, add it back.
> 
> It is not removed by accident. It was removed intentionally. Bring arguments
> (bindings, hardware, drivers) why this is correct choice.
> 

The fixed patch author has reviewed this patch.  big-endian property is removed by accident.
I have verified this patch on big-endian property with driver ./drivers/watchdog/imx2_wdt.c.

Thanks,
LImeng

> Best regards,
> Krzysztof

Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Rob Herring (Arm)]

On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> When verifying watchdog feature on NXP ls1046ardb board,
> it doesn't work. Because the big-endian is deleted by accident,
> add it back.
> 
> Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for mmc nodes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: failed to guess base

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-Meng.Li@windriver.com:

arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb: watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not allow True
	from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb: watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not allow True
	from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not allow True
	from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dtb: watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not allow True
	from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

Hi Frank,

Do you have any suggestions for this issue?
Could you please help check whether we need to fix this issue?

Thanks,
LImeng

> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: Wednesday, May 28, 2025 8:37 PM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: devicetree@vger.kernel.org; shawnguo@kernel.org; linux-
> kernel@vger.kernel.org; Frank.Li@nxp.com; linux-arm-
> kernel@lists.infradead.org; conor+dt@kernel.org; Li, Meng
> <Meng.Li@windriver.com>
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > work. Because the big-endian is deleted by accident, add it back.
> >
> > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> > mmc nodes")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are
> fixed by another series. Ultimately, it is up to the platform maintainer whether
> these warnings are acceptable or not. No need to reply unless the platform
> maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then make sure dt-
> schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: failed to guess base
> 
> If this is not the correct base, please add 'base-commit' tag (or use b4 which
> does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for
> arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-
> Meng.Li@windriver.com:
> 
> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb: watchdog@2ad0000
> (fsl,imx21-wdt): big-endian: False schema does not allow True
>         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> wdt.yaml#
> arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb: watchdog@2ad0000
> (fsl,imx21-wdt): big-endian: False schema does not allow True
>         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> wdt.yaml#
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000
> (fsl,imx21-wdt): big-endian: False schema does not allow True
>         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> wdt.yaml#
> arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dtb:
> watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not
> allow True
>         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> wdt.yaml#
> 
> 
> 
> 

Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Frank Li]

On Thu, May 29, 2025 at 04:07:27AM +0000, Li, Meng wrote:
> Hi Frank,
>
> Do you have any suggestions for this issue?
> Could you please help check whether we need to fix this issue?

Fix binding doc

diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 0da953cb71272..8006efb69ec71 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -36,6 +36,7 @@ properties:
               - fsl,imx8mq-wdt
               - fsl,ls1012a-wdt
               - fsl,ls1043a-wdt
+              - fsl,ls1046a-wdt
               - fsl,vf610-wdt
           - const: fsl,imx21-wdt

@@ -103,6 +104,7 @@ allOf:
               enum:
                 - fsl,ls1012a-wdt
                 - fsl,ls1043a-wdt
+                - fsl,ls1046a-wdt

fix dtsi

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 0baf256b44003..096ed81a9bc4d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -687,7 +687,7 @@ lpuart5: serial@29a0000 {
                };

                wdog0: watchdog@2ad0000 {
-                       compatible = "fsl,imx21-wdt";
+                       compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";


Frank
>
> Thanks,
> LImeng
>
> > -----Original Message-----
> > From: Rob Herring (Arm) <robh@kernel.org>
> > Sent: Wednesday, May 28, 2025 8:37 PM
> > To: Li, Meng <Meng.Li@windriver.com>
> > Cc: devicetree@vger.kernel.org; shawnguo@kernel.org; linux-
> > kernel@vger.kernel.org; Frank.Li@nxp.com; linux-arm-
> > kernel@lists.infradead.org; conor+dt@kernel.org; Li, Meng
> > <Meng.Li@windriver.com>
> > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> > watchdog node
> >
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and
> > know the content is safe.
> >
> > On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> > > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > > work. Because the big-endian is deleted by accident, add it back.
> > >
> > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> > > mmc nodes")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> >
> >
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> >
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are
> > fixed by another series. Ultimately, it is up to the platform maintainer whether
> > these warnings are acceptable or not. No need to reply unless the platform
> > maintainer has comments.
> >
> > If you already ran DT checks and didn't see these error(s), then make sure dt-
> > schema is up to date:
> >
> >   pip3 install dtschema --upgrade
> >
> >
> > This patch series was applied (using b4) to base:
> >  Base: attempting to guess base-commit...
> >  Base: failed to guess base
> >
> > If this is not the correct base, please add 'base-commit' tag (or use b4 which
> > does this automatically)
> >
> > New warnings running 'make CHECK_DTBS=y for
> > arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-
> > Meng.Li@windriver.com:
> >
> > arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb: watchdog@2ad0000
> > (fsl,imx21-wdt): big-endian: False schema does not allow True
> >         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> > wdt.yaml#
> > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb: watchdog@2ad0000
> > (fsl,imx21-wdt): big-endian: False schema does not allow True
> >         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> > wdt.yaml#
> > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000
> > (fsl,imx21-wdt): big-endian: False schema does not allow True
> >         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> > wdt.yaml#
> > arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dtb:
> > watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not
> > allow True
> >         from schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-
> > wdt.yaml#
> >
> >
> >
> >
>

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Friday, May 30, 2025 12:05 AM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: Rob Herring (Arm) <robh@kernel.org>; devicetree@vger.kernel.org;
> shawnguo@kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; conor+dt@kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Thu, May 29, 2025 at 04:07:27AM +0000, Li, Meng wrote:
> > Hi Frank,
> >
> > Do you have any suggestions for this issue?
> > Could you please help check whether we need to fix this issue?
> 
> Fix binding doc
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 0da953cb71272..8006efb69ec71 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -36,6 +36,7 @@ properties:
>                - fsl,imx8mq-wdt
>                - fsl,ls1012a-wdt
>                - fsl,ls1043a-wdt
> +              - fsl,ls1046a-wdt
>                - fsl,vf610-wdt
>            - const: fsl,imx21-wdt
> 
> @@ -103,6 +104,7 @@ allOf:
>                enum:
>                  - fsl,ls1012a-wdt
>                  - fsl,ls1043a-wdt
> +                - fsl,ls1046a-wdt
> 
> fix dtsi
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 0baf256b44003..096ed81a9bc4d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -687,7 +687,7 @@ lpuart5: serial@29a0000 {
>                 };
> 
>                 wdog0: watchdog@2ad0000 {
> -                       compatible = "fsl,imx21-wdt";
> +                       compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";
> 
> 

Thanks, I will verify watchdog feature with above fixing code.

Regards,
LImeng

> Frank
> >
> > Thanks,
> > LImeng
> >
> > > -----Original Message-----
> > > From: Rob Herring (Arm) <robh@kernel.org>
> > > Sent: Wednesday, May 28, 2025 8:37 PM
> > > To: Li, Meng <Meng.Li@windriver.com>
> > > Cc: devicetree@vger.kernel.org; shawnguo@kernel.org; linux-
> > > kernel@vger.kernel.org; Frank.Li@nxp.com; linux-arm-
> > > kernel@lists.infradead.org; conor+dt@kernel.org; Li, Meng
> > > <Meng.Li@windriver.com>
> > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back
> > > into watchdog node
> > >
> > > CAUTION: This email comes from a non Wind River email account!
> > > Do not click links or open attachments unless you recognize the
> > > sender and know the content is safe.
> > >
> > > On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> > > > When verifying watchdog feature on NXP ls1046ardb board, it
> > > > doesn't work. Because the big-endian is deleted by accident, add it back.
> > > >
> > > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian
> > > > for mmc nodes")
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > >
> > >
> > > My bot found new DTB warnings on the .dts files added or changed in
> > > this series.
> > >
> > > Some warnings may be from an existing SoC .dtsi. Or perhaps the
> > > warnings are fixed by another series. Ultimately, it is up to the
> > > platform maintainer whether these warnings are acceptable or not. No
> > > need to reply unless the platform maintainer has comments.
> > >
> > > If you already ran DT checks and didn't see these error(s), then
> > > make sure dt- schema is up to date:
> > >
> > >   pip3 install dtschema --upgrade
> > >
> > >
> > > This patch series was applied (using b4) to base:
> > >  Base: attempting to guess base-commit...
> > >  Base: failed to guess base
> > >
> > > If this is not the correct base, please add 'base-commit' tag (or
> > > use b4 which does this automatically)
> > >
> > > New warnings running 'make CHECK_DTBS=y for
> > > arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-
> > > Meng.Li@windriver.com:
> > >
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb: watchdog@2ad0000
> > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb:
> watchdog@2ad0000
> > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000
> > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dtb:
> > > watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not
> > > allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > >
> > >
> > >
> > >
> >

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Friday, May 30, 2025 12:05 AM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: Rob Herring (Arm) <robh@kernel.org>; devicetree@vger.kernel.org;
> shawnguo@kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; conor+dt@kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Thu, May 29, 2025 at 04:07:27AM +0000, Li, Meng wrote:
> > Hi Frank,
> >
> > Do you have any suggestions for this issue?
> > Could you please help check whether we need to fix this issue?
> 
> Fix binding doc
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 0da953cb71272..8006efb69ec71 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -36,6 +36,7 @@ properties:
>                - fsl,imx8mq-wdt
>                - fsl,ls1012a-wdt
>                - fsl,ls1043a-wdt
> +              - fsl,ls1046a-wdt
>                - fsl,vf610-wdt
>            - const: fsl,imx21-wdt
> 
> @@ -103,6 +104,7 @@ allOf:
>                enum:
>                  - fsl,ls1012a-wdt
>                  - fsl,ls1043a-wdt
> +                - fsl,ls1046a-wdt
> 
> fix dtsi
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 0baf256b44003..096ed81a9bc4d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -687,7 +687,7 @@ lpuart5: serial@29a0000 {
>                 };
> 
>                 wdog0: watchdog@2ad0000 {
> -                       compatible = "fsl,imx21-wdt";
> +                       compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";
> 
> 

I have a question.
I checked the code of ./drivers/watchdog/imx2_wdt.c, there is below item imx2_wdt_dt_ids[]
{ .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy },
Do you think we also need to add another below item for ls1046?
{ .compatible = "fsl,ls1046a-wdt", .data = &imx_wdt_legacy },

Another question
I also checked the code ./arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi, and I found out below item in watchdog@2ad0000 node
compatible = "fsl,ls1043a-wdt", "fsl,imx21-wdt";
but in imx2_wdt_dt_ids[], there is also the below item, it also can support the ls1043a and ls1046a platforms
{ .compatible = "fsl,imx21-wdt", .data = &imx_wdt_legacy },
So, I think maybe we can remove the { .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.

Based on above description, there are 2 solutions, add { .compatible = "fsl,ls1046a-wdt", .data = &imx_wdt_legacy }, or remove { .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.
What is your suggestion？

Thanks,
LImeng



> Frank
> >
> > Thanks,
> > LImeng
> >
> > > -----Original Message-----
> > > From: Rob Herring (Arm) <robh@kernel.org>
> > > Sent: Wednesday, May 28, 2025 8:37 PM
> > > To: Li, Meng <Meng.Li@windriver.com>
> > > Cc: devicetree@vger.kernel.org; shawnguo@kernel.org; linux-
> > > kernel@vger.kernel.org; Frank.Li@nxp.com; linux-arm-
> > > kernel@lists.infradead.org; conor+dt@kernel.org; Li, Meng
> > > <Meng.Li@windriver.com>
> > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back
> > > into watchdog node
> > >
> > > CAUTION: This email comes from a non Wind River email account!
> > > Do not click links or open attachments unless you recognize the
> > > sender and know the content is safe.
> > >
> > > On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> > > > When verifying watchdog feature on NXP ls1046ardb board, it
> > > > doesn't work. Because the big-endian is deleted by accident, add it back.
> > > >
> > > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian
> > > > for mmc nodes")
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > >
> > >
> > > My bot found new DTB warnings on the .dts files added or changed in
> > > this series.
> > >
> > > Some warnings may be from an existing SoC .dtsi. Or perhaps the
> > > warnings are fixed by another series. Ultimately, it is up to the
> > > platform maintainer whether these warnings are acceptable or not. No
> > > need to reply unless the platform maintainer has comments.
> > >
> > > If you already ran DT checks and didn't see these error(s), then
> > > make sure dt- schema is up to date:
> > >
> > >   pip3 install dtschema --upgrade
> > >
> > >
> > > This patch series was applied (using b4) to base:
> > >  Base: attempting to guess base-commit...
> > >  Base: failed to guess base
> > >
> > > If this is not the correct base, please add 'base-commit' tag (or
> > > use b4 which does this automatically)
> > >
> > > New warnings running 'make CHECK_DTBS=y for
> > > arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-
> > > Meng.Li@windriver.com:
> > >
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb: watchdog@2ad0000
> > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb:
> watchdog@2ad0000
> > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000
> > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > > arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dtb:
> > > watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not
> > > allow True
> > >         from schema $id:
> > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > wdt.yaml#
> > >
> > >
> > >
> > >
> >

Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Frank Li]

On Fri, May 30, 2025 at 02:12:20AM +0000, Li, Meng wrote:
>
>
> > -----Original Message-----
> > From: Frank Li <Frank.li@nxp.com>
> > Sent: Friday, May 30, 2025 12:05 AM
> > To: Li, Meng <Meng.Li@windriver.com>
> > Cc: Rob Herring (Arm) <robh@kernel.org>; devicetree@vger.kernel.org;
> > shawnguo@kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; conor+dt@kernel.org
> > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> > watchdog node
> >
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and
> > know the content is safe.
> >
> > On Thu, May 29, 2025 at 04:07:27AM +0000, Li, Meng wrote:
> > > Hi Frank,
> > >
> > > Do you have any suggestions for this issue?
> > > Could you please help check whether we need to fix this issue?
> >
> > Fix binding doc
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > index 0da953cb71272..8006efb69ec71 100644
> > --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > @@ -36,6 +36,7 @@ properties:
> >                - fsl,imx8mq-wdt
> >                - fsl,ls1012a-wdt
> >                - fsl,ls1043a-wdt
> > +              - fsl,ls1046a-wdt
> >                - fsl,vf610-wdt
> >            - const: fsl,imx21-wdt
> >
> > @@ -103,6 +104,7 @@ allOf:
> >                enum:
> >                  - fsl,ls1012a-wdt
> >                  - fsl,ls1043a-wdt
> > +                - fsl,ls1046a-wdt
> >
> > fix dtsi
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index 0baf256b44003..096ed81a9bc4d 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -687,7 +687,7 @@ lpuart5: serial@29a0000 {
> >                 };
> >
> >                 wdog0: watchdog@2ad0000 {
> > -                       compatible = "fsl,imx21-wdt";
> > +                       compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";
> >
> >
>
> I have a question.
> I checked the code of ./drivers/watchdog/imx2_wdt.c, there is below item imx2_wdt_dt_ids[]
> { .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy },
> Do you think we also need to add another below item for ls1046?

{ .compatible = "fsl,imx21-wdt", .data = &imx_wdt_legacy }, it is enough
by use fallback fsl,imx21-wdt.

> { .compatible = "fsl,ls1046a-wdt", .data = &imx_wdt_legacy },
>
> Another question
> I also checked the code ./arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi, and I found out below item in watchdog@2ad0000 node
> compatible = "fsl,ls1043a-wdt", "fsl,imx21-wdt";
> but in imx2_wdt_dt_ids[], there is also the below item, it also can support the ls1043a and ls1046a platforms
> { .compatible = "fsl,imx21-wdt", .data = &imx_wdt_legacy },
> So, I think maybe we can remove the { .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.

Yes, but not nessesary to do that. leave it as it.

>
> Based on above description, there are 2 solutions, add { .compatible = "fsl,ls1046a-wdt", .data = &imx_wdt_legacy }, or remove { .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.
> What is your suggestion？

leave driver code unchange. the current driver can work.

Frank

>
> Thanks,
> LImeng
>
>
>
> > Frank
> > >
> > > Thanks,
> > > LImeng
> > >
> > > > -----Original Message-----
> > > > From: Rob Herring (Arm) <robh@kernel.org>
> > > > Sent: Wednesday, May 28, 2025 8:37 PM
> > > > To: Li, Meng <Meng.Li@windriver.com>
> > > > Cc: devicetree@vger.kernel.org; shawnguo@kernel.org; linux-
> > > > kernel@vger.kernel.org; Frank.Li@nxp.com; linux-arm-
> > > > kernel@lists.infradead.org; conor+dt@kernel.org; Li, Meng
> > > > <Meng.Li@windriver.com>
> > > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back
> > > > into watchdog node
> > > >
> > > > CAUTION: This email comes from a non Wind River email account!
> > > > Do not click links or open attachments unless you recognize the
> > > > sender and know the content is safe.
> > > >
> > > > On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> > > > > When verifying watchdog feature on NXP ls1046ardb board, it
> > > > > doesn't work. Because the big-endian is deleted by accident, add it back.
> > > > >
> > > > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian
> > > > > for mmc nodes")
> > > > > Cc: stable@vger.kernel.org
> > > > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > > > ---
> > > > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > >
> > > >
> > > > My bot found new DTB warnings on the .dts files added or changed in
> > > > this series.
> > > >
> > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the
> > > > warnings are fixed by another series. Ultimately, it is up to the
> > > > platform maintainer whether these warnings are acceptable or not. No
> > > > need to reply unless the platform maintainer has comments.
> > > >
> > > > If you already ran DT checks and didn't see these error(s), then
> > > > make sure dt- schema is up to date:
> > > >
> > > >   pip3 install dtschema --upgrade
> > > >
> > > >
> > > > This patch series was applied (using b4) to base:
> > > >  Base: attempting to guess base-commit...
> > > >  Base: failed to guess base
> > > >
> > > > If this is not the correct base, please add 'base-commit' tag (or
> > > > use b4 which does this automatically)
> > > >
> > > > New warnings running 'make CHECK_DTBS=y for
> > > > arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-
> > > > Meng.Li@windriver.com:
> > > >
> > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb: watchdog@2ad0000
> > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > >         from schema $id:
> > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > wdt.yaml#
> > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb:
> > watchdog@2ad0000
> > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > >         from schema $id:
> > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > wdt.yaml#
> > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000
> > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > >         from schema $id:
> > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > wdt.yaml#
> > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-mbls10xxa.dtb:
> > > > watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does not
> > > > allow True
> > > >         from schema $id:
> > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > wdt.yaml#
> > > >
> > > >
> > > >
> > > >
> > >

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Friday, May 30, 2025 11:11 PM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: Rob Herring (Arm) <robh@kernel.org>; devicetree@vger.kernel.org;
> shawnguo@kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; conor+dt@kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Fri, May 30, 2025 at 02:12:20AM +0000, Li, Meng wrote:
> >
> >
> > > -----Original Message-----
> > > From: Frank Li <Frank.li@nxp.com>
> > > Sent: Friday, May 30, 2025 12:05 AM
> > > To: Li, Meng <Meng.Li@windriver.com>
> > > Cc: Rob Herring (Arm) <robh@kernel.org>; devicetree@vger.kernel.org;
> > > shawnguo@kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> > > kernel@lists.infradead.org; conor+dt@kernel.org
> > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back
> > > into watchdog node
> > >
> > > CAUTION: This email comes from a non Wind River email account!
> > > Do not click links or open attachments unless you recognize the
> > > sender and know the content is safe.
> > >
> > > On Thu, May 29, 2025 at 04:07:27AM +0000, Li, Meng wrote:
> > > > Hi Frank,
> > > >
> > > > Do you have any suggestions for this issue?
> > > > Could you please help check whether we need to fix this issue?
> > >
> > > Fix binding doc
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > index 0da953cb71272..8006efb69ec71 100644
> > > --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > @@ -36,6 +36,7 @@ properties:
> > >                - fsl,imx8mq-wdt
> > >                - fsl,ls1012a-wdt
> > >                - fsl,ls1043a-wdt
> > > +              - fsl,ls1046a-wdt
> > >                - fsl,vf610-wdt
> > >            - const: fsl,imx21-wdt
> > >
> > > @@ -103,6 +104,7 @@ allOf:
> > >                enum:
> > >                  - fsl,ls1012a-wdt
> > >                  - fsl,ls1043a-wdt
> > > +                - fsl,ls1046a-wdt
> > >
> > > fix dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > index 0baf256b44003..096ed81a9bc4d 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > @@ -687,7 +687,7 @@ lpuart5: serial@29a0000 {
> > >                 };
> > >
> > >                 wdog0: watchdog@2ad0000 {
> > > -                       compatible = "fsl,imx21-wdt";
> > > +                       compatible = "fsl,ls1046a-wdt",
> > > + "fsl,imx21-wdt";
> > >
> > >
> >
> > I have a question.
> > I checked the code of ./drivers/watchdog/imx2_wdt.c, there is below
> > item imx2_wdt_dt_ids[] { .compatible = "fsl,ls1043a-wdt", .data =
> > &imx_wdt_legacy }, Do you think we also need to add another below item
> for ls1046?
> 
> { .compatible = "fsl,imx21-wdt", .data = &imx_wdt_legacy }, it is enough by use
> fallback fsl,imx21-wdt.
> 
> > { .compatible = "fsl,ls1046a-wdt", .data = &imx_wdt_legacy },
> >
> > Another question
> > I also checked the code
> > ./arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi, and I found out
> > below item in watchdog@2ad0000 node compatible = "fsl,ls1043a-wdt",
> > "fsl,imx21-wdt"; but in imx2_wdt_dt_ids[], there is also the below
> > item, it also can support the ls1043a and ls1046a platforms { .compatible =
> "fsl,imx21-wdt", .data = &imx_wdt_legacy }, So, I think maybe we can remove
> the { .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.
> 
> Yes, but not nessesary to do that. leave it as it.
> 
> >
> > Based on above description, there are 2 solutions, add { .compatible =
> "fsl,ls1046a-wdt", .data = &imx_wdt_legacy }, or remove { .compatible =
> "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.
> > What is your suggestion？
> 
> leave driver code unchange. the current driver can work.
> 

Ok! Got it.
I have sent v2 patch review.

Thanks,
Limeng

> Frank
> 
> >
> > Thanks,
> > LImeng
> >
> >
> >
> > > Frank
> > > >
> > > > Thanks,
> > > > LImeng
> > > >
> > > > > -----Original Message-----
> > > > > From: Rob Herring (Arm) <robh@kernel.org>
> > > > > Sent: Wednesday, May 28, 2025 8:37 PM
> > > > > To: Li, Meng <Meng.Li@windriver.com>
> > > > > Cc: devicetree@vger.kernel.org; shawnguo@kernel.org; linux-
> > > > > kernel@vger.kernel.org; Frank.Li@nxp.com; linux-arm-
> > > > > kernel@lists.infradead.org; conor+dt@kernel.org; Li, Meng
> > > > > <Meng.Li@windriver.com>
> > > > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property
> > > > > back into watchdog node
> > > > >
> > > > > CAUTION: This email comes from a non Wind River email account!
> > > > > Do not click links or open attachments unless you recognize the
> > > > > sender and know the content is safe.
> > > > >
> > > > > On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> > > > > > When verifying watchdog feature on NXP ls1046ardb board, it
> > > > > > doesn't work. Because the big-endian is deleted by accident, add it
> back.
> > > > > >
> > > > > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove
> > > > > > big-endian for mmc nodes")
> > > > > > Cc: stable@vger.kernel.org
> > > > > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > > > > ---
> > > > > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > > > > >  1 file changed, 1 insertion(+)
> > > > > >
> > > > >
> > > > >
> > > > > My bot found new DTB warnings on the .dts files added or changed
> > > > > in this series.
> > > > >
> > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the
> > > > > warnings are fixed by another series. Ultimately, it is up to
> > > > > the platform maintainer whether these warnings are acceptable or
> > > > > not. No need to reply unless the platform maintainer has comments.
> > > > >
> > > > > If you already ran DT checks and didn't see these error(s), then
> > > > > make sure dt- schema is up to date:
> > > > >
> > > > >   pip3 install dtschema --upgrade
> > > > >
> > > > >
> > > > > This patch series was applied (using b4) to base:
> > > > >  Base: attempting to guess base-commit...
> > > > >  Base: failed to guess base
> > > > >
> > > > > If this is not the correct base, please add 'base-commit' tag
> > > > > (or use b4 which does this automatically)
> > > > >
> > > > > New warnings running 'make CHECK_DTBS=y for
> > > > > arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-
> > > > > Meng.Li@windriver.com:
> > > > >
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb:
> > > > > watchdog@2ad0000
> > > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > > >         from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb:
> > > watchdog@2ad0000
> > > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > > >         from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb:
> > > > > watchdog@2ad0000
> > > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > > >         from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-
> mbls10xxa.dtb:
> > > > > watchdog@2ad0000 (fsl,imx21-wdt): big-endian: False schema does
> > > > > not allow True
> > > > >         from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > >
> > > > >
> > > > >
> > > > >
> > > >

Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Frank Li]

On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> When verifying watchdog feature on NXP ls1046ardb board,
> it doesn't work. Because the big-endian is deleted by accident,
> add it back.
>
> Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for mmc nodes")

fix tags should be wrong.

I remember I tested without big-endian. If it is wrong, please revert original
patch and provide enough reason.

Frank

> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 4d75bff0d548..e15ec2e1cb04 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -753,6 +753,7 @@ wdog0: watchdog@2ad0000 {
>  			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(2)>;
> +			big-endian;
>  		};
>
>  		edma0: dma-controller@2c00000 {
> --
> 2.34.1
>

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Thursday, May 29, 2025 12:11 AM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: shawnguo@kernel.org; robh@kernel.org; conor+dt@kernel.org; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > work. Because the big-endian is deleted by accident, add it back.
> >
> > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> > mmc nodes")
> 
> fix tags should be wrong.
> 
> I remember I tested without big-endian. If it is wrong, please revert original
> patch and provide enough reason.
> 

Although you said you understand my patch in your next email, do you think I still need to improve my commit log more clearly, and send a v2 patch?
For example, describe that only the big-endian of watchdog node is remove by accident, and the mmc works fine. Only add the big-endian for watchdog feature.

Thanks,
Limeng

> Frank
> 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index 4d75bff0d548..e15ec2e1cb04 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -753,6 +753,7 @@ wdog0: watchdog@2ad0000 {
> >                       interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> >                       clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> >                                           QORIQ_CLK_PLL_DIV(2)>;
> > +                     big-endian;
> >               };
> >
> >               edma0: dma-controller@2c00000 {
> > --
> > 2.34.1
> >

Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Frank Li]

On Thu, May 29, 2025 at 05:50:03AM +0000, Li, Meng wrote:
>
>
> > -----Original Message-----
> > From: Frank Li <Frank.li@nxp.com>
> > Sent: Thursday, May 29, 2025 12:11 AM
> > To: Li, Meng <Meng.Li@windriver.com>
> > Cc: shawnguo@kernel.org; robh@kernel.org; conor+dt@kernel.org; linux-arm-
> > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> > watchdog node
> >
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and
> > know the content is safe.
> >
> > On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> > > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > > work. Because the big-endian is deleted by accident, add it back.
> > >
> > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> > > mmc nodes")
> >
> > fix tags should be wrong.
> >
> > I remember I tested without big-endian. If it is wrong, please revert original
> > patch and provide enough reason.
> >
>
> Although you said you understand my patch in your next email, do you think I still need to improve my commit log more clearly, and send a v2 patch?
> For example, describe that only the big-endian of watchdog node is remove by accident, and the mmc works fine. Only add the big-endian for watchdog feature.

Yes, you'd better descript why it is accident remove.

Frank
>
> Thanks,
> Limeng
>
> > Frank
> >
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > index 4d75bff0d548..e15ec2e1cb04 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > @@ -753,6 +753,7 @@ wdog0: watchdog@2ad0000 {
> > >                       interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > >                       clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> > >                                           QORIQ_CLK_PLL_DIV(2)>;
> > > +                     big-endian;
> > >               };
> > >
> > >               edma0: dma-controller@2c00000 {
> > > --
> > > 2.34.1
> > >

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Friday, May 30, 2025 12:01 AM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: shawnguo@kernel.org; robh@kernel.org; conor+dt@kernel.org; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Thu, May 29, 2025 at 05:50:03AM +0000, Li, Meng wrote:
> >
> >
> > > -----Original Message-----
> > > From: Frank Li <Frank.li@nxp.com>
> > > Sent: Thursday, May 29, 2025 12:11 AM
> > > To: Li, Meng <Meng.Li@windriver.com>
> > > Cc: shawnguo@kernel.org; robh@kernel.org; conor+dt@kernel.org;
> > > linux-arm- kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > > linux- kernel@vger.kernel.org
> > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back
> > > into watchdog node
> > >
> > > CAUTION: This email comes from a non Wind River email account!
> > > Do not click links or open attachments unless you recognize the
> > > sender and know the content is safe.
> > >
> > > On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> > > > When verifying watchdog feature on NXP ls1046ardb board, it
> > > > doesn't work. Because the big-endian is deleted by accident, add it back.
> > > >
> > > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian
> > > > for mmc nodes")
> > >
> > > fix tags should be wrong.
> > >
> > > I remember I tested without big-endian. If it is wrong, please
> > > revert original patch and provide enough reason.
> > >
> >
> > Although you said you understand my patch in your next email, do you think
> I still need to improve my commit log more clearly, and send a v2 patch?
> > For example, describe that only the big-endian of watchdog node is remove
> by accident, and the mmc works fine. Only add the big-endian for watchdog
> feature.
> 
> Yes, you'd better descript why it is accident remove.
> 

Ok! Got it.

Thanks,
LImeng

> Frank
> >
> > Thanks,
> > Limeng
> >
> > > Frank
> > >
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > > index 4d75bff0d548..e15ec2e1cb04 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > > @@ -753,6 +753,7 @@ wdog0: watchdog@2ad0000 {
> > > >                       interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > > >                       clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> > > >                                           QORIQ_CLK_PLL_DIV(2)>;
> > > > +                     big-endian;
> > > >               };
> > > >
> > > >               edma0: dma-controller@2c00000 {
> > > > --
> > > > 2.34.1
> > > >

Re: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Frank Li]

On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> When verifying watchdog feature on NXP ls1046ardb board,
> it doesn't work. Because the big-endian is deleted by accident,
> add it back.
>
> Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for mmc nodes")

Sorry, forget previous comments. You are right. It is accident remove big-endian
at watchdog@2ad0000.

7c8ffc5555cb should only remove big-endina for mmc nodes.

Reviewed-by: Frank Li <Frank.Li@nxp.com>


> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 4d75bff0d548..e15ec2e1cb04 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -753,6 +753,7 @@ wdog0: watchdog@2ad0000 {
>  			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(2)>;
> +			big-endian;
>  		};
>
>  		edma0: dma-controller@2c00000 {
> --
> 2.34.1
>

RE: [PATCH] arch: arm64: dts: add big-endian property back into watchdog node

[Li, Meng]

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Thursday, May 29, 2025 12:16 AM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: shawnguo@kernel.org; robh@kernel.org; conor+dt@kernel.org; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > work. Because the big-endian is deleted by accident, add it back.
> >
> > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> > mmc nodes")
> 
> Sorry, forget previous comments. You are right. It is accident remove big-
> endian at watchdog@2ad0000.
> 
> 7c8ffc5555cb should only remove big-endina for mmc nodes.
> 
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> 

Very appreciate that you help to review my patch and make sure the fixing is useful.

Thanks,
Limeng

> 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index 4d75bff0d548..e15ec2e1cb04 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -753,6 +753,7 @@ wdog0: watchdog@2ad0000 {
> >                       interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> >                       clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> >                                           QORIQ_CLK_PLL_DIV(2)>;
> > +                     big-endian;
> >               };
> >
> >               edma0: dma-controller@2c00000 {
> > --
> > 2.34.1
> >