* [PATCH] ARM: drop experimental mark for ARM stack unwinding
@ 2018-08-11 10:31 Stefan Agner
2018-08-11 16:57 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Agner @ 2018-08-11 10:31 UTC (permalink / raw)
To: linux-arm-kernel
ARM stack unwinding is upstream since 2009 and has been proven
working well. At this time it is the preferred stack unwinding
support since it also supports Thumb 2. Do not scare people
and drop the EXPERIMENTAL mark.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index cb65cf67dfa2..ba2d94555e06 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -63,7 +63,7 @@ config FRAME_POINTER
reported is severely limited.
config ARM_UNWIND
- bool "Enable stack unwinding support (EXPERIMENTAL)"
+ bool "Enable stack unwinding support"
depends on AEABI
default y
help
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: drop experimental mark for ARM stack unwinding
2018-08-11 10:31 [PATCH] ARM: drop experimental mark for ARM stack unwinding Stefan Agner
@ 2018-08-11 16:57 ` Russell King - ARM Linux
2018-08-11 18:19 ` Stefan Agner
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2018-08-11 16:57 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Aug 11, 2018 at 12:31:27PM +0200, Stefan Agner wrote:
> ARM stack unwinding is upstream since 2009 and has been proven
> working well. At this time it is the preferred stack unwinding
> support since it also supports Thumb 2. Do not scare people
> and drop the EXPERIMENTAL mark.
Actually, there are still cases where we're missing the annotations -
I've seen them in various oops dumps, but I forget where they are.
What I do remember is that they didn't seem trivial to fix at the
time, so it's still recommended that frame pointers are used if you
want to guarantee getting a debuggable oops dump.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: drop experimental mark for ARM stack unwinding
2018-08-11 16:57 ` Russell King - ARM Linux
@ 2018-08-11 18:19 ` Stefan Agner
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Agner @ 2018-08-11 18:19 UTC (permalink / raw)
To: linux-arm-kernel
On 11.08.2018 18:57, Russell King - ARM Linux wrote:
> On Sat, Aug 11, 2018 at 12:31:27PM +0200, Stefan Agner wrote:
>> ARM stack unwinding is upstream since 2009 and has been proven
>> working well. At this time it is the preferred stack unwinding
>> support since it also supports Thumb 2. Do not scare people
>> and drop the EXPERIMENTAL mark.
>
> Actually, there are still cases where we're missing the annotations -
> I've seen them in various oops dumps, but I forget where they are.
> What I do remember is that they didn't seem trivial to fix at the
> time, so it's still recommended that frame pointers are used if you
> want to guarantee getting a debuggable oops dump.
Ok, but does that warrants the experimental mark?
Experimental sounds rather harsh to me. People might disable it because
of that... I'd rather have a >90% chance of having a good stack trace
than none at all.
--
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-11 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-11 10:31 [PATCH] ARM: drop experimental mark for ARM stack unwinding Stefan Agner
2018-08-11 16:57 ` Russell King - ARM Linux
2018-08-11 18:19 ` Stefan Agner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox