From: Markus Elfring <Markus.Elfring@web.de>
To: Mohammad Shahid <mdshahid03@gmail.com>,
linux-iio@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Joshua Crofts" <joshua.crofts@broadcom.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>
Subject: Re: [PATCH v4 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer
Date: Mon, 3 Aug 2026 14:44:37 +0200 [thread overview]
Message-ID: <9d56c8d2-67bb-4c04-94cd-7fd5c7ee940f@web.de> (raw)
In-Reply-To: <20260801090953.61603-3-mdshahid03@gmail.com>
…
> +++ b/drivers/iio/adc/bcm_iproc_adc.c
> @@ -506,9 +506,10 @@ static int iproc_adc_probe(struct platform_device *pdev)
> {
> struct iproc_adc_priv *adc_priv;
> struct iio_dev *indio_dev = NULL;
> + struct device *dev = &pdev->dev;
> int ret;
>
> - indio_dev = devm_iio_device_alloc(&pdev->dev,
> + indio_dev = devm_iio_device_alloc(dev,
> sizeof(*adc_priv));
…
Would an other adjustment be a bit nicer?
+ indio_dev = devm_iio_device_alloc(dev, sizeof(*adc_priv));
…
> @@ -523,14 +524,14 @@ static int iproc_adc_probe(struct platform_device *pdev)
> adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
> "adc-syscon");
> if (IS_ERR(adc_priv->regmap)) {
> - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n");
> + dev_err(dev, "failed to get handle for tsc syscon\n");
> ret = PTR_ERR(adc_priv->regmap);
> return ret;
> }
…
Can further source code refinements become helpful here?
Regards,
Markus
next prev parent reply other threads:[~2026-08-03 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 9:09 [PATCH v4 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling mdshahid03
2026-08-01 9:09 ` [PATCH v4 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages mdshahid03
2026-08-03 12:19 ` Joshua Crofts
2026-08-01 9:09 ` [PATCH v4 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer mdshahid03
2026-08-01 14:49 ` David Lechner
2026-08-03 12:44 ` Markus Elfring [this message]
2026-08-01 9:09 ` [PATCH v4 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() mdshahid03
2026-08-01 14:51 ` David Lechner
2026-08-03 13:01 ` Markus Elfring
2026-08-02 2:06 ` [PATCH v4 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d56c8d2-67bb-4c04-94cd-7fd5c7ee940f@web.de \
--to=markus.elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdshahid03@gmail.com \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox