Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Bischoff <sascha.bischoff@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	nd@arm.com
Subject: Re: [PATCH 0/2] irqchip/gic-v5: Fix standalone IRSes OF driver probe and DT bindings
Date: Thu, 15 Oct 2026 10:40:00 +0100	[thread overview]
Message-ID: <9ee56f06-4b4e-4355-b8c4-68d185eb3ce7@arm.com> (raw)
In-Reply-To: <20261015-gicv5-irs-no-cpus-v1-0-d4b337b7f000@kernel.org>

On 15/10/2026 09:20, Lorenzo Pieralisi wrote:
> The GICv5 architecture allows IRSes to be designed as standalone, ie with
> no CPU connection, to support system topologies where the IRS is separated
> from CPUs.
> 
> Current OF code fails the IRS probe if "cpus" and "arm,iaffids" properties,
> that define IRS<->CPU connections, are missing (which goes against the
> current schema because they are "required"), which is not correct for
> the aforementioned reasons.
> 
> DT schema for GICv5 must be updated in that "cpus" and "arm,iaffids"
> properties are currently defined as "required" which is not correct
> (unless there is a way to keep them "required" and empty) and must
> be relaxed.
> 
> I do not think it is possible to keep "cpus" and "arm,iaffids" as
> "required" and allow them to be empty lists - I would need DT
> maintainers feedback on that to see what is best.
> 
> I did not mark patches for stable kernels because I would like to get
> feedback on the DT binding changes first before sending any change that
> is potentially ABI changing back to stable kernels (strictly speaking
> I do not think the DT changes can actually break anything - the only
> potential issue is DT files that do declare "cpus" and "arm,iaffids" as
> empty list against the schema - if they do that they are already broken
> and this patchset changes nothing in that respect).
> 
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>

Thanks for fixing this issue, Lorenzo. It would be a shame if we 
couldn't describe all possible topologies!

These changes look good to me:

Reviewed-by: Sascha Bischoff <sascha.bischoff@arm.com>

Thanks,
Sascha

> ---
> Lorenzo Pieralisi (2):
>        dt-bindings: interrupt-controller: gicv5: Relax IRS properties constraints
>        irqchip/gic-v5: Fix standalone IRSes OF probe
> 
>   .../devicetree/bindings/interrupt-controller/arm,gic-v5.yaml     | 9 ++++++---
>   drivers/irqchip/irq-gic-v5-irs.c                                 | 4 ++++
>   2 files changed, 10 insertions(+), 3 deletions(-)
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20261014-gicv5-irs-no-cpus-8c5fba3f9940
> 
> Best regards,
> --
> Lorenzo Pieralisi <lpieralisi@kernel.org>



      parent reply	other threads:[~2026-10-15  9:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  8:20 [PATCH 0/2] irqchip/gic-v5: Fix standalone IRSes OF driver probe and DT bindings Lorenzo Pieralisi
2026-10-15  8:20 ` [PATCH 1/2] dt-bindings: interrupt-controller: gicv5: Relax IRS properties constraints Lorenzo Pieralisi
2026-10-15 10:50   ` Lorenzo Pieralisi
2026-10-15  8:20 ` [PATCH 2/2] irqchip/gic-v5: Fix standalone IRSes OF probe Lorenzo Pieralisi
2026-10-15  9:40 ` Sascha Bischoff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ee56f06-4b4e-4355-b8c4-68d185eb3ce7@arm.com \
    --to=sascha.bischoff@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=maz@kernel.org \
    --cc=nd@arm.com \
    --cc=robh@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox