From: "Rui Miguel Silva" <rmfrfs@gmail.com>
To: "Wei Yongjun" <weiyongjun1@huawei.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Steve Longerbeam" <slongerbeam@gmail.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Cc: <linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>,
<kernel-janitors@vger.kernel.org>,
"Hulk Robot" <hulkci@huawei.com>
Subject: Re: [PATCH -next] media: imx: imx7_mipi_csis: Fix error return code in mipi_csis_async_register()
Date: Tue, 25 May 2021 21:49:04 +0100 [thread overview]
Message-ID: <CBMMEYM3MW7O.2U464BSP8CLQA@arch-thunder> (raw)
In-Reply-To: <20210524133552.2365248-1-weiyongjun1@huawei.com>
Hi Yongjun,
Thanks for the patch.
On Mon May 24, 2021 at 2:35 PM WEST, Wei Yongjun wrote:
> Fix to return negative error code -EINVAL from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 88fc81388df9 ("media: imx: imx7_mipi_csis: Reject invalid data-lanes settings")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Looks good to me, thanks.
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
------
Cheers,
Rui
> ---
> drivers/staging/media/imx/imx7-mipi-csis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
> index d573f3475d28..9cd3c86fee58 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -1175,6 +1175,7 @@ static int mipi_csis_async_register(struct csi_state *state)
> if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) {
> dev_err(state->dev,
> "data lanes reordering is not supported");
> + ret = -EINVAL;
> goto err_parse;
> }
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-25 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 13:35 [PATCH -next] media: imx: imx7_mipi_csis: Fix error return code in mipi_csis_async_register() Wei Yongjun
2021-05-25 20:49 ` Rui Miguel Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBMMEYM3MW7O.2U464BSP8CLQA@arch-thunder \
--to=rmfrfs@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox