* [PATCH] mailbox: exynos: Drop unused register definitions
@ 2026-04-30 11:12 Tudor Ambarus
2026-05-14 0:57 ` Alexey Klimov
0 siblings, 1 reply; 2+ messages in thread
From: Tudor Ambarus @ 2026-04-30 11:12 UTC (permalink / raw)
To: Jassi Brar, Krzysztof Kozlowski, Alim Akhtar
Cc: alexey.klimov, linux-kernel, linux-samsung-soc, linux-arm-kernel,
Tudor Ambarus
Leaving these dead definitions in place hides which registers are
actually being used by the hardware, making the driver harder to read
and maintain. Remove them to clean up the file.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
drivers/mailbox/exynos-mailbox.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mailbox.c
index 5f2d3b81c1db..953e715a89b1 100644
--- a/drivers/mailbox/exynos-mailbox.c
+++ b/drivers/mailbox/exynos-mailbox.c
@@ -16,15 +16,8 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
-#define EXYNOS_MBOX_MCUCTRL 0x0 /* Mailbox Control Register */
-#define EXYNOS_MBOX_INTCR0 0x24 /* Interrupt Clear Register 0 */
#define EXYNOS_MBOX_INTMR0 0x28 /* Interrupt Mask Register 0 */
-#define EXYNOS_MBOX_INTSR0 0x2c /* Interrupt Status Register 0 */
-#define EXYNOS_MBOX_INTMSR0 0x30 /* Interrupt Mask Status Register 0 */
#define EXYNOS_MBOX_INTGR1 0x40 /* Interrupt Generation Register 1 */
-#define EXYNOS_MBOX_INTMR1 0x48 /* Interrupt Mask Register 1 */
-#define EXYNOS_MBOX_INTSR1 0x4c /* Interrupt Status Register 1 */
-#define EXYNOS_MBOX_INTMSR1 0x50 /* Interrupt Mask Status Register 1 */
#define EXYNOS_MBOX_INTMR0_MASK GENMASK(15, 0)
#define EXYNOS_MBOX_INTGR1_MASK GENMASK(15, 0)
---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260430-exynos-mbox-dead-def-e019a9ccce3f
Best regards,
--
Tudor Ambarus <tudor.ambarus@linaro.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: exynos: Drop unused register definitions
2026-04-30 11:12 [PATCH] mailbox: exynos: Drop unused register definitions Tudor Ambarus
@ 2026-05-14 0:57 ` Alexey Klimov
0 siblings, 0 replies; 2+ messages in thread
From: Alexey Klimov @ 2026-05-14 0:57 UTC (permalink / raw)
To: Tudor Ambarus, Jassi Brar, Krzysztof Kozlowski, Alim Akhtar
Cc: linux-kernel, linux-samsung-soc, linux-arm-kernel
On Thu Apr 30, 2026 at 12:12 PM BST, Tudor Ambarus wrote:
> Leaving these dead definitions in place hides which registers are
> actually being used by the hardware, making the driver harder to read
> and maintain. Remove them to clean up the file.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/mailbox/exynos-mailbox.c | 7 -------
> 1 file changed, 7 deletions(-)
Reviewed-by: Alexey Klimov <alexey.klimov@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-14 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-30 11:12 [PATCH] mailbox: exynos: Drop unused register definitions Tudor Ambarus
2026-05-14 0:57 ` Alexey Klimov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox