From: Mark Rutland <mark.rutland@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Marc Zyngier <maz@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
rostedt@goodmis.org, Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: Misaligned patch-site bcm2836_arm_irqchip_handle_irq+0x0/0x88
Date: Mon, 27 Feb 2023 12:10:05 +0000 [thread overview]
Message-ID: <Y/ycGp4EN4mKjGKA@FVFF77S0Q05N> (raw)
In-Reply-To: <Y/yUxs1SPxhJNrYy@FVFF77S0Q05N>
On Mon, Feb 27, 2023 at 11:32:22AM +0000, Mark Rutland wrote:
> Hi Florian,
>
> On Sat, Feb 25, 2023 at 07:26:50AM -0800, Florian Fainelli wrote:
> > On 2/25/2023 2:37 AM, Marc Zyngier wrote:
> > > On Fri, 24 Feb 2023 23:39:24 +0000,
> > > Florian Fainelli <f.fainelli@gmail.com> wrote:
> > > >
> > > > Hello,
> > > >
> > > > You will find a complete boot log [1] below that shows the failure as
> > > > well as the configuration file [2], however I am hitting what you see
> > > > below as of v6.2-10217-ga93e884edf61. Have not tried linux-next yet,
> > > > so if this is a known issue, please ignore :)
> > > >
> > > > This is seen with on a Raspberry pi 4B running in AArch64 mode.
> > > >
> > > > [1]: https://gist.github.com/b1a977b5fea837d180ccb800f091218a
> > > > [2]: https://gist.github.com/64cf18b6ee770d58f64371e1db01afb9
> > >
> > > From the config file:
> > >
> > > CONFIG_ARM=y
> > >
> > > Can you please provide the config file for the build you're seeing
> > > this on?
> >
> > Yes, sorry about that, here is the 64-bit configuration:
> >
> > https://gist.github.com/4eb83740c25b10f75b54560f8c8febb1
>
> I think the problem here is:
>
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>
> ... since GCC is known to ignore function alignment when -Os is passed.
>
> We can have DYNANMIC_FTRACE_WITH_CALL_OPS depend on
> !CONFIG_CC_OPTIMIZE_FOR_SIZE to prevent that.
I've sent out a patch updating arm64's Kconfig to handle this, which should
appear at:
https://lore.kernel.org/linux-arm-kernel/20230227115819.365630-1-mark.rutland@arm.com
... once lore next updates.
In local testing with GCC 11.3.0 and CONFIG_CC_OPTIMIZE_FOR_SIZE=y that did the
right thing and disabled CONFIG_DYNAMIC_FTRACE_WITH_CALL_OPS (and consequently
removed the warning).
Thanks,
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-27 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 23:39 Misaligned patch-site bcm2836_arm_irqchip_handle_irq+0x0/0x88 Florian Fainelli
2023-02-25 0:12 ` Florian Fainelli
2023-02-25 10:37 ` Marc Zyngier
2023-02-25 15:26 ` Florian Fainelli
2023-02-26 18:10 ` Florian Fainelli
2023-02-27 11:32 ` Mark Rutland
2023-02-27 12:10 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/ycGp4EN4mKjGKA@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox