public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v1] arm64/asm: Remove unused enable_da macro
@ 2022-10-19 12:03 Mark Brown
  2022-10-19 13:21 ` Mark Rutland
  2022-11-07 19:08 ` Will Deacon
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2022-10-19 12:03 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon; +Cc: linux-arm-kernel, Mark Brown

We no longer use the enable_da macro, remove it to avoid having to think
about maintaining it.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/include/asm/assembler.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
index e5957a53be39..27e0c75f7818 100644
--- a/arch/arm64/include/asm/assembler.h
+++ b/arch/arm64/include/asm/assembler.h
@@ -51,11 +51,6 @@
 	msr	daif, \flags
 	.endm
 
-	/* IRQ/FIQ are the lowest priority flags, unconditionally unmask the rest. */
-	.macro enable_da
-	msr	daifclr, #(8 | 4)
-	.endm
-
 /*
  * Save/restore interrupts.
  */

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] arm64/asm: Remove unused enable_da macro
  2022-10-19 12:03 [PATCH v1] arm64/asm: Remove unused enable_da macro Mark Brown
@ 2022-10-19 13:21 ` Mark Rutland
  2022-11-07 19:08 ` Will Deacon
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2022-10-19 13:21 UTC (permalink / raw)
  To: Mark Brown; +Cc: Catalin Marinas, Will Deacon, linux-arm-kernel

On Wed, Oct 19, 2022 at 01:03:45PM +0100, Mark Brown wrote:
> We no longer use the enable_da macro, remove it to avoid having to think
> about maintaining it.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Whhops; I had meant to remove that when I got rid of the last user in commit:

  064dbfb416914194 ("arm64: entry: convert IRQ+FIQ handlers to C")

FWIW:

  Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/include/asm/assembler.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
> index e5957a53be39..27e0c75f7818 100644
> --- a/arch/arm64/include/asm/assembler.h
> +++ b/arch/arm64/include/asm/assembler.h
> @@ -51,11 +51,6 @@
>  	msr	daif, \flags
>  	.endm
>  
> -	/* IRQ/FIQ are the lowest priority flags, unconditionally unmask the rest. */
> -	.macro enable_da
> -	msr	daifclr, #(8 | 4)
> -	.endm
> -
>  /*
>   * Save/restore interrupts.
>   */
> 
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] arm64/asm: Remove unused enable_da macro
  2022-10-19 12:03 [PATCH v1] arm64/asm: Remove unused enable_da macro Mark Brown
  2022-10-19 13:21 ` Mark Rutland
@ 2022-11-07 19:08 ` Will Deacon
  1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2022-11-07 19:08 UTC (permalink / raw)
  To: Mark Brown, Catalin Marinas; +Cc: kernel-team, Will Deacon, linux-arm-kernel

On Wed, 19 Oct 2022 13:03:45 +0100, Mark Brown wrote:
> We no longer use the enable_da macro, remove it to avoid having to think
> about maintaining it.
> 
> 

Applied to arm64 (for-next/trivial), thanks!

[1/1] arm64/asm: Remove unused enable_da macro
      https://git.kernel.org/arm64/c/e8e510411847

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-07 19:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-19 12:03 [PATCH v1] arm64/asm: Remove unused enable_da macro Mark Brown
2022-10-19 13:21 ` Mark Rutland
2022-11-07 19:08 ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox