Re: [net-next v3 2/6] net: dcb: add new apptrust attribute

From: <Daniel.Machon@microchip.com>
To: <petrm@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
	<UNGLinuxDriver@microchip.com>, <joe@perches.com>,
	<linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
	<Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [net-next v3 2/6] net: dcb: add new apptrust attribute
Date: Wed, 26 Oct 2022 12:10:23 +0000	[thread overview]
Message-ID: <Y1kmBMXluPI1Wmu/@DEN-LT-70577> (raw)
In-Reply-To: <87zgdizvfq.fsf@nvidia.com>

> > +     if (ops->dcbnl_getapptrust) {
> > +             u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] = {0};
> > +             int nselectors;
> > +
> > +             apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE);
> > +             if (!app)
> > +                     return -EMSGSIZE;
> > +
> > +             err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors);
> > +             if (err)
> > +                     return -EMSGSIZE;
> 
> This should return the error coming from the driver instead of
> -EMSGSIZE.

Hmm. The question is whether we should return at all if dcbnl_getapptrust()
fails, or just continue to fill whatever other ieee information is available?
Seems to be like the rest of the code in ieee_fill() just ignore that error.

> 
> Also, it should cancel the nest before returning.

Ack.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel