* [PATCH v2] arm64: armv8_deprecated: fix unused-function error
@ 2022-11-24 2:24 Ren Zhijie
2022-11-24 10:47 ` Mark Rutland
2022-11-25 13:24 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Ren Zhijie @ 2022-11-24 2:24 UTC (permalink / raw)
To: catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, yusongping, Ren Zhijie
If CONFIG_SWP_EMULATION is not set and
CONFIG_CP15_BARRIER_EMULATION is not set,
aarch64-linux-gnu complained about unused-function :
arch/arm64/kernel/armv8_deprecated.c:67:21: error: ‘aarch32_check_condition’ defined but not used [-Werror=unused-function]
static unsigned int aarch32_check_condition(u32 opcode, u32 psr)
^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
To fix this warning, modify aarch32_check_condition() with __maybe_unused.
Fixes: 0c5f416219da ("arm64: armv8_deprecated: move aarch32 helper earlier")
Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
---
Changes in v2:
- modify aarch32_check_condition() with __maybe_unused.
arch/arm64/kernel/armv8_deprecated.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
index ed0788cf6bbb..8a9052cf3013 100644
--- a/arch/arm64/kernel/armv8_deprecated.c
+++ b/arch/arm64/kernel/armv8_deprecated.c
@@ -64,7 +64,7 @@ struct insn_emulation {
#define ARM_OPCODE_CONDITION_UNCOND 0xf
-static unsigned int aarch32_check_condition(u32 opcode, u32 psr)
+static unsigned int __maybe_unused aarch32_check_condition(u32 opcode, u32 psr)
{
u32 cc_bits = opcode >> 28;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: armv8_deprecated: fix unused-function error
2022-11-24 2:24 [PATCH v2] arm64: armv8_deprecated: fix unused-function error Ren Zhijie
@ 2022-11-24 10:47 ` Mark Rutland
2022-11-25 13:24 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2022-11-24 10:47 UTC (permalink / raw)
To: Ren Zhijie
Cc: catalin.marinas, will, linux-arm-kernel, linux-kernel, yusongping
On Thu, Nov 24, 2022 at 02:24:29AM +0000, Ren Zhijie wrote:
> If CONFIG_SWP_EMULATION is not set and
> CONFIG_CP15_BARRIER_EMULATION is not set,
> aarch64-linux-gnu complained about unused-function :
>
> arch/arm64/kernel/armv8_deprecated.c:67:21: error: ‘aarch32_check_condition’ defined but not used [-Werror=unused-function]
> static unsigned int aarch32_check_condition(u32 opcode, u32 psr)
> ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> To fix this warning, modify aarch32_check_condition() with __maybe_unused.
>
> Fixes: 0c5f416219da ("arm64: armv8_deprecated: move aarch32 helper earlier")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> Changes in v2:
> - modify aarch32_check_condition() with __maybe_unused.
>
> arch/arm64/kernel/armv8_deprecated.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> index ed0788cf6bbb..8a9052cf3013 100644
> --- a/arch/arm64/kernel/armv8_deprecated.c
> +++ b/arch/arm64/kernel/armv8_deprecated.c
> @@ -64,7 +64,7 @@ struct insn_emulation {
>
> #define ARM_OPCODE_CONDITION_UNCOND 0xf
>
> -static unsigned int aarch32_check_condition(u32 opcode, u32 psr)
> +static unsigned int __maybe_unused aarch32_check_condition(u32 opcode, u32 psr)
> {
> u32 cc_bits = opcode >> 28;
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: armv8_deprecated: fix unused-function error
2022-11-24 2:24 [PATCH v2] arm64: armv8_deprecated: fix unused-function error Ren Zhijie
2022-11-24 10:47 ` Mark Rutland
@ 2022-11-25 13:24 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2022-11-25 13:24 UTC (permalink / raw)
To: mark.rutland, catalin.marinas, Ren Zhijie
Cc: kernel-team, Will Deacon, linux-arm-kernel, yusongping,
linux-kernel
On Thu, 24 Nov 2022 02:24:29 +0000, Ren Zhijie wrote:
> If CONFIG_SWP_EMULATION is not set and
> CONFIG_CP15_BARRIER_EMULATION is not set,
> aarch64-linux-gnu complained about unused-function :
>
> arch/arm64/kernel/armv8_deprecated.c:67:21: error: ‘aarch32_check_condition’ defined but not used [-Werror=unused-function]
> static unsigned int aarch32_check_condition(u32 opcode, u32 psr)
> ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> [...]
Applied to arm64 (for-next/undef-traps), thanks!
[1/1] arm64: armv8_deprecated: fix unused-function error
https://git.kernel.org/arm64/c/223d3a0d30b6
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-25 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-24 2:24 [PATCH v2] arm64: armv8_deprecated: fix unused-function error Ren Zhijie
2022-11-24 10:47 ` Mark Rutland
2022-11-25 13:24 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox