From: Gaurav Pathak <gauravpathak129@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vchiq_arm.c: Declare vchiq_platform_init as static
Date: Wed, 11 Jan 2023 14:55:29 +0530 [thread overview]
Message-ID: <Y76AiY2a02aSVp+r@gaurav-pc.bbrouter> (raw)
In-Reply-To: <Y756tY0wRxl/jamp@kroah.com>
Hi Greg,
After submitting the patch, I realized this is the duplicate patch of https://www.spinics.net/lists/arm-kernel/msg976512.html
I am in the process of reproducing the issue reported by kernel test robot in the original patch submission.
If I am successful, I will try to fix other warnings.
Best,
Gaurav
On Wed, Jan 11, 2023 at 10:00:37AM +0100, Greg KH wrote:
> On Wed, Jan 11, 2023 at 01:31:24PM +0530, Gaurav Pathak wrote:
> > Modified vchiq_platform_init() as static to fix sparse warning
> > > warning: symbol 'vchiq_platform_init' was not declared. Should it be
> > > static?
>
> Put the warning line all on one line, no need to wrap that.
>
> > Signed-off-by: Gaurav Pathak <gauravpathak129@gmail.com>
> > ---
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > index dc33490ba7fb..ffa517077b80 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > @@ -462,7 +462,7 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagel
> > cleanup_pagelistinfo(instance, pagelistinfo);
> > }
> >
> > -int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
> > +static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
> > {
> > struct device *dev = &pdev->dev;
> > struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev);
> > --
> > 2.39.0
> >
> >
>
> What changed to enable this version of the patch to work properly
> compared to the previous submissions that broke the build? Did you test
> this and it now works properly?
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-01-11 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 8:01 [PATCH] staging: vchiq_arm.c: Declare vchiq_platform_init as static Gaurav Pathak
2023-01-11 9:00 ` Greg KH
2023-01-11 9:25 ` Gaurav Pathak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y76AiY2a02aSVp+r@gaurav-pc.bbrouter \
--to=gauravpathak129@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox