From: Mark Rutland <mark.rutland@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] firmware/psci: Fix MEM_PROTECT_RANGE function numbers
Date: Thu, 5 Jan 2023 15:53:48 +0000 [thread overview]
Message-ID: <Y7byjJ4jhh27W/lZ@FVFF77S0Q05N> (raw)
In-Reply-To: <86r0w9nfqc.wl-maz@kernel.org>
On Thu, Jan 05, 2023 at 03:49:47PM +0000, Marc Zyngier wrote:
> On Fri, 25 Nov 2022 10:18:26 +0000,
> Will Deacon <will@kernel.org> wrote:
> >
> > PSCI v1.1 offers 32-bit and 64-bit variants of the MEM_PROTECT_RANGE
> > call using function identifier 20.
> >
> > Fix the incorrect definitions of the MEM_PROTECT_CHECK_RANGE calls in
> > the PSCI UAPI header.
> >
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 3137f2e60098 ("firmware/psci: Add debugfs support to ease debugging")
> > Signed-off-by: Will Deacon <will@kernel.org>
> > ---
> > include/uapi/linux/psci.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h
> > index 3511095c2702..42a40ad3fb62 100644
> > --- a/include/uapi/linux/psci.h
> > +++ b/include/uapi/linux/psci.h
> > @@ -58,7 +58,7 @@
> >
> > #define PSCI_1_1_FN_SYSTEM_RESET2 PSCI_0_2_FN(18)
> > #define PSCI_1_1_FN_MEM_PROTECT PSCI_0_2_FN(19)
> > -#define PSCI_1_1_FN_MEM_PROTECT_CHECK_RANGE PSCI_0_2_FN(19)
> > +#define PSCI_1_1_FN_MEM_PROTECT_CHECK_RANGE PSCI_0_2_FN(20)
> >
> > #define PSCI_1_0_FN64_CPU_DEFAULT_SUSPEND PSCI_0_2_FN64(12)
> > #define PSCI_1_0_FN64_NODE_HW_STATE PSCI_0_2_FN64(13)
> > @@ -67,7 +67,7 @@
> > #define PSCI_1_0_FN64_STAT_COUNT PSCI_0_2_FN64(17)
> >
> > #define PSCI_1_1_FN64_SYSTEM_RESET2 PSCI_0_2_FN64(18)
> > -#define PSCI_1_1_FN64_MEM_PROTECT_CHECK_RANGE PSCI_0_2_FN64(19)
> > +#define PSCI_1_1_FN64_MEM_PROTECT_CHECK_RANGE PSCI_0_2_FN64(20)
> >
> > /* PSCI v0.2 power state encoding for CPU_SUSPEND function */
> > #define PSCI_0_2_POWER_STATE_ID_MASK 0xffff
>
> Acked-by: Marc Zyngier <maz@kernel.org>
Likewise:
Acked-by: Mark Rutland <mark.rutland@arm.com>
> Should this be taken via the arm64 tree, together with [1]?
Yes please to both being queued via the arm64 tree.
Sorry for droppnig the ball here.
Going forward I'll try to be explicit w.r.t. how to queue PSCI bits; I'd be
happy to route them through arm64 generally if that arm64 maintainers are happy
with that.
Thanks,
Mark.
>
> Thanks,
>
> M.
>
> [1] https://lore.kernel.org/r/20230105090834.630238-1-maz@kernel.org
>
> --
> Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-05 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 10:18 [PATCH] firmware/psci: Fix MEM_PROTECT_RANGE function numbers Will Deacon
2023-01-05 15:49 ` Marc Zyngier
2023-01-05 15:53 ` Mark Rutland [this message]
2023-01-06 17:10 ` Will Deacon
2023-01-06 17:50 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7byjJ4jhh27W/lZ@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox