[PATCH] i2c: mxs: suppress probe-deferral error message

[PATCH] i2c: mxs: suppress probe-deferral error message

[Stefan Wahren]

During boot of I2SE Duckbill the kernel log contains a
confusing error:

  Failed to request dma

This is caused by i2c-mxs tries to request a not yet available DMA
channel (-EPROBE_DEFER). So suppress this message by using
dev_err_probe().

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 drivers/i2c/busses/i2c-mxs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index 5af5cffc444e..d113bed79545 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -826,8 +826,8 @@ static int mxs_i2c_probe(struct platform_device *pdev)
 	/* Setup the DMA */
 	i2c->dmach = dma_request_chan(dev, "rx-tx");
 	if (IS_ERR(i2c->dmach)) {
-		dev_err(dev, "Failed to request dma\n");
-		return PTR_ERR(i2c->dmach);
+		return dev_err_probe(dev, PTR_ERR(i2c->dmach),
+				     "Failed to request dma\n");
 	}
 
 	platform_set_drvdata(pdev, i2c);
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] i2c: mxs: suppress probe-deferral error message

[Fabio Estevam]

Hi Stefan,

On Sat, Jan 7, 2023 at 9:32 AM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> During boot of I2SE Duckbill the kernel log contains a
> confusing error:
>
>   Failed to request dma
>
> This is caused by i2c-mxs tries to request a not yet available DMA
> channel (-EPROBE_DEFER). So suppress this message by using
> dev_err_probe().
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] i2c: mxs: suppress probe-deferral error message

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 427 bytes --]

On Sat, Jan 07, 2023 at 01:32:29PM +0100, Stefan Wahren wrote:
> During boot of I2SE Duckbill the kernel log contains a
> confusing error:
> 
>   Failed to request dma
> 
> This is caused by i2c-mxs tries to request a not yet available DMA
> channel (-EPROBE_DEFER). So suppress this message by using
> dev_err_probe().
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Applied to for-current, thanks!


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel