From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: defconfig: Restore graphical consoles
Date: Mon, 12 Jul 2021 14:24:46 +0300 [thread overview]
Message-ID: <YOwmfqZnVzcsp+T/@pendragon.ideasonboard.com> (raw)
In-Reply-To: <2a4474be1d2c00c6ca97c2714844ea416a9ea9a9.1626084948.git.geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote:
> As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> CONFIG_FB"), CONFIG_FB is no longer auto-enabled. While CONFIG_FB may
> be considered unneeded for systems where graphics is provided by a DRM
> driver, R-Mobile A1 still relies on a frame buffer device driver for
> graphics support.
>
> Restore support for graphics on R-Mobile A1 and graphical consoles on
> DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
> Renesas ARM systems.
Does anyone still care about the Armadillo board ?
This being said, I think CONFIG_FB should be added , but for a different
reason. There's no KMS console driver, so the only option we have today,
even when a KMS driver is available, is to go through FBDEV emulation,
which requires CONFIG_FB to be enabled.
> Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued as a fix for v5.14.
> ---
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 66c8b0980a0a744d..d9a27e4e09140b43 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -135,6 +135,7 @@ CONFIG_DRM_SII902X=y
> CONFIG_DRM_SIMPLE_BRIDGE=y
> CONFIG_DRM_I2C_ADV7511=y
> CONFIG_DRM_I2C_ADV7511_AUDIO=y
> +CONFIG_FB=y
> CONFIG_FB_SH_MOBILE_LCDC=y
> CONFIG_BACKLIGHT_PWM=y
> CONFIG_BACKLIGHT_AS3711=y
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-12 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 10:16 [PATCH] ARM: shmobile: defconfig: Restore graphical consoles Geert Uytterhoeven
2021-07-12 11:24 ` Laurent Pinchart [this message]
2021-07-12 11:35 ` Geert Uytterhoeven
2021-07-12 11:43 ` Laurent Pinchart
2021-07-12 11:49 ` Geert Uytterhoeven
2021-07-12 12:04 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOwmfqZnVzcsp+T/@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox