From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: vc04_services: Convert kmap() to kmap_local_page()
Date: Fri, 1 Apr 2022 13:49:11 -0700 [thread overview]
Message-ID: <YkdlRw/p4WDKZqvg@iweiny-desk3> (raw)
In-Reply-To: <20220330191414.23141-1-fmdefrancesco@gmail.com>
On Wed, Mar 30, 2022 at 09:14:14PM +0200, Fabio M. De Francesco wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible. In file interface/vchiq_arm/vchiq_arm.c,
> function free_pagelist() calls kmap() / kunmap() from two places.
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Therefore, free_pagelist() is a function where the
> use of kmap_local_page() in place of kmap() is correctly suited.
>
> Convert to kmap_local_page() but, instead of open coding it, use the
> memcpy_to_page() helper.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
LGTM:
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index f0bfacfdea80..efb1383b5218 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -431,21 +431,18 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo,
> if (head_bytes > actual)
> head_bytes = actual;
>
> - memcpy((char *)kmap(pages[0]) +
> + memcpy_to_page(pages[0],
> pagelist->offset,
> fragments,
> head_bytes);
> - kunmap(pages[0]);
> }
> if ((actual >= 0) && (head_bytes < actual) &&
> - (tail_bytes != 0)) {
> - memcpy((char *)kmap(pages[num_pages - 1]) +
> - ((pagelist->offset + actual) &
> - (PAGE_SIZE - 1) & ~(g_cache_line_size - 1)),
> + (tail_bytes != 0))
> + memcpy_to_page(pages[num_pages - 1],
> + (pagelist->offset + actual) &
> + (PAGE_SIZE - 1) & ~(g_cache_line_size - 1),
> fragments + g_cache_line_size,
> tail_bytes);
> - kunmap(pages[num_pages - 1]);
> - }
>
> down(&g_free_fragments_mutex);
> *(char **)fragments = g_free_fragments;
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-01 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 19:14 [PATCH] staging: vc04_services: Convert kmap() to kmap_local_page() Fabio M. De Francesco
[not found] ` <3162339.aeNJFYEL58@leap>
2022-04-01 9:09 ` Greg Kroah-Hartman
2022-04-01 20:49 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkdlRw/p4WDKZqvg@iweiny-desk3 \
--to=ira.weiny@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox