From: Mark Rutland <mark.rutland@arm.com>
To: Rob Herring <robh@kernel.org>, Will Deacon <will@kernel.org>
Cc: Al Grant <al.grant@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm_pmu: Validate single/group leader events
Date: Tue, 12 Apr 2022 11:14:19 +0100 [thread overview]
Message-ID: <YlVQ+4R2KZ7Ra0+1@FVFF77S0Q05N> (raw)
In-Reply-To: <YlQ3q9YFhQU9JsBt@robh.at.kernel.org>
On Mon, Apr 11, 2022 at 09:14:03AM -0500, Rob Herring wrote:
> On Mon, Apr 11, 2022 at 11:04:26AM +0100, Mark Rutland wrote:
> > Hi Rob,
> >
> > On Fri, Apr 08, 2022 at 03:33:30PM -0500, Rob Herring wrote:
> > > In the case where there is only a cycle counter available (i.e.
> > > PMCR_EL0.N is 0) and an event other than CPU cycles is opened, the open
> > > should fail as the event can never possibly be scheduled. However, the
> > > event validation when an event is opened is skipped when the group
> > > leader is opened. Fix this by always validating the group leader events.
> > >
> > > Reported-by: Al Grant <al.grant@arm.com>
> > > Cc: Will Deacon <will@kernel.org>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > This looks obviously correct to me, so FWIW:
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Thanks.
>
> > Just to check, have you tested this (e.g. by running on a platform with
> > PMCR_EL0.N == 0, or hacking the PMU probing to report just the cycle counter)
>
> Yes, tested on FVP with 0 counters running the libperf evsel userspace
> access tests as that tries both the cycle counter and instruction
> counts.
Perfect, thanks!
Will, I assume that you'll pick this up.
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-12 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 20:33 [PATCH] arm_pmu: Validate single/group leader events Rob Herring
2022-04-11 10:04 ` Mark Rutland
2022-04-11 14:14 ` Rob Herring
2022-04-12 10:14 ` Mark Rutland [this message]
2022-04-13 11:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlVQ+4R2KZ7Ra0+1@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=al.grant@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox