From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
kaleshsingh@google.com, madvenka@linux.microsoft.com,
will@kernel.org
Subject: Re: [PATCH 2/6] arm64: stacktrace: delete PCS comment
Date: Wed, 13 Apr 2022 17:11:47 +0100 [thread overview]
Message-ID: <Ylb2Q+kMyP7a9NXO@FVFF77S0Q05N> (raw)
In-Reply-To: <YlbzUqTbOTYYGM0R@sirena.org.uk>
On Wed, Apr 13, 2022 at 04:59:14PM +0100, Mark Brown wrote:
> On Wed, Apr 13, 2022 at 03:59:06PM +0100, Mark Rutland wrote:
> > The comment at the top of stacktrace.c isn't all that helpful, as it's
> > not associated with the code which inspects the frame record, and the
> > code example isn't representative of common code generation today.
>
> Reviewed-by: Mark Brown <broonie@kernel.org>
>
> though I do wonder if it might be better to rather than remove it expand
> it to be a bit of an essay on what actually happens these days, that
> could be better placed in Documentation/ though.
FWIW, I want to add a Documentation/arm64/unwinding.{whatever} to give links to
the relevant documentation (e.g. the AAPCS64 docs) and to explain the
arm64-specific unwinding concerns, but I haven't had the chance to write that
yet.
Either way I'd like to remove this comment since it's both misplaced and
misleading, so thanks for the Reviewed-by tag!
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-13 16:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 14:59 [PATCH 0/6] arm64: stacktrace cleanups Mark Rutland
2022-04-13 14:59 ` [PATCH 1/6] arm64: stacktrace: remove NULL task check from unwind_frame() Mark Rutland
2022-04-13 14:59 ` [PATCH 2/6] arm64: stacktrace: delete PCS comment Mark Rutland
2022-04-13 15:02 ` Madhavan T. Venkataraman
2022-04-13 15:59 ` Mark Brown
2022-04-13 16:11 ` Mark Rutland [this message]
2022-04-13 14:59 ` [PATCH 3/6] arm64: stacktrace: make struct stackframe private to stacktrace.c Mark Rutland
2022-04-13 15:03 ` Madhavan T. Venkataraman
2022-04-13 15:59 ` Mark Brown
2022-04-13 14:59 ` [PATCH 4/6] arm64: stacktrace: rename unwinder functions Mark Rutland
2022-04-13 14:59 ` [PATCH 5/6] arm64: stacktrace: rename stackframe to unwind_state Mark Rutland
2022-04-13 14:59 ` [PATCH 6/6] arm64: stacktrace: align with common naming Mark Rutland
2022-04-13 16:00 ` Mark Brown
2022-04-19 17:10 ` [PATCH 0/6] arm64: stacktrace cleanups Kalesh Singh
2022-04-22 18:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylb2Q+kMyP7a9NXO@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kaleshsingh@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=madvenka@linux.microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox