From: Borislav Petkov <bp@alien8.de>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: michal.simek@xilinx.com, Shubhrajyoti.datta@xilinx.com,
mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH V2 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
Date: Thu, 21 Apr 2022 10:58:08 +0200 [thread overview]
Message-ID: <YmEcoIj63goth+aU@zn.tnic> (raw)
In-Reply-To: <20220421015313.5747-2-sherry.sun@nxp.com>
> Subject: Re: [PATCH V2 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
EDAC tree subject prefixes are of the format:
EDAC/<driver name>: Bla...
where "Bla starts with a capital letter".
What is "disable_intr support"?
I can figure it out when looking at the code but you need to make this
human-readable. For example
"Disable the error interrupt on Synopsys EDAC v3.x hardware"
Also, is it all caps V3.X or is it simply v3.x?
On Thu, Apr 21, 2022 at 09:53:12AM +0800, Sherry Sun wrote:
> V3.X Synopsys EDAC DDR doesn't have the QOS Interrupt register, need
> to change to use the ECC Clear Register to disable the interrupts.
Not "need to change" but "change".
From Documentation/process/submitting-patches.rst:
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."
Please have a look at that document.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-21 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 1:53 [PATCH V2 0/2] EDAC: synopsys: fix some bugs in V3.X Synopsys EDAC DDR driver Sherry Sun
2022-04-21 1:53 ` [PATCH V2 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR Sherry Sun
2022-04-21 8:58 ` Borislav Petkov [this message]
2022-04-21 1:53 ` [PATCH V2 2/2] EDAC: synopsys: re-enable the interrupts in intr_handler " Sherry Sun
2022-04-21 9:06 ` Borislav Petkov
2022-04-23 7:03 ` Sherry Sun
2022-04-26 14:58 ` Borislav Petkov
2022-04-27 1:40 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmEcoIj63goth+aU@zn.tnic \
--to=bp@alien8.de \
--cc=Shubhrajyoti.datta@xilinx.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rric@kernel.org \
--cc=sherry.sun@nxp.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox