From: Eric Biggers <ebiggers@kernel.org>
To: Nathan Huckleberry <nhuck@google.com>
Cc: linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Paul Crowley <paulcrowley@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v7 7/9] crypto: x86/polyval: Add PCLMULQDQ accelerated implementation of POLYVAL
Date: Mon, 9 May 2022 14:44:12 -0700 [thread overview]
Message-ID: <YnmLLEKTBoYLjiqm@sol.localdomain> (raw)
In-Reply-To: <20220509191107.3556468-8-nhuck@google.com>
On Mon, May 09, 2022 at 07:11:05PM +0000, Nathan Huckleberry wrote:
> diff --git a/arch/x86/crypto/polyval-clmulni_asm.S b/arch/x86/crypto/polyval-clmulni_asm.S
[...]
> +/*
> + * Computes the product of two 128-bit polynomials at the memory locations
> + * specified by (MSG + 16*i) and (KEY_POWERS + 16*i) and XORs the components of
> + * the 256-bit product into LO, MI, HI.
> + *
> + * Given:
> + * X = [X_1 : X_0]
> + * Y = [Y_1 : Y_0]
> + *
> + * We compute:
> + * LO += X_0 * Y_0
> + * MI += (X_0 + X_1) * (Y_0 + Y_1)
> + * HI += X_1 * Y_1
The above comment (changed in v7) is describing Karatsuba multiplication, but
the actual code is using schoolbook multiplication.
Otherwise this looks good:
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-09 21:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 19:10 [PATCH v7 0/9] crypto: HCTR2 support Nathan Huckleberry
2022-05-09 19:10 ` [PATCH v7 1/9] crypto: xctr - Add XCTR support Nathan Huckleberry
2022-05-09 19:11 ` [PATCH v7 2/9] crypto: polyval - Add POLYVAL support Nathan Huckleberry
2022-05-09 19:11 ` [PATCH v7 3/9] crypto: hctr2 - Add HCTR2 support Nathan Huckleberry
2022-05-09 19:11 ` [PATCH v7 4/9] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR Nathan Huckleberry
2022-05-09 19:11 ` [PATCH v7 5/9] crypto: arm64/aes-xctr: " Nathan Huckleberry
2022-05-09 19:11 ` [PATCH v7 6/9] crypto: arm64/aes-xctr: Improve readability of XCTR and CTR modes Nathan Huckleberry
2022-05-09 21:56 ` Eric Biggers
2022-05-09 19:11 ` [PATCH v7 7/9] crypto: x86/polyval: Add PCLMULQDQ accelerated implementation of POLYVAL Nathan Huckleberry
2022-05-09 21:44 ` Eric Biggers [this message]
2022-05-09 19:11 ` [PATCH v7 8/9] crypto: arm64/polyval: Add PMULL " Nathan Huckleberry
2022-05-09 21:41 ` Eric Biggers
2022-05-09 19:11 ` [PATCH v7 9/9] fscrypt: Add HCTR2 support for filename encryption Nathan Huckleberry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnmLLEKTBoYLjiqm@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=nhuck@google.com \
--cc=paulcrowley@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox