From: Qian Cai <quic_qiancai@quicinc.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, <linux-crypto@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64/crypto: Select AEAD2 for GHASH_ARM64_CE
Date: Thu, 23 Jun 2022 15:08:32 -0400 [thread overview]
Message-ID: <YrS6MIhv/ze4rbxy@qian> (raw)
In-Reply-To: <YrSgH//ysOd/Qumo@sol.localdomain>
On Thu, Jun 23, 2022 at 10:17:19AM -0700, Eric Biggers wrote:
> On Wed, Jun 22, 2022 at 10:25:57AM -0400, Qian Cai wrote:
> > Otherwise, we could fail to compile.
> >
> > ld: arch/arm64/crypto/ghash-ce-glue.o: in function 'ghash_ce_mod_exit':
> > ghash-ce-glue.c:(.exit.text+0x24): undefined reference to 'crypto_unregister_aead'
> > ld: arch/arm64/crypto/ghash-ce-glue.o: in function 'ghash_ce_mod_init':
> > ghash-ce-glue.c:(.init.text+0x34): undefined reference to 'crypto_register_aead'
> >
> > Fixes: 37b6aab68fae ("crypto: arm64/ghash - drop PMULL based shash")
>
> I don't see how the Fixes commit is related. Hasn't this been a problem since
> commit 537c1445ab0b, which added an AEAD algorithm to this module?
Ah, you are probably right. crypto_unregister_aead and crypto_register_aead
are already there in the previous commit.
>
> > diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig
> > index 4391a463abd7..6b2ecc193bc0 100644
> > --- a/arch/arm64/crypto/Kconfig
> > +++ b/arch/arm64/crypto/Kconfig
> > @@ -71,6 +71,7 @@ config CRYPTO_GHASH_ARM64_CE
> > select CRYPTO_HASH
> > select CRYPTO_GF128MUL
> > select CRYPTO_LIB_AES
> > + select CRYPTO_AEAD2
>
> I don't think CRYPTO_AEAD2 is meant to be selected directly. It should be
> CRYPTO_AEAD instead.
I am not sure about that. I chose CRYPTO_AEAD2 because that is in the
Makefile.
obj-$(CONFIG_CRYPTO_AEAD2) += aead.o
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-23 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 14:25 [PATCH] arm64/crypto: Select AEAD2 for GHASH_ARM64_CE Qian Cai
2022-06-23 17:17 ` Eric Biggers
2022-06-23 19:08 ` Qian Cai [this message]
2022-06-24 7:59 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrS6MIhv/ze4rbxy@qian \
--to=quic_qiancai@quicinc.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox