From: Vinod Koul <vkoul@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com,
Michael Trimarchi <michael@amarulasolutions.com>,
stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register
Date: Wed, 21 Sep 2022 08:53:23 +0530 [thread overview]
Message-ID: <YyqDq9FL1W5gMveQ@matsya> (raw)
In-Reply-To: <CABGWkvpur+A1UHwhJ6CCStyaYH79_aqJo4eWOW-s1p2jakbFMA@mail.gmail.com>
On 20-09-22, 19:10, Dario Binacchi wrote:
> Hi Vinoud,
>
> On Tue, Sep 13, 2022 at 6:35 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> > Hi Dario,
> >
> > On Sun, Sep 04, 2022 at 04:10:19PM +0200, Dario Binacchi wrote:
> > > Driver registration fails on SOC imx8mn as its supplier, the clock
> > > control module, is probed later than subsys initcall level. This driver
> > > uses platform_driver_probe which is not compatible with deferred probing
> > > and won't be probed again later if probe function fails due to clock not
> > > being available at that time.
> > >
> > > This patch replaces the use of platform_driver_probe with
> > > platform_driver_register which will allow probing the driver later again
> > > when the clock control module will be available.
> > >
> > > Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28")
> > > Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > > Cc: stable@vger.kernel.org
> >
> > How I see it v3 of this patch is perfectly fine and should be taken
> > instead of this one. I just commented that to v3.
> >
> > Not sure if Vinod would take v3, or if you should resend v3 as v6
> > instead. If you do, you can add my Acked-by.
> >
> > Vinod, please let us know what you prefer.
>
> Could you please let me know how to proceed? This patch has been pending for
> a while and it's a real shame as the change is minimal and fixes a
> real issue that is
> still present in the mainline and stable kernels.
Ooops, Somehow this seems to have really slipped. Sorry I owe you an
apology for this
I am still not sure of this patch yet, lets get it right and merged
quickly. I will send my review later today
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-21 3:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 14:10 [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Dario Binacchi
2022-09-04 14:10 ` [RESEND PATCH v5 2/2] dmaengine: mxs: fix section mismatch Dario Binacchi
2022-09-21 9:35 ` Robin Murphy
2022-09-13 16:35 ` [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Sascha Hauer
2022-09-20 17:10 ` Dario Binacchi
2022-09-21 3:23 ` Vinod Koul [this message]
2022-09-21 10:39 ` Sascha Hauer
2022-09-21 12:50 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2022-08-20 8:44 Dario Binacchi
2022-07-28 6:18 Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyqDq9FL1W5gMveQ@matsya \
--to=vkoul@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox