From: Baoquan He <bhe@redhat.com>
To: Chen Lifu <chenlifu@huawei.com>
Cc: linux@armlinux.org.uk, akpm@linux-foundation.org,
pmladek@suse.com, kexec@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core() static
Date: Wed, 28 Sep 2022 14:52:42 +0800 [thread overview]
Message-ID: <YzPvOjGWHxdcGUjh@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20220816074250.3991633-1-chenlifu@huawei.com>
On 08/16/22 at 03:42pm, Chen Lifu wrote:
> This symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> arch/arm/kernel/machine_kexec.c:76:6: warning: symbol 'machine_crash_nonpanic_core' was not declared. Should it be static?
>
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
LGTM,
Acked-by: Baoquan He <bhe@redhat.com>
> ---
> arch/arm/kernel/machine_kexec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f567032a09c0..a2e9ac763a9f 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -71,11 +71,11 @@ int machine_kexec_prepare(struct kimage *image)
>
> void machine_kexec_cleanup(struct kimage *image)
> {
> }
>
> -void machine_crash_nonpanic_core(void *unused)
> +static void machine_crash_nonpanic_core(void *unused)
> {
> struct pt_regs regs;
>
> crash_setup_regs(®s, get_irq_regs());
> printk(KERN_DEBUG "CPU %u will stop doing anything useful since another CPU has crashed\n",
> --
> 2.37.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-28 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 7:42 [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core() static Chen Lifu
2022-09-28 6:52 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzPvOjGWHxdcGUjh@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chenlifu@huawei.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox