From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] PCI: mediatek-gen3: Configure PBUS_CSR registers for EN7581 SoC
Date: Sat, 1 Feb 2025 13:10:00 +0100 [thread overview]
Message-ID: <Z54PGPz1fJ0yiTJw@lore-desk> (raw)
In-Reply-To: <20250118-astonishing-ermine-of-painting-4d3eaa@krzk-bin>
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
> On Wed, Jan 15, 2025 at 06:32:31PM +0100, Lorenzo Bianconi wrote:
[./.]
>
> No, don't sprinkle compatibles in other drivers. It does not scale, does
> not allow reuse and you kind of try to escape ABI break, but you won't.
> This is still clear ABI break without any statement in commit msg and
> without explanation.
>
> NAK.
>
> Relationship between devices is expressed with phandles. There are
> plenty of examples how to do that with syscon.
ack, I will fix it in v2.
Regards,
Lorenzo
>
> Best regards,
> Krzysztof
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-02-01 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 17:32 [PATCH 0/2] PCI: mediatek-gen3: Set PBUS_CSR regs for Airoha EN7581 SoC Lorenzo Bianconi
2025-01-15 17:32 ` [PATCH 1/2] dt-bindings: arm: airoha: Add the pbus-csr node for " Lorenzo Bianconi
2025-01-18 15:57 ` Krzysztof Kozlowski
2025-02-01 12:16 ` Lorenzo Bianconi
2025-02-02 14:38 ` Krzysztof Kozlowski
2025-01-15 17:32 ` [PATCH 2/2] PCI: mediatek-gen3: Configure PBUS_CSR registers " Lorenzo Bianconi
2025-01-18 15:59 ` Krzysztof Kozlowski
2025-02-01 12:10 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z54PGPz1fJ0yiTJw@lore-desk \
--to=lorenzo@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox