Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Vinod Koul <vkoul@kernel.org>,
	imx@lists.linux.dev, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages
Date: Wed, 5 Feb 2025 11:54:59 -0500	[thread overview]
Message-ID: <Z6OX47CASlYp1bXA@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250205091455.4593-1-wahrenst@gmx.net>

On Wed, Feb 05, 2025 at 10:14:55AM +0100, Stefan Wahren wrote:
> Not all log messages have a newline at the end. So fix it.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/fsl-edma-main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index f989b6c9c0a9..760c9e3e374c 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -164,7 +164,7 @@ static bool fsl_edma_srcid_in_use(struct fsl_edma_engine *fsl_edma, u32 srcid)
>  		fsl_chan = &fsl_edma->chans[i];
>
>  		if (fsl_chan->srcid && srcid == fsl_chan->srcid) {
> -			dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!");
> +			dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!\n");
>  			return true;
>  		}
>  	}
> @@ -822,7 +822,7 @@ static int fsl_edma_suspend_late(struct device *dev)
>  		spin_lock_irqsave(&fsl_chan->vchan.lock, flags);
>  		/* Make sure chan is idle or will force disable. */
>  		if (unlikely(fsl_chan->status == DMA_IN_PROGRESS)) {
> -			dev_warn(dev, "WARN: There is non-idle channel.");
> +			dev_warn(dev, "WARN: There is non-idle channel.\n");
>  			fsl_edma_disable_request(fsl_chan);
>  			fsl_edma_chan_mux(fsl_chan, 0, false);
>  		}
> --
> 2.34.1
>


  reply	other threads:[~2025-02-05 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05  9:14 [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages Stefan Wahren
2025-02-05 16:54 ` Frank Li [this message]
2025-02-10 14:35 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6OX47CASlYp1bXA@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=vkoul@kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox