* [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages
@ 2025-02-05 9:14 Stefan Wahren
2025-02-05 16:54 ` Frank Li
2025-02-10 14:35 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Wahren @ 2025-02-05 9:14 UTC (permalink / raw)
To: Frank Li, Vinod Koul; +Cc: imx, dmaengine, linux-arm-kernel, Stefan Wahren
Not all log messages have a newline at the end. So fix it.
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
drivers/dma/fsl-edma-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index f989b6c9c0a9..760c9e3e374c 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -164,7 +164,7 @@ static bool fsl_edma_srcid_in_use(struct fsl_edma_engine *fsl_edma, u32 srcid)
fsl_chan = &fsl_edma->chans[i];
if (fsl_chan->srcid && srcid == fsl_chan->srcid) {
- dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!");
+ dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!\n");
return true;
}
}
@@ -822,7 +822,7 @@ static int fsl_edma_suspend_late(struct device *dev)
spin_lock_irqsave(&fsl_chan->vchan.lock, flags);
/* Make sure chan is idle or will force disable. */
if (unlikely(fsl_chan->status == DMA_IN_PROGRESS)) {
- dev_warn(dev, "WARN: There is non-idle channel.");
+ dev_warn(dev, "WARN: There is non-idle channel.\n");
fsl_edma_disable_request(fsl_chan);
fsl_edma_chan_mux(fsl_chan, 0, false);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages
2025-02-05 9:14 [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages Stefan Wahren
@ 2025-02-05 16:54 ` Frank Li
2025-02-10 14:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-02-05 16:54 UTC (permalink / raw)
To: Stefan Wahren; +Cc: Vinod Koul, imx, dmaengine, linux-arm-kernel
On Wed, Feb 05, 2025 at 10:14:55AM +0100, Stefan Wahren wrote:
> Not all log messages have a newline at the end. So fix it.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/fsl-edma-main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index f989b6c9c0a9..760c9e3e374c 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -164,7 +164,7 @@ static bool fsl_edma_srcid_in_use(struct fsl_edma_engine *fsl_edma, u32 srcid)
> fsl_chan = &fsl_edma->chans[i];
>
> if (fsl_chan->srcid && srcid == fsl_chan->srcid) {
> - dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!");
> + dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!\n");
> return true;
> }
> }
> @@ -822,7 +822,7 @@ static int fsl_edma_suspend_late(struct device *dev)
> spin_lock_irqsave(&fsl_chan->vchan.lock, flags);
> /* Make sure chan is idle or will force disable. */
> if (unlikely(fsl_chan->status == DMA_IN_PROGRESS)) {
> - dev_warn(dev, "WARN: There is non-idle channel.");
> + dev_warn(dev, "WARN: There is non-idle channel.\n");
> fsl_edma_disable_request(fsl_chan);
> fsl_edma_chan_mux(fsl_chan, 0, false);
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages
2025-02-05 9:14 [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages Stefan Wahren
2025-02-05 16:54 ` Frank Li
@ 2025-02-10 14:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2025-02-10 14:35 UTC (permalink / raw)
To: Frank Li, Stefan Wahren; +Cc: imx, dmaengine, linux-arm-kernel
On Wed, 05 Feb 2025 10:14:55 +0100, Stefan Wahren wrote:
> Not all log messages have a newline at the end. So fix it.
>
>
Applied, thanks!
[1/1] dmaengine: fsl-edma: Add missing newlines to log messages
commit: 1c4c8609d498173382913b8ef6a105f3e6ff3472
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-10 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 9:14 [PATCH] dmaengine: fsl-edma: Add missing newlines to log messages Stefan Wahren
2025-02-05 16:54 ` Frank Li
2025-02-10 14:35 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox