Re: Aw: Re: [BUG] MTK SoC Ethernet throughput TX only ~620Mbit/s since 6.2-rc1

From: Daniel Golle <daniel@makrotopia.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: Frank Wunderlich <frank-w@public-files.de>,
	Mark Lee <Mark-MC.Lee@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	John Crispin <john@phrozen.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Aw: Re: [BUG] MTK SoC Ethernet throughput TX only ~620Mbit/s since 6.2-rc1
Date: Fri, 24 Mar 2023 13:47:10 +0000	[thread overview]
Message-ID: <ZB2p3kMLF2cWd8f/@makrotopia.org> (raw)
In-Reply-To: <4462a0c2-f7ea-c81c-e12f-ec629113fc40@nbd.name>

Hi Felix,
Hi Frank,

On Fri, Mar 24, 2023 at 12:52:09PM +0100, Felix Fietkau wrote:
> On 18.03.23 14:07, Frank Wunderlich wrote:
> > on BPI-R2 the eth0/gmac0 (tested with wan-port) is affected. here i have in TX-Direction only 620Mbit.
> > 
> > I have no idea yet why there the gmac0 is affected and on r3 only gmac1.
> > 
> > But it looks differently...on r3 the gmac1 is nearly completely broken.

If it looks "completely broken" as in you see only kilobits or even
complete starvation of RX, then you probably miss this fix:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=193250ace270fecd586dd2d0dfbd9cbd2ade977f

> Please try this patch and let me know if it resolves the regression:
> 
> ---
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -718,8 +718,6 @@ static void mtk_mac_link_up(struct phyli
>  		break;
>  	}
> -	mtk_set_queue_speed(mac->hw, mac->id, speed);
> -
>  	/* Configure duplex */
>  	if (duplex == DUPLEX_FULL)
>  		mcr |= MAC_MCR_FORCE_DPX;
> 
> 

I was about to suggest exactly this fix, and yes, it resolves the issue
and now I see full 1 Gbit/s speed on both, switch ports (even while 100M
connection is also used) and eth1 (via 1000Base-T SFP module).

Thank you for taking care of this!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel